[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696280#comment-17696280 ] Michael Semb Wever edited comment on CASSANDRA-17973 at 3/3/23 7:05 PM: Patches - cassandra-website: [https://github.com/apache/cassandra-website/compare/trunk...thelastpickle:cassandra-website:mck/17973] - cassandra: [https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/17973/trunk] - cassandra-dtest: [https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:cassandra-dtest:mck/17973] The C* patch has separated checkpoint (to-be-squash) commits for: * update MessagingService (remove the 4.1 version that was only a placeholder in test code bc serialisation test files were previously incorrectly serialising random UUIds for TimeUUIDs). ref [slack thread|https://the-asf.slack.com/archives/CK23JSY2K/p1677442675561789]. ** while I wanted to, MessagingService.minimum_version has not been bumped from 30 to 40. This is despite us not recommending or supporting users upgrading from 3.x directly to 5.0, and that from 4.0 we don't support cross-version streaming anyway. It gets complicated as MessagingService version is used in various serialisers, and any compatibility deserves a discuss dev@ thread (that I shall start, and follow up any warranted action in a separate ticket). * update upgrade jvm-dtests ** upgrade jvm-dtest's always need reviewing and adjusting… (open-ended manual upgrade paths often become redundant, some whole classes as well). * remove older serialization binary files we're no longer use in tests… CI - [https://ci-cassandra.apache.org/job/Cassandra-devbranch/2322/] - [https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/114] Failures are not related. was (Author: michaelsembwever): Patches - cassandra-website: [https://github.com/apache/cassandra-website/compare/trunk...thelastpickle:cassandra-website:mck/17973] - cassandra: [https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/17973/trunk] - cassandra-dtest: [https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:cassandra-dtest:mck/17973] The C* patch has separated checkpoint (to-be-squash) commits for: * update MessagingService (remove the 4.1 version that was only a placeholder in test code bc serialisation test files were previously incorrectly serialising random UUIds for TimeUUIDs). ref [slack thread|https://the-asf.slack.com/archives/CK23JSY2K/p1677442675561789]. * update upgrade jvm-dtests - -- upgrade jvm-dtest's always need reviewing and adjusting… (open-ended manual upgrade paths often become redundant, some whole classes as well). - remove older serialization binary files we're no longer use in tests… CI - [https://ci-cassandra.apache.org/job/Cassandra-devbranch/2322/] - [https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/114] Failures are not related. > Change trunk 4.2 to 5.0 > --- > > Key: CASSANDRA-17973 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17973 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > 1. Bump trunk's version > {code} > git switch trunk > # increment version to 5.0 > edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc > {code} > 2. Update jvm-dtest supported upgrade paths > - > https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 > > 3. Update `4.2` to jira versions > Change `4.2` to `5.0` > Change `4.x` to `5.x` > 4. Update docker images to include cassandra-5.0 > (Docker images also need to be deployed) > 5. Add pipeline to ci-cassandra > https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 > 6. Add dtest version and upgrade paths > - > https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py > - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 > - > https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41 > 7. Update how_to_commit documentation > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696280#comment-17696280 ] Michael Semb Wever edited comment on CASSANDRA-17973 at 3/3/23 7:00 PM: Patches - cassandra-website: [https://github.com/apache/cassandra-website/compare/trunk...thelastpickle:cassandra-website:mck/17973] - cassandra: [https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/17973/trunk] - cassandra-dtest: [https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:cassandra-dtest:mck/17973] The C* patch has separated checkpoint (to-be-squash) commits for: * update MessagingService (remove the 4.1 version that was only a placeholder in test code bc serialisation test files were previously incorrectly serialising random UUIds for TimeUUIDs). ref [slack thread|https://the-asf.slack.com/archives/CK23JSY2K/p1677442675561789]. * update upgrade jvm-dtests - -- upgrade jvm-dtest's always need reviewing and adjusting… (open-ended manual upgrade paths often become redundant, some whole classes as well). - remove older serialization binary files we're no longer use in tests… CI - [https://ci-cassandra.apache.org/job/Cassandra-devbranch/2322/] - [https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/114] Failures are not related. was (Author: michaelsembwever): Patches - cassandra-website: [https://github.com/apache/cassandra-website/compare/trunk...thelastpickle:cassandra-website:mck/17973] - cassandra: [https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/17973/trunk] - cassandra-dtest: [https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:cassandra-dtest:mck/17973] The C* patch has separated checkpoint (to-be-squash) commits for: * update MessagingService (remove the 4.1 version that was only a placeholder in test code bc serialisation test files were previously incorrectly serialising random UUIds for TimeUUIDs). ref [slack thread|https://the-asf.slack.com/archives/CK23JSY2K/p1677442675561789]. * update upgrade jvm-dtests - -- upgrade jvm-dtest's always need reviewing and adjusting… (open-ended manual upgrade paths often become redundant, some whole classes as well). - remove older serialization binary files we're no longer use in tests… CI - [https://ci-cassandra.apache.org/job/Cassandra-devbranch/2322/] - [https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/114] Failures are not related. > Change trunk 4.2 to 5.0 > --- > > Key: CASSANDRA-17973 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17973 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > 1. Bump trunk's version > {code} > git switch trunk > # increment version to 5.0 > edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc > {code} > 2. Update jvm-dtest supported upgrade paths > - > https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 > > 3. Update `4.2` to jira versions > Change `4.2` to `5.0` > Change `4.x` to `5.x` > 4. Update docker images to include cassandra-5.0 > (Docker images also need to be deployed) > 5. Add pipeline to ci-cassandra > https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 > 6. Add dtest version and upgrade paths > - > https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py > - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 > - > https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41 > 7. Update how_to_commit documentation > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680756#comment-17680756 ] Ekaterina Dimitrova edited comment on CASSANDRA-17973 at 1/25/23 7:09 PM: -- {quote}Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. {quote} Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is ongoing discussion to enable trunk to compile and test J17 when people want and when everything is ready to close CASSANDRA-16895, we will switch from J8+J11 to J11+J17 in CI. Feature branch to enable people to test was considered but it will make it more complicated. More info will be shared broadly soon. was (Author: e.dimitrova): {quote}Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. {quote} Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is ongoing discussion to enable trunk to compile and test J17 when people want and when everything is ready to close CASSANDRA-16895, we will switch from J8+J11 to J11+J17. Feature branch to enable people to test was considered but it will make it more complicated. More info will be shared broadly soon. > Change trunk 4.2 to 5.0 > --- > > Key: CASSANDRA-17973 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17973 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > 1. Bump trunk's version > {code} > git switch trunk > # increment version to 5.0 > edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc > {code} > 2. Update jvm-dtest supported upgrade paths > - > https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 > > 3. Update `4.2` to jira versions > Change `4.2` to `5.0` > Change `4.x` to `5.x` > 4. Update docker images to include cassandra-5.0 > (Docker images also need to be deployed) > 5. Add pipeline to ci-cassandra > https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 > 6. Add dtest version and upgrade paths > - > https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py > - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 > - > https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41 > 7. Update how_to_commit documentation > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680756#comment-17680756 ] Ekaterina Dimitrova edited comment on CASSANDRA-17973 at 1/25/23 7:09 PM: -- {quote}Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. {quote} Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is ongoing discussion to enable trunk to compile and test J17 when people want and when everything is ready to close CASSANDRA-16895, we will switch from J8+J11 to J11+J17 in CI. Feature branch to enable people to test was considered but it will make it more complicated. More info will be shared broadly soon, this strategy is fresh idea was (Author: e.dimitrova): {quote}Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. {quote} Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is ongoing discussion to enable trunk to compile and test J17 when people want and when everything is ready to close CASSANDRA-16895, we will switch from J8+J11 to J11+J17 in CI. Feature branch to enable people to test was considered but it will make it more complicated. More info will be shared broadly soon. > Change trunk 4.2 to 5.0 > --- > > Key: CASSANDRA-17973 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17973 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > 1. Bump trunk's version > {code} > git switch trunk > # increment version to 5.0 > edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc > {code} > 2. Update jvm-dtest supported upgrade paths > - > https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 > > 3. Update `4.2` to jira versions > Change `4.2` to `5.0` > Change `4.x` to `5.x` > 4. Update docker images to include cassandra-5.0 > (Docker images also need to be deployed) > 5. Add pipeline to ci-cassandra > https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 > 6. Add dtest version and upgrade paths > - > https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py > - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 > - > https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41 > 7. Update how_to_commit documentation > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680745#comment-17680745 ] Michael Semb Wever edited comment on CASSANDRA-17973 at 1/25/23 6:46 PM: - bq. Should we consider dropping JDK8 support while at it? Supporting three JDKs (8, 11, 17) would likely be an unreasonable burden that might not be worth it at this point in Java8 long life. That is the plan! (and has agreement on dev@) [~e.dimitrova] is leading the effort. Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. The removal of jdk8 is a trigger to bump build.xml to 5.0 (this ticket). This work is in progress and is a top and pressing priority. was (Author: michaelsembwever): bq. Should we consider dropping JDK8 support while at it? Supporting three JDKs (8, 11, 17) would likely be an unreasonable burden that might not be worth it at this point in Java8 long life. That is the plan! (and has agreement on dev@) [~e.dimitrova] is leading the effort. Because there are so many repositories and build/test components involved, to untangle the introduction of jdk17, we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then removing jdk8. The removal of jdk8 is a trigger to bump build.xml to 5.0 (this ticket). This work is in progress and has first priority. > Change trunk 4.2 to 5.0 > --- > > Key: CASSANDRA-17973 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17973 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > 1. Bump trunk's version > {code} > git switch trunk > # increment version to 5.0 > edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc > {code} > 2. Update jvm-dtest supported upgrade paths > - > https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 > > 3. Update `4.2` to jira versions > Change `4.2` to `5.0` > Change `4.x` to `5.x` > 4. Update docker images to include cassandra-5.0 > (Docker images also need to be deployed) > 5. Add pipeline to ci-cassandra > https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 > 6. Add dtest version and upgrade paths > - > https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py > - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 > - > https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41 > 7. Update how_to_commit documentation > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org