[
https://issues.apache.org/jira/browse/CASSANDRA-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680938#comment-17680938
]
Stefan Miklosovic edited comment on CASSANDRA-18185 at 1/26/23 10:21 AM:
-------------------------------------------------------------------------
thanks [~neshkeev] and [~polandll]
[~mck] I have question about non-documentation changes (changes related
non-asciidoc files)
NEWS.txt
CHANGES.txt
build.xml
I would not commit these changes. We might have a separate ticket for that
which would cover it systematically in all branches. For example when we change
typos in CHANGES.txt (Cassanda / Cassanra ...) to CASSANDRA, it might cause
some conflicts when merging up from 3.0 to trunk, for example ... no? Same with
NEWS.txt etc.
I would basically commit just adocs plus some minor changes in cassandra.yaml
(redundant spaces plus some commentary formulated little bit differently).
This is basically what we would like to commit to trunk _minus_ these three
files I mentioned above.
wdyt?
https://github.com/instaclustr/cassandra/commit/2ba97f2df6fee7bdc531576f331c57ce186139e8
was (Author: smiklosovic):
thanks [~neshkeev] and [~polandll]
[~mck] I have question about non-documentation changes (changes related
non-asciidoc files)
NEWS.txt
CHANGES.txt
build.xml
I would not commit these changes. We might have a separate ticket for that
which would cover it systematically in all branches. For example when we change
typos in CHANGES.txt (Cassanda / Cassanra ...) to CASSANDRA, it might case some
conflicts when merging up from 3.0 to trunk, for example ... no? Same with
NEWS.txt etc.
I would basically commit just adocs plus some minor changes in cassandra.yaml
(redundant spaces plus some commentary formulated little bit differently).
This is basically what we would like to commit to trunk _minus_ these three
files I mentioned above.
wdyt?
https://github.com/instaclustr/cassandra/commit/2ba97f2df6fee7bdc531576f331c57ce186139e8
> Accumulate all the `docs` PR from GitHub into a single patch
> ------------------------------------------------------------
>
> Key: CASSANDRA-18185
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18185
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation
> Reporter: Nikita Eshkeev
> Assignee: Nikita Eshkeev
> Priority: Low
> Fix For: 4.x
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> In order to make it easier to review the `docs` labeled pull-requests all of
> them should be accumulated into a single commit as per the
> [request|https://github.com/apache/cassandra/pull/2062#issuecomment-1385002289]
> from [~smiklosovic]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
