[jira] [Comment Edited] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented

2023-03-07 Thread maxwellguo (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697704#comment-17697704
 ] 

maxwellguo edited comment on CASSANDRA-18294 at 3/8/23 3:02 AM:


"private FSError throwFSError(){ " [~curlylrt]


was (Author: maxwellguo):
"private FSError throwFSError(){ "

> die disk failure policy will not kill jvm as documented
> ---
>
> Key: CASSANDRA-18294
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18294
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 3.0.x, 4.0.x, 4.1.x
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After Cassandra has successfully starts up with disk_failure_policy die, when 
> encounter a file system error, Cassandra server will only throw exception 
> instead of shut down gossip and client transport and kill JVM. Document: 
> [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy]
>  
> The reason for this is the default FS error handler is not handing policy die 
> correctly. Instead of shutting down gossip and native transport, it throws an 
> error.
>  
> The JVMStabilityInspectorTest is passing because the error handler is not set 
> so no exception is thrown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented

2023-03-01 Thread maxwellguo (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695456#comment-17695456
 ] 

maxwellguo edited comment on CASSANDRA-18294 at 3/2/23 5:27 AM:


I just run your ut, and it seems the bug exist.
I think you should add some more jvm-dtest as CASSANDRA-15191 's 
JVMStabilityInspectorCorruptSSTableExceptionTest .
For your ut can just cover gossip is stopped, also I left some comments on this 
pr.
[~smiklosovic] [~brandon.williams] can you take a look at this ?



was (Author: maxwellguo):
I just run your ut, and it seems the bug exist.
I think you should add some more jvm-dtest as CASSANDRA-15191 's 
JVMStabilityInspectorCorruptSSTableExceptionTest .
[~smiklosovic] [~brandon.williams] can you take a look at this ?


> die disk failure policy will not kill jvm as documented
> ---
>
> Key: CASSANDRA-18294
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18294
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
>
> After Cassandra has successfully starts up with disk_failure_policy die, when 
> encounter a file system error, Cassandra server will only throw exception 
> instead of shut down gossip and client transport and kill JVM. Document: 
> [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy]
>  
> The reason for this is the default FS error handler is not handing policy die 
> correctly. Instead of shutting down gossip and native transport, it throws an 
> error.
>  
> The JVMStabilityInspectorTest is passing because the error handler is not set 
> so no exception is thrown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented

2023-03-01 Thread maxwellguo (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695437#comment-17695437
 ] 

maxwellguo edited comment on CASSANDRA-18294 at 3/2/23 3:50 AM:


What is the version of your cassandra ?


was (Author: maxwellguo):
What is the version of your cassandr ?

> die disk failure policy will not kill jvm as documented
> ---
>
> Key: CASSANDRA-18294
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18294
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
>
> After Cassandra has successfully starts up with disk_failure_policy die, when 
> encounter a file system error, Cassandra server will only throw exception 
> instead of shut down gossip and client transport and kill JVM. Document: 
> [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy]
>  
> The reason for this is the default FS error handler is not handing policy die 
> correctly. Instead of shutting down gossip and native transport, it throws an 
> error.
>  
> The JVMStabilityInspectorTest is passing because the error handler is not set 
> so no exception is thrown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org