[jira] [Comment Edited] (CASSANDRA-18538) Disable chronicle analytics

2023-05-19 Thread Ariel Weisberg (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724337#comment-17724337
 ] 

Ariel Weisberg edited comment on CASSANDRA-18538 at 5/19/23 4:46 PM:
-

Another way to disable it that works even if someone changes Cassandra's 
configuration is to put it in a static initializer block. So for example maybe 
in `DatabaseDescriptor`, `FullQueryLogTool`, `BinLog`, and `AuditLogViewer`. 
This is still somewhat problematic because a lot of tests will also create 
queues and there is no guarantee we hit the static initializer block.

Also to record context, It looks like we actually never released a version that 
phones home because 
https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml#LL708C1-L709C1
 excludes the dependency for chronicle-analytics
It was added in 
https://github.com/apache/cassandra/commit/cf39d031279620eb5684ad384dff72f7325104cd#diff-766797f233c18114f9499750c[…]ea50283850619c01bd173132021R585
 before 4.0 was released. So we have never released with chronicle phoning home.

I only noticed that it has this feature because I was upgrading and changing 
how we included the dependency and that brought in the analytics library.


was (Author: aweisberg):
Another way to disable it that works even if someone changes Cassandra's 
configuration is to put it in a static initializer block. So for example maybe 
in `DatabaseDescriptor`, `FullQueryLogTool`, `BinLog`, and `AuditLogViewer`.

Also to record context, It looks like we actually never released a version that 
phones home because 
https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml#LL708C1-L709C1
 excludes the dependency for chronicle-analytics
It was added in 
https://github.com/apache/cassandra/commit/cf39d031279620eb5684ad384dff72f7325104cd#diff-766797f233c18114f9499750c[…]ea50283850619c01bd173132021R585
 before 4.0 was released. So we have never released with chronicle phoning home.

I only noticed that it has this feature because I was upgrading and changing 
how we included the dependency and that brought in the analytics library.

> Disable chronicle analytics
> ---
>
> Key: CASSANDRA-18538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18538
> Project: Cassandra
>  Issue Type: Bug
>  Components: Dependencies
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
>  At least chronicle-queue phones home to google analytics:  
> https://github.com/OpenHFT/Chronicle-Queue/blob/chronicle-queue-5.20.116/DISCLAIMER.adoc
> but we can disable all chronicle analytics with a single flag: 
> -Dchronicle.analytics.disable=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-18538) Disable chronicle analytics

2023-05-19 Thread Brandon Williams (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724336#comment-17724336
 ] 

Brandon Williams edited comment on CASSANDRA-18538 at 5/19/23 4:31 PM:
---

There are a couple choices of where to put this: jvm-server.options or 
cassandra-env.sh.  We want to reach as many installations as we can, but both 
files are config files, so packaging won't overwrite them if they are modified, 
and it seems like modification of either is somewhat likely.  I think 
jvm-server.options is probably less likely to be modified (because we have 
jvm8/11-server.options) than cassandra-env.sh, but that's just my gut feeling.

||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1014/workflows/5cf383f7-5d2f-4ad5-8b31-703f813f4fc0],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1014/workflows/52d05569-1d44-4974-b4ce-a0509a874b9f]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1015/workflows/15f708e4-64ff-4ccb-be50-6a1c73eeb05a],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1015/workflows/59461361-fc1e-43b8-bd90-f9b297844a23]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1013/workflows/f29cfd7f-d7f1-4fc6-af22-8b18eaec0b1d],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1013/workflows/56cd3f0c-d82d-4f72-bfc5-3b0154372f10]|

I'll start CI if this approach is agreed.


was (Author: brandon.williams):
There are a couple choices of where to put this: jvm-server.options or 
cassandra-env.sh.  We want to reach as many installations as we can, but both 
files are config files, so packaging won't overwrite them if they are modified, 
and it seems like modification of either is somewhat likely.  I think 
jvm-server.options is probably less likely to be modified (because we have 
jvm8/11-server.options) than cassandra-env.sh, but that's just my gut feeling.

||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1014/workflows/5cf383f7-5d2f-4ad5-8b31-703f813f4fc0],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1014/workflows/52d05569-1d44-4974-b4ce-a0509a874b9f]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1015/workflows/15f708e4-64ff-4ccb-be50-6a1c73eeb05a],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1015/workflows/59461361-fc1e-43b8-bd90-f9b297844a23]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18538-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1013/workflows/f29cfd7f-d7f1-4fc6-af22-8b18eaec0b1d],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1013/workflows/56cd3f0c-d82d-4f72-bfc5-3b0154372f10]|

I'll start CI if there is this approach is agreed.

> Disable chronicle analytics
> ---
>
> Key: CASSANDRA-18538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18538
> Project: Cassandra
>  Issue Type: Bug
>  Components: Dependencies
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
>  At least chronicle-queue phones home to google analytics:  
> https://github.com/OpenHFT/Chronicle-Queue/blob/chronicle-queue-5.20.116/DISCLAIMER.adoc
> but we can disable all chronicle analytics with a single flag: 
> -Dchronicle.analytics.disable=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org