[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936547#comment-15936547
]
Alex Petrov commented on CASSANDRA-10855:
-
Opened a follow-up ticket: [CASSANDRA-13367]
>
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789855#comment-15789855
]
Ben Manes commented on CASSANDRA-10855:
---
LGTM
> Use Caffeine (W-TinyLFU) for on-heap caches
>
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789473#comment-15789473
]
Robert Stupp commented on CASSANDRA-10855:
--
Yes, that's it. dtests & utests look good now.
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789277#comment-15789277
]
Ben Manes commented on CASSANDRA-10855:
---
Good observation [~snazy].
Yes, RE is propagated as
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789267#comment-15789267
]
Robert Stupp commented on CASSANDRA-10855:
--
Unit tests look good. However, a couple of
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760801#comment-15760801
]
ASF GitHub Bot commented on CASSANDRA-10855:
Github user ben-manes commented on the
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760800#comment-15760800
]
ASF GitHub Bot commented on CASSANDRA-10855:
Github user ben-manes closed the pull
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760734#comment-15760734
]
Robert Stupp commented on CASSANDRA-10855:
--
PR looks good - also rebased and removed the
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756939#comment-15756939
]
Robert Stupp commented on CASSANDRA-10855:
--
Heh, classic :)
Overseen the PR
> Use Caffeine
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756924#comment-15756924
]
Ben Manes commented on CASSANDRA-10855:
---
I think it's on your plate.
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756911#comment-15756911
]
Robert Stupp commented on CASSANDRA-10855:
--
Ping [~ben.manes]
> Use Caffeine (W-TinyLFU)
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642116#comment-15642116
]
Ben Manes commented on CASSANDRA-10855:
---
The penalty is small. In CLHM (and Guava) we didn't
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642106#comment-15642106
]
Robert Stupp commented on CASSANDRA-10855:
--
How big is the penalty without the JFP? On an
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642095#comment-15642095
]
Ben Manes commented on CASSANDRA-10855:
---
{quote}
I've added
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641960#comment-15641960
]
Robert Stupp commented on CASSANDRA-10855:
--
Alright, finally found some time to look at
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621068#comment-15621068
]
Ben Manes commented on CASSANDRA-10855:
---
Released 2.3.4 with JCTools fix. Please revisit.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602688#comment-15602688
]
Ben Manes commented on CASSANDRA-10855:
---
The test failure might be due to delegating
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601956#comment-15601956
]
Robert Stupp commented on CASSANDRA-10855:
--
Rebased your patch against current trunk and
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601225#comment-15601225
]
Robert Stupp commented on CASSANDRA-10855:
--
Sorry for the delay. Still on my plate.
> Use
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569354#comment-15569354
]
Ben Manes commented on CASSANDRA-10855:
---
Thanks. Fixed by updating the build.xml and removing
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568186#comment-15568186
]
Robert Stupp commented on CASSANDRA-10855:
--
Just asking because the jar's been changed but
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568181#comment-15568181
]
Ben Manes commented on CASSANDRA-10855:
---
I rebased and updated the jar in the PR. It's the same
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568161#comment-15568161
]
Robert Stupp commented on CASSANDRA-10855:
--
Haven't looked thoroughly through the code yet.
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381078#comment-15381078
]
Ben Manes commented on CASSANDRA-10855:
---
Any remaining blockers?
> Use Caffeine (W-TinyLFU)
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275473#comment-15275473
]
Ben Manes commented on CASSANDRA-10855:
---
[~blambov] [integrated |
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244885#comment-15244885
]
Ben Manes commented on CASSANDRA-10855:
---
We added protection against a HashDoS attack, thanks
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240837#comment-15240837
]
Benedict commented on CASSANDRA-10855:
--
We should definitely address Branimir's
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234302#comment-15234302
]
Benedict commented on CASSANDRA-10855:
--
Yes, I agree it would not be difficult, and the rest of
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234296#comment-15234296
]
Ben Manes commented on CASSANDRA-10855:
---
When Cassandra moves to TPC, it should take less than
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234287#comment-15234287
]
Benedict commented on CASSANDRA-10855:
--
Since I may be partially to blame for that, having made
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234277#comment-15234277
]
Ben Manes commented on CASSANDRA-10855:
---
Some unfortunate duplication of work on the DataStax
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178101#comment-15178101
]
Ben Manes commented on CASSANDRA-10855:
---
It sounds like we all thought Weibull was a good
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151814#comment-15151814
]
Robert Stupp commented on CASSANDRA-10855:
--
No, didn't had a chance to do it now. AFAIU it's
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150682#comment-15150682
]
Benjamin Lerer commented on CASSANDRA-10855:
[~snazy] did you had the chance to schedule
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136182#comment-15136182
]
Ben Manes commented on CASSANDRA-10855:
---
I think Weibull should be fine, too.
I rebased the
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117212#comment-15117212
]
Benedict commented on CASSANDRA-10855:
--
Zipf could easily be added. I added Weibull as the
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115737#comment-15115737
]
Ben Manes commented on CASSANDRA-10855:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115839#comment-15115839
]
Ariel Weisberg commented on CASSANDRA-10855:
stress supports [Weibull
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087252#comment-15087252
]
Ben Manes commented on CASSANDRA-10855:
---
The latest [snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087617#comment-15087617
]
Jeremy Hanna commented on CASSANDRA-10855:
--
As part of testing, should we also fix cstar
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087621#comment-15087621
]
Jonathan Ellis commented on CASSANDRA-10855:
(cstar is back.)
> Use Caffeine (W-TinyLFU)
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086242#comment-15086242
]
Ben Manes commented on CASSANDRA-10855:
---
Happy new year. Anything I can do to help keep this
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086257#comment-15086257
]
Robert Stupp commented on CASSANDRA-10855:
--
It would help if we would have some more
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086276#comment-15086276
]
Ben Manes commented on CASSANDRA-10855:
---
cstar returns "Internal Server Error" so I can't look
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071747#comment-15071747
]
Ben Manes commented on CASSANDRA-10855:
---
Do you know why the hit rate is so poor? It being low
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071764#comment-15071764
]
Ariel Weisberg commented on CASSANDRA-10855:
Is this testing with a uniform access
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056294#comment-15056294
]
Ariel Weisberg commented on CASSANDRA-10855:
I don't object to swapping CLHM with a new
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056445#comment-15056445
]
Ben Manes commented on CASSANDRA-10855:
---
A little background from private discussions with
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055544#comment-15055544
]
ASF GitHub Bot commented on CASSANDRA-10855:
GitHub user ben-manes opened a pull request:
[
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055546#comment-15055546
]
Ben Manes commented on CASSANDRA-10855:
---
See the [pull
50 matches
Mail list logo
