[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247813#comment-15247813
]
Sam Tunnicliffe commented on CASSANDRA-11310:
-
LGTM, modulo 2 minor nits which I can fix
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247740#comment-15247740
]
Alex Petrov commented on CASSANDRA-11310:
-
tests are now done, in dtests {{replication_test}}
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246493#comment-15246493
]
Alex Petrov commented on CASSANDRA-11310:
-
I've found one place where {{ALLOW FILTERING}}
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246414#comment-15246414
]
Benjamin Lerer commented on CASSANDRA-11310:
[~beobal] The patch should not have changed
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243541#comment-15243541
]
Benjamin Lerer commented on CASSANDRA-11310:
Thanks for the patch.
> Allow filtering on
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234894#comment-15234894
]
Alex Petrov commented on CASSANDRA-11310:
-
Added DTests in similar manner to:
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232249#comment-15232249
]
Benjamin Lerer commented on CASSANDRA-11310:
The patch looks good to me.
Could you add
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230915#comment-15230915
]
Alex Petrov commented on CASSANDRA-11310:
-
And the test results:
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223225#comment-15223225
]
Alex Petrov commented on CASSANDRA-11310:
-
I've found one problem. It turns out that the
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221603#comment-15221603
]
Benjamin Lerer commented on CASSANDRA-11310:
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220158#comment-15220158
]
Benjamin Lerer commented on CASSANDRA-11310:
Thanks the changes look good.
Waiting for
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208743#comment-15208743
]
Alex Petrov commented on CASSANDRA-11310:
-
I hope this time it should be a bit better.
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204332#comment-15204332
]
Benjamin Lerer commented on CASSANDRA-11310:
I agree that things should be simpler on top
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197574#comment-15197574
]
Tyler Hobbs commented on CASSANDRA-11310:
-
bq. In processClusteringColumnsRestrictions the
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197656#comment-15197656
]
Benjamin Lerer commented on CASSANDRA-11310:
While reviewing your latest patch I realized
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202782#comment-15202782
]
Alex Petrov commented on CASSANDRA-11310:
-
I've tried to get it all sorted out and have
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197559#comment-15197559
]
Benjamin Lerer commented on CASSANDRA-11310:
A bit of explanation regarding multi-column
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195515#comment-15195515
]
Benjamin Lerer commented on CASSANDRA-11310:
{quote}I'm still not sure if the handling of
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195464#comment-15195464
]
Alex Petrov commented on CASSANDRA-11310:
-
That totally makes sense. I've added tests for the
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195267#comment-15195267
]
Benjamin Lerer commented on CASSANDRA-11310:
{quote} so far the collection types aren't
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195230#comment-15195230
]
Alex Petrov commented on CASSANDRA-11310:
-
I'm making the changes you've listed, hope to have
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195110#comment-15195110
]
Benjamin Lerer commented on CASSANDRA-11310:
Thanks for the initial patch. Overall, I
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187376#comment-15187376
]
Benjamin Lerer commented on CASSANDRA-11310:
{quote}I'm not sure how fast I can pull it
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187360#comment-15187360
]
Alex Petrov commented on CASSANDRA-11310:
-
Thanks once again for the pointer!
I somehow
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187256#comment-15187256
]
Benjamin Lerer commented on CASSANDRA-11310:
{quote}I hope I'm not bugging you with
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187154#comment-15187154
]
Alex Petrov commented on CASSANDRA-11310:
-
I hope I'm not bugging you with questions too
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187081#comment-15187081
]
Benjamin Lerer commented on CASSANDRA-11310:
{{`(b_yr, b_mon) > ('2015', '06')`}} will
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186982#comment-15186982
]
Alex Petrov commented on CASSANDRA-11310:
-
[~blerer] I've moved forward a bit yesterday, as
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182948#comment-15182948
]
Benjamin Lerer commented on CASSANDRA-11310:
:-)
A couple of hints:
I believe that the
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182815#comment-15182815
]
Alex Petrov commented on CASSANDRA-11310:
-
[~blerer] absolutely! Will be happy to. I'll check
[
https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182807#comment-15182807
]
Benjamin Lerer commented on CASSANDRA-11310:
[~ifesdjeen] as you had started to look into
31 matches
Mail list logo
