[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2018-05-02 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460947#comment-16460947
 ] 

Gábor Auth commented on CASSANDRA-12697:


Hi guys,

I've tried to add a new DC to my cluster and I ran into a CDC bug via schema 
disagreement between the old DCs and the new DC (with version 3.11.0)...

I've diffed the good and the bad system_scheme tables. The only difference is 
the `cdc` field in three keyspaces (in `tables` and `views`):
- the value of `cdc` field on the good node is `False`
- the value of `cdc` field on the bad node is `null`

The value of `cdc` field on the other keyspaces is `null`. One or two years ago 
I've tried the CDC feature but switched off... after I updated the schema of 
the affected keyspaces on the new nodes with 'cdc=false' then everything is 
okay.

> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Major
> Fix For: 3.10
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-27 Thread Aleksey Yeschenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526099#comment-15526099
 ] 

Aleksey Yeschenko commented on CASSANDRA-12697:
---

LGTM

> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-23 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516630#comment-15516630
 ] 

Sylvain Lebresne commented on CASSANDRA-12697:
--

bq.  make sure you put this JIRA number into the place holder you left in 
SchemaKeyspace makeUpdateForSchema on commit

Oops, thanks. I'll just force-push it right now.

> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-23 Thread Jeremiah Jordan (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516616#comment-15516616
 ] 

Jeremiah Jordan commented on CASSANDRA-12697:
-

Did not review the code, but just reading through it wanted to comment to make 
sure you put this JIRA number into the place holder you left in SchemaKeyspace 
makeUpdateForSchema on commit.


> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-23 Thread Jeremiah Jordan (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516591#comment-15516591
 ] 

Jeremiah Jordan commented on CASSANDRA-12697:
-

[~philipthompson] yes, we should not be ignoring that error, we should have 
removed it from being ignored as part of CASSANDRA-12236

> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-23 Thread Philip Thompson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516541#comment-15516541
 ] 

Philip Thompson commented on CASSANDRA-12697:
-

It's the same exception, with the error {{Unknown column cdc during 
deserialization}}? Yeah, I 100% know why that's happening. When the original 
ticket for that was first filed, TE was told it was harmless and to ignore it 
in the tests. Looks like we never stopped ignoring it. Should I go ahead and 
change the tests to remove the exemption for this error?

> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12697) cdc column addition still breaks schema migration tasks

2016-09-23 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516000#comment-15516000
 ] 

Sylvain Lebresne commented on CASSANDRA-12697:
--

Attaching a patch below to skip the cdc column if cdc is disabled, like we did 
in CASSANDRA-12236, but on the code path used by schema migration requests:

| [12697-trunk|https://github.com/pcmanus/cassandra/commits/12697-trunk] | 
[utests|http://cassci.datastax.com/job/pcmanus-12697-trunk-testall] | 
[dtests|http://cassci.datastax.com/job/pcmanus-12697-trunk-dtest] |

I didn't noticed that during the testing of CASSANDRA-12236 because I focused 
on the upgrade from 2.x to 3.x, but schema migration tasks don't run then 
because of the messaging protocol version bump. So this really only affect 
upgrade from any 3.0.x or pre-CDC 3.x to a post-CDC 3.x.

An open question however is why our upgrade tests haven't caught this. It 
"seems" we run upgrades between 3.0 and 3.9/trunk (see 
[here|http://cassci.datastax.com/job/cassandra-3.9_dtest_upgrade/lastBuild/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x/]
 for instance) but said tests seem to be all passing, which is pretty 
suspisious to me because I'm able to reproduce the problem with [this beyond 
trivial upgrade 
test|https://github.com/pcmanus/cassandra-dtest/commit/f9c6057aa236be8e73c6cf116f98aa71a3bddf10]
 (which basically only creates a table and that's it). That test logs the error 
4 times (and fails due to that). So I'm wondering if the upgrade test are 
really running what they pretend they are running ([~philipthompson] would you 
mind having a quick look to check if anything wrong jumps out, our upgrade 
tests are a big mystery to me).


> cdc column addition still breaks schema migration tasks
> ---
>
> Key: CASSANDRA-12697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12697
> Project: Cassandra
>  Issue Type: Bug
>  Components: Distributed Metadata
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup of CASSANDRA-12236, which basically didn't fully fix the 
> problem. Namely, the fix from CASSANDRA-12236 skipped the {{cdc}} column in 
> {{SchemaKeyspace.addTableParamsToRowBuilder()}}, but that method isn't used 
> by schema "migration tasks" ({{MigrationRequestVerbHandler}}, which instead 
> directly send the content of the full schema table it reads from disk. So we 
> still end up with a RTE like CASSANDRA-12236. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)