[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975754#comment-15975754
]
mck commented on CASSANDRA-12835:
-
{quote}given a commented "+1" by the reviewer am I free to push
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973938#comment-15973938
]
mck commented on CASSANDRA-12835:
-
{quote}One nit: I think you've included an unused import in the
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972616#comment-15972616
]
T Jake Luciani commented on CASSANDRA-12835:
Changes make sense.
One nit: I think you've
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972551#comment-15972551
]
mck commented on CASSANDRA-12835:
-
[~tjake], patches are updated here:
|| Branch || Testall
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642828#comment-15642828
]
mck commented on CASSANDRA-12835:
-
> In lei of that, I'll add some unit tests that add a few
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623987#comment-15623987
]
mck commented on CASSANDRA-12835:
-
I'm still struggling to find a way (acceptable) to assert that the
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608033#comment-15608033
]
mck commented on CASSANDRA-12835:
-
Yes, unfortunately.
> Tracing payload not passed from
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606975#comment-15606975
]
Jeff Jirsa commented on CASSANDRA-12835:
{quote}I've found no suitable way to unit test
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606626#comment-15606626
]
mck commented on CASSANDRA-12835:
-
Patch at