[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Barak (Jira)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960577#comment-16960577
 ] 

Barak commented on CASSANDRA-13391:
---

Created [#CASSANDRA-15380]

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Jon Haddad (Jira)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959846#comment-16959846
 ] 

Jon Haddad commented on CASSANDRA-13391:


Please open up a new Jira for the patch.

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Barak (Jira)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959621#comment-16959621
 ] 

Barak commented on CASSANDRA-13391:
---

[~dvohra] Thanks for the pointer. Sent in a PR to fix.

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[DeepakVohra (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901389#comment-16901389
 ] 

DeepakVohra commented on CASSANDRA-13391:
-

The help for clearsnapshot needs to be updated to indicate requirement for 
--all to remove all snapshots. 

 
{code:java}
[ec2-user@ip-10-0-2-238 ~]$ nodetool help clearsnapshot
 NAME    nodetool clearsnapshot - Remove the snapshot with the given name 
from    the given keyspaces. If no snapshotName is specified we will remove 
all    snapshots{code}

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>Priority: Normal
> Fix For: 4.0
>
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Jon Haddad (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317321#comment-16317321
 ] 

Jon Haddad commented on CASSANDRA-13391:


[~zznate] Good call, I had added a note to CHANGES.txt but didn't have anything 
in NEWS.txt.  Pushed up 45c7c45616.

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
> Fix For: 4.0
>
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Jon Haddad (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317312#comment-16317312
 ] 

Jon Haddad commented on CASSANDRA-13391:


[~zznate] I did as a followup commit in e2e28a02e8, forgot to make a note here. 
 

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
> Fix For: 4.0
>
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[Nate McCall (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317307#comment-16317307
 ] 

Nate McCall commented on CASSANDRA-13391:
-

[~rustyrazorblade] Can you add line to NEWS.txt for 4.0 with this change? I 
know there are folks out there relying on this behavior in scripts and such and 
we are changing a default. 

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
> Fix For: 4.0
>
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305004#comment-16305004
 ] 

ASF GitHub Bot commented on CASSANDRA-13391:


Github user asfgit closed the pull request at:

https://github.com/apache/cassandra/pull/182


> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
> Fix For: 4.0
>
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301838#comment-16301838
 ] 

ASF GitHub Bot commented on CASSANDRA-13391:


GitHub user barakm opened a pull request:

https://github.com/apache/cassandra/pull/182

CASSANDRA-13391 Added --all to ClearSnapshot command

Added --all to ClearSnapshot command, so entering the command without a 
parameter will now throw an exception instead of deleting all the snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/barakm/cassandra 
CASSANDRA-13391-clear-all-snapshots-trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #182


commit acf3d3498f9c5c362115eda32cc704dd5eb126da
Author: Barak Merimovich 
Date:   2017-12-21T15:08:40Z

CASSANDRA-13391 Added --all to ClearSnapshot command, so entering the 
command without a parameter will now throw an exception instead of deleting all 
the snapshots.




> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301144#comment-16301144
 ] 

ASF GitHub Bot commented on CASSANDRA-13391:


Github user barakm closed the pull request at:

https://github.com/apache/cassandra/pull/181


> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301143#comment-16301143
 ] 

ASF GitHub Bot commented on CASSANDRA-13391:


Github user barakm commented on the issue:

https://github.com/apache/cassandra/pull/181
  
what the hell - it's the wrong branch. My mistake, clearly.


> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jon Haddad
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300164#comment-16300164
 ] 

ASF GitHub Bot commented on CASSANDRA-13391:


GitHub user barakm opened a pull request:

https://github.com/apache/cassandra/pull/181

CASSANDRA-13391 Added --all to ClearSnapshot command

Added --all to ClearSnapshot command, so entering the command without a 
parameter will now throw an exception instead of deleting all the snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/barakm/cassandra 
CASSANDRA-13391-clear-all-snapshots

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #181


commit 1e7c4b9c0584b5f63d121a5c37e0fc1e352e6108
Author: dr3s 
Date:   2017-06-20T17:23:17Z

Upgrade metrics to fix reconnect when reporting metrics.

Closes #123

Patch by dr3s and Jeff Jirsa; Reviewed by Stefan Podkowinski for 
CASSANDRA-13648

commit a5dff2f79621d7527a3837c0028d2e8b61d16e42
Author: ameya 
Date:   2017-07-19T03:37:10Z

Refactoring to specialised primitive functional interfaces in AuthCache.java

Closes #131

Patch by Ameya Ketkar; Reviewed by Jeff Jirsa for CASSANDRA-13732

commit 0a9e9db99c56eb2a8779dadf1926861436ca5f6e
Author: Andrés de la Peña 
Date:   2017-07-28T10:22:13Z

Merge branch '12952-3.11' into 12952-trunk

commit 0f6aeb6a59185e8ee022a5570ee8f585ec2ba21b
Author: Andrés de la Peña 
Date:   2017-07-28T10:25:06Z

Merge branch '12952-trunk' into trunk

commit 9b828275288b135812a247c3f2e9da2f20547111
Author: Paulo Motta 
Date:   2017-07-28T20:27:18Z

Merge branch 'cassandra-3.11' into trunk

commit 284271670c389f2b9fd11271c33eca5bb2a228fd
Author: Simon Zhou 
Date:   2017-03-31T03:45:03Z

Introduce error metrics for repair

patch by Simon Zhou; reviewed by Stefan Podkowinski for CASSANDRA-13387

commit de60cf0759e9721ddd1aab725c511a8f910cf415
Author: Jeff Jirsa 
Date:   2017-07-31T22:30:10Z

Merge branch 'cassandra-3.11' into trunk

commit fbcec0cc465dddc81134a15c42b292c35d3316b2
Author: Aleksey Yeschenko 
Date:   2017-08-01T14:40:23Z

Merge branch 'cassandra-3.11' into trunk

commit 8174fa510cd9007bba1f3726203fabf15b608d61
Author: Stefania Alborghetti 
Date:   2017-08-02T02:18:43Z

Merge branch 'cassandra-3.11' into trunk

commit 457733bd54c4a6c0ffd75aa6774c634b7623f116
Author: Stefan Podkowinski 
Date:   2017-08-03T10:52:41Z

Merge branch 'cassandra-3.11' into trunk

commit 32de990b7abf1ae54f31ba728a9860031d0f435c
Author: Aleksey Yeschenko 
Date:   2017-08-03T13:28:52Z

Merge branch 'cassandra-3.11' into trunk

commit cb32807f654cc8b11868cb1ed8e17657137d7ea2
Author: Andrés de la Peña 
Date:   2017-08-07T19:32:18Z

Merge branch 'cassandra-3.11' into trunk

commit 6b302b600f327cc8d1781776423d9548658e6591
Author: Roman Pogribnyi 
Date:   2017-07-22T20:06:01Z

Update DTest GitHub URLs - Use ASF DTest location

Patch by Roman Pogribnyi; Reviewed by Jeff Jirsa for CASSANDRA-13689

commit 9e3483f844d9db6fe2a6210550622fc2cd8aef72
Author: Chris Lohfink 
Date:   2017-07-10T15:46:34Z

Switch to client init for sstabledump

Closes #130

Patch by Chris Lohfink; Reviewed by Jeremiah Jordan for CASSANDRA-13683

commit 6dfd11c30a9c85581b77c93cfcdbef37a5d497c6
Author: Chris Lohfink 
Date:   2017-07-22T03:04:37Z

Improve sstablemetadata output

Patch by Chris Lohfink; reviewed by marcuse for CASSANDRA-11483

commit cad941653b59c4609ba2900cda86dc366d3ccd38
Author: Andrés de la Peña 
Date:   2017-08-08T14:27:15Z

Merge branch 'cassandra-3.11' into trunk

commit c00206297be451077034daf318eb8912825e135a
Author: Benjamin Lerer 
Date:   2017-08-08T15:13:18Z

Merge branch cassandra-3.11 into trunk

commit bcdbee5cdce6e22e6c97c5cab23fb2cf3265aa0d
Author: Michael Shuler 
Date:   2017-08-09T20:42:01Z

Enable ppc64le runtime as unsupported architecture

patch by Amitkumar Ghatwal and Michael Shuler; reviewed by Jeff Jirsa for 
CASSANDRA-13615

commit ba87ab4e954ad2e537f6690953bd7ebaa069f5cd
Author: Zhao Yang 
Date:   2017-07-24T10:13:14Z

Explicitly use e.getMessage() for log message formatting

patch by Zhao Yang; reviewed by Stefan Podkowinski for CASSANDRA-13723

commit 9c3354e3211c6a3f3982e87477e156c29cd9b7ea
Author: Blake Eggleston 
Date:  

[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots

[sankalp kohli (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947896#comment-15947896
 ] 

sankalp kohli commented on CASSANDRA-13391:
---

+1 on the idea. 

> nodetool clearsnapshot should require --all to clear all snapshots
> --
>
> Key: CASSANDRA-13391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13391
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jon Haddad
>
> Deleting all snapshots by default is insanely dangerous.  It would be like if 
> rm's default was -rf /.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)