[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384376#comment-17384376
]
Brandon Williams commented on CASSANDRA-13618:
--
This still looks valid, but needs a rebase for 4.0 and later.
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Jeff Jirsa
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119111#comment-17119111
]
Jeff Jirsa commented on CASSANDRA-13618:
[~samt] i have no idea if this patch matters anymore. Not in a position to
drive it if it does. Just FYI.
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154147#comment-16154147
]
Jeff Jirsa commented on CASSANDRA-13618:
Didnt get a chance to triage dtests before they rolled over back in July, so
kicked off anew:
3.0 -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/280/
3.11 -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/281/
trunk -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/282/
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057332#comment-16057332
]
Sam Tunnicliffe commented on CASSANDRA-13618:
-
Thanks, the changes LGTM. The dtest results still look a bit dodgy though,
particularly the 3.11 run. How stable are those dev branch jobs now? There seem
to be several tests failing/erroring which aren't showing as flaky on the
mainline branch jobs.
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054166#comment-16054166
]
Jeff Jirsa commented on CASSANDRA-13618:
Pushed new commits to all branches that:
- Make the specified methods package private, and
- Check TMD for tokens before calling hasExistingRoles (if no tokens, we
proceed down the original path).
Dtest links for the changes:
3.0 -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/99/
3.11 -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/100/
trunk -
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/101/
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053887#comment-16053887
]
Sam Tunnicliffe commented on CASSANDRA-13618:
-
Actually, I take back the comment about dtests, it looks like the failures in
{{cql_test:AbortedQueryTester}} are down to errors from the earlier existing
roles check during setup, before {{TokenMetadata}} is setup. CASSANDRA-11381
changed behaviour so that the auth setup also runs {{join_ring=false}}, but it
adds a guard in {{CRM::setupDefaultRole}} to check that {{TokenMetadata}} isn't
empty before calling {{hasExistingRoles}}. I think we'll need a similar check
in {{setup}} so that if TM is empty then we shouldn't try and set
{{isClusterReady}} eagerly.
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053810#comment-16053810
]
Sam Tunnicliffe commented on CASSANDRA-13618:
-
+1, only minor nit is that on {{CassandraRoleManager}}, {{hasExistingRoles}}
and {{isClusterReady}} could be made package private.
I haven't been able to look at the utest results as CircleCI is just giving me
the spinning logo treatment. Dtests look OK relative to upstream, there were a
couple of failures in the auth tests, but I checked them out locally and don't
believe they're related.
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052442#comment-16052442
]
Jeff Jirsa commented on CASSANDRA-13618:
Patches are very similar, but not exact (for example, trunk patch doesn't wait
on all-nodes-at-least-2.2, because that's already required)
|| branch | circle | dtest ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-13618] |
[3.0-circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-13618]
|
[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/95/]
|
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-13618] |
[3.11-circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-13618]
|
[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/96/]
|
| [trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-13618] |
[trunk-circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-13618]
|
[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/97/]
|
> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
> Issue Type: Bug
> Components: Auth
>Reporter: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for
> 10s after startup, and may not be necessary, meaning immediately after
> startup some auth related queries may not behave as intended. We can skip
> this delay without any additional risk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
