[jira] [Commented] (CASSANDRA-14431) Replace deprecated junit.framework.Assert usages with org.junit.Assert

2018-05-02 Thread Iuri Sitinschi (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460572#comment-16460572
 ] 

Iuri Sitinschi commented on CASSANDRA-14431:


[~jasobrown], thank you!

> Replace deprecated junit.framework.Assert usages with org.junit.Assert
> --
>
> Key: CASSANDRA-14431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14431
> Project: Cassandra
>  Issue Type: Test
>Reporter: Iuri Sitinschi
>Assignee: Iuri Sitinschi
>Priority: Minor
> Fix For: 4.0
>
> Attachments: 14431-trunk.txt
>
>
> I found a lot of tests which are still using old deprecated junit class 
> *junit.framework.Assert*. I suggest to replace it with recommended 
> *org.junit.Assert*. I can prepare a patch as soon as I receive a green light.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14431) Replace deprecated junit.framework.Assert usages with org.junit.Assert

2018-05-01 Thread Jason Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460382#comment-16460382
 ] 

Jason Brown commented on CASSANDRA-14431:
-

[~iuri_sitinschi] fwiw, we a guide for new contibutors 
[here|http://cassandra.apache.org/doc/latest/development/patches.html#creating-a-patch].
 I can review the attached patch without a problem, though - assuming it 
applies cleanly ;)

> Replace deprecated junit.framework.Assert usages with org.junit.Assert
> --
>
> Key: CASSANDRA-14431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14431
> Project: Cassandra
>  Issue Type: Test
>Reporter: Iuri Sitinschi
>Assignee: Iuri Sitinschi
>Priority: Minor
> Attachments: 14431-trunk.txt
>
>
> I found a lot of tests which are still using old deprecated junit class 
> *junit.framework.Assert*. I suggest to replace it with recommended 
> *org.junit.Assert*. I can prepare a patch as soon as I receive a green light.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14431) Replace deprecated junit.framework.Assert usages with org.junit.Assert

2018-05-01 Thread Iuri Sitinschi (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460165#comment-16460165
 ] 

Iuri Sitinschi commented on CASSANDRA-14431:


[~jasobrown] Submitted a patch. This is my first time contribution to 
Cassandra, so, please, correct me if anything is wrong.

> Replace deprecated junit.framework.Assert usages with org.junit.Assert
> --
>
> Key: CASSANDRA-14431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14431
> Project: Cassandra
>  Issue Type: Test
>Reporter: Iuri Sitinschi
>Priority: Minor
> Attachments: 14431-trunk.txt
>
>
> I found a lot of tests which are still using old deprecated junit class 
> *junit.framework.Assert*. I suggest to replace it with recommended 
> *org.junit.Assert*. I can prepare a patch as soon as I receive a green light.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14431) Replace deprecated junit.framework.Assert usages with org.junit.Assert

2018-05-01 Thread Iuri Sitinschi (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459858#comment-16459858
 ] 

Iuri Sitinschi commented on CASSANDRA-14431:


Don't see how to assign it to me. Probably I don't have necessary permissions. 
Consider it assigned ;)

> Replace deprecated junit.framework.Assert usages with org.junit.Assert
> --
>
> Key: CASSANDRA-14431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14431
> Project: Cassandra
>  Issue Type: Test
>Reporter: Iuri Sitinschi
>Priority: Minor
>
> I found a lot of tests which are still using old deprecated junit class 
> *junit.framework.Assert*. I suggest to replace it with recommended 
> *org.junit.Assert*. I can prepare a patch as soon as I receive a green light.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14431) Replace deprecated junit.framework.Assert usages with org.junit.Assert

2018-05-01 Thread Jason Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459847#comment-16459847
 ] 

Jason Brown commented on CASSANDRA-14431:
-

[~iuri_sitinschi] go for it!

> Replace deprecated junit.framework.Assert usages with org.junit.Assert
> --
>
> Key: CASSANDRA-14431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14431
> Project: Cassandra
>  Issue Type: Test
>Reporter: Iuri Sitinschi
>Priority: Minor
>
> I found a lot of tests which are still using old deprecated junit class 
> *junit.framework.Assert*. I suggest to replace it with recommended 
> *org.junit.Assert*. I can prepare a patch as soon as I receive a green light.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org