[ 
https://issues.apache.org/jira/browse/CASSANDRA-14489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506718#comment-16506718
 ] 

Patrick Bannister commented on CASSANDRA-14489:
-----------------------------------------------

There are some tests for cqlsh username/password login in the dtests. There are 
several of them in cqlsh_tests/cqlsh_tests.py::TestCqlLogin. I re-read my 
coverage report, and in fact, we did observe coverage of connecting with cqlsh 
using cassandra.auth.PlainTextAuthProvider.

Furthermore, the relevant dtests are passing for the pure Python 3 port.

We don't have coverage of using the LOGIN command during a connected cqlsh 
session, but I think it's sufficient that we're already testing the initial 
login with a password.

> Test cqlsh authentication
> -------------------------
>
>                 Key: CASSANDRA-14489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14489
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Patrick Bannister
>            Priority: Critical
>              Labels: cqlsh, security, test
>             Fix For: 4.x
>
>
> Coverage analysis of the cqlshlib unittests (pylib/cqlshlib/test/test*.py) 
> and the dtest cqlsh_tests (cqlsh_tests.py and cqlsh_copy_tests.py) showed no 
> coverage of authentication related code.
> Before we can release a port of cqlsh, we should identify an existing test 
> for cqlsh authentication, or write a new one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to