[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077375#comment-17077375
]
Aleksey Yeschenko commented on CASSANDRA-14772:
---
LGTM now, +1
> Fix issues in audit /
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977223#comment-16977223
]
Marcus Eriksson commented on CASSANDRA-14772:
-
thanks for the review, pushed 2 new
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921337#comment-16921337
]
Aleksey Yeschenko commented on CASSANDRA-14772:
---
Good stuff.
1. Would prefer if
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873990#comment-16873990
]
Per Otterström commented on CASSANDRA-14772:
+1
I'm not able to reproduce the failing
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871397#comment-16871397
]
Marcus Eriksson commented on CASSANDRA-14772:
-
thanks for having a look [~eperott],
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865091#comment-16865091
]
Per Otterström commented on CASSANDRA-14772:
Had a look at your patch [~krummas].
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809574#comment-16809574
]
Per Otterström commented on CASSANDRA-14772:
Created CASSANDRA-15076 to discuss record
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809552#comment-16809552
]
Marcus Eriksson commented on CASSANDRA-14772:
-
yep, sounds good, but this ticket is just
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809284#comment-16809284
]
Vinay Chella commented on CASSANDRA-14772:
--
Sounds reasonable to me [~eperott], please open
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809152#comment-16809152
]
Per Otterström commented on CASSANDRA-14772:
I'd like to add one improvement to the
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626327#comment-16626327
]
Benedict commented on CASSANDRA-14772:
--
Also, FWIW, I'm completely in favour of clarifying
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626318#comment-16626318
]
Joshua McKenzie commented on CASSANDRA-14772:
-
{quote}I've looked up [the original
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626309#comment-16626309
]
Jordan West commented on CASSANDRA-14772:
-
[~JoshuaMcKenzie] I appreciate you ensuring we
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626283#comment-16626283
]
Benedict commented on CASSANDRA-14772:
--
bq. Opinion presented as fact ftw.
I've looked up [the
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626226#comment-16626226
]
Dinesh Joshi commented on CASSANDRA-14772:
--
{quote}What I will say here: refactoring code
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626158#comment-16626158
]
Joshua McKenzie commented on CASSANDRA-14772:
-
Opinion presented as fact ftw. :)
There
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625918#comment-16625918
]
Aleksey Yeschenko commented on CASSANDRA-14772:
---
This is too legalistic of an
[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625911#comment-16625911
]
Jeremiah Jordan commented on CASSANDRA-14772:
-
If this is not a refactor ticket, but a
18 matches
Mail list logo