[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-12-20 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725814#comment-16725814
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

and committed as {{23d722ee3a7b91bfe5ee6fe64d090ff247e80438}}, thanks!

of course I messed up the commit message and said ant-junit instead of 
ant-optional, the doc change should be correct though

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.18, 3.11.4, 4.0
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-12-19 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725101#comment-16725101
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

[~jmeredithco] yeah I think it might be because I ran on the low resource 
circle config - there is CASSANDRA-14922 which seems to be addressing those 
issues

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-12-19 Thread Jon Meredith (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725089#comment-16725089
 ] 

Jon Meredith commented on CASSANDRA-14915:
--

Patches all look good.  Does 
org.apache.cassandra.distributed.DistributedReadWritePathTest on trunk 
experience intermittent failures? I had a quick look but couldn't see much more 
than abnormal VM exit as the reason.

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-12-19 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725012#comment-16725012
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

3.0 branch: https://github.com/krummas/cassandra/commits/marcuse/14915-3.0
3.0 test run: 
https://circleci.com/workflow-run/6328c243-e81d-48cb-bb46-75920200d73e
3.11 branch: https://github.com/krummas/cassandra/commits/marcuse/14915-3.11
3.11 test run: 
https://circleci.com/workflow-run/eeed3f28-4230-48e7-8fc0-41db30df45da
trunk branch: https://github.com/krummas/cassandra/commits/marcuse/14915-trunk
trunk test run: 
https://circleci.com/workflow-run/6ae5b998-caa5-41ff-b172-f74c9a266950

note the documentation update on the trunk branch:
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14915-trunk?expand=1#diff-1a8570f8bfa11221c5ea6eb81bf4f22eR55
I only added it to the trunk branch since we don't have any in-tree docs in the 
other branches, but users will most likely google the error and find this^

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705252#comment-16705252
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

bq. I worked out you meant ant-optional
ah sorry about that

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Jon Meredith (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705253#comment-16705253
 ] 

Jon Meredith commented on CASSANDRA-14915:
--

Gave Ubuntu 16.04 a go - if you don't have {{ant-optionals}} installed the 
patch allows the {{ant build}} command to succeed, however the tests still 
won't run without {{ant-optionals}} installed as that contains the junit 
integration. 

Anyway, patch works as advertised (lowering the test timeout still triggers 
stack traces) - however I'm not sure why somebody would want to run without 
ant-junit available.

+1

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Jon Meredith (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705226#comment-16705226
 ] 

Jon Meredith commented on CASSANDRA-14915:
--

I worked out you meant ant-optional on the Debian derived ones - agreed we'll 
just need document requiring ant-junit on Fedora et al, and will test the patch 
against a distro with ant-optional available too.

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Jon Meredith (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705169#comment-16705169
 ] 

Jon Meredith commented on CASSANDRA-14915:
--

I think that class is always packaged up in the {{ant-junit}} dependency, I 
grabbed the rpm and expanded it and checked the class is there.  I couldn't 
find an {{ant-optional}} package that included it under the standard repos.

{code}
[jmeredith@localhost x]$ jar tvf ./usr/share/java/ant/ant-junit.jar | grep 
JUnitTask
1746 Wed Mar 01 08:56:26 MST 2017 
org/apache/tools/ant/taskdefs/optional/junit/JUnitTask$1.class
{code}

If you always need to install {{ant-junit}} on Fedora, does this patch still 
have value other than permitting the build task to succeed (and none of the 
test tasks)?

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705065#comment-16705065
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

yeah we need to document that tests depend on ant-optional on fedora, I'll 
update the patch with that next week

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-30 Thread Jon Meredith (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705028#comment-16705028
 ] 

Jon Meredith commented on CASSANDRA-14915:
--

I've confirmed the patch allows you to get beyond the initial error in the 
description on Fedora 26 and complete an {{ant build}}. However, it still 
requires ant-junit to be installed to get any of the test targets to complete 
(which are needed for {{jar}}/{{package}} targets).

Is this what you were hoping to achieve, or did you also expect the unit tests 
to be able to run with just {{ant}} and {{java-1.8.0-openjdk-devel}} installed?

An alternative would be to be more explicit about which dependencies are needed 
to build on Fedora in the docs.

 

 

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14915) Handle ant-optional dependency

2018-11-28 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702815#comment-16702815
 ] 

Marcus Eriksson commented on CASSANDRA-14915:
-

tested on Debian, Linux Mint and Fedora and with the ant 1.10 tarball, it fails 
only on Fedora, workaround for now is to {{yum install ant-junit}}, but working 
on a patch to not fail the build if it is not available.

> Handle ant-optional dependency
> --
>
> Key: CASSANDRA-14915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14915
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>
> CASSANDRA-13117 added a JUnit task which dumps threads on unit test timeout, 
> and it depends on a class in {{org.apache.tools.ant.taskdefs.optional}} which 
> seems to not always be present depending on how {{ant}} was installed. It can 
> cause this error when building;
> {code:java}
> Throws: cassandra-trunk/build.xml:1134: taskdef A class needed by class 
> org.krummas.junit.JStackJUnitTask cannot be found:
> org/apache/tools/ant/taskdefs/optional/junit/JUnitTask  using the classloader
> AntClassLoader[/.../cassandra-trunk/lib/jstackjunit-0.0.1.jar]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org