[
https://issues.apache.org/jira/browse/CASSANDRA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743414#comment-16743414
]
Ariel Weisberg commented on CASSANDRA-14920:
--------------------------------------------
I resolved this as part of 14421, I modifed
https://github.com/apache/cassandra-dtest/commit/84598f11513f4c1dc0be4d7115a47b59940a649e#diff-96abe2232f1118eb0579d88abe504a9eL167
a bit and also pointed some tests at the other equality method that creates an
order by sorting on a key.
> Some comparisons used for verifying paging queries in dtests only test the
> column names and not values
> ------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14920
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14920
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Sam Tunnicliffe
> Assignee: Ariel Weisberg
> Priority: Major
>
> The implementation of {{PageAssertionMixin::assertEqualIgnoreOrder}}
> introduced in CASSANDRA-14134 can't be used to compare expected and actual
> results when the row data is represented by a {{dict}}. The underlying
> {{list_to_hashed_dict}} function expected lists of values and when it
> encounters a dict, it constructs its normalized list using only the keys. So
> the actual result values may be completely wrong, but as long as the field
> names are the same the equality check will pass. This affects only
> {{paging_tests.py}} and {{upgrade_tests/paging_test.py}}, and looks like it
> maybe a leftover from an earlier dev iteration, as some tests in the affected
> fixtures are already using the alternative (and correct)
> {{assertions.py::assert_lists_equal_ignoring_order}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
