[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-02-04 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759846#comment-16759846 ] Alex Petrov commented on CASSANDRA-14922: - I've investigated this one a bit further, but to

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-24 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751659#comment-16751659 ] Benedict commented on CASSANDRA-14922: -- FWIW, I don't suspect anything. I have had

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-24 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751398#comment-16751398 ] Joseph Lynch commented on CASSANDRA-14922: -- [~ifesdjeen] they are no longer JVM level OOMs;

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-24 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751020#comment-16751020 ] Alex Petrov commented on CASSANDRA-14922: - [~jolynch] to be honest I do not see OOMs so far.

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-23 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750488#comment-16750488 ] Joseph Lynch commented on CASSANDRA-14922: -- I'm getting trunk failures again as of, and

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-15 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743312#comment-16743312 ] Benedict commented on CASSANDRA-14922: -- Thanks, committed follow-up as

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-15 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743066#comment-16743066 ] Alex Petrov commented on CASSANDRA-14922: - +1 for the latest version, huge improvement! >

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-14 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742246#comment-16742246 ] Benedict commented on CASSANDRA-14922: -- I've pushed an update with the suggested changes, and

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-14 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742047#comment-16742047 ] Benedict commented on CASSANDRA-14922: -- Thanks for the review. I'll push an update shortly,

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-14 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741910#comment-16741910 ] Alex Petrov commented on CASSANDRA-14922: - [~benedict] thank you for the patch. It does look

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-11 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740530#comment-16740530 ] Benedict commented on CASSANDRA-14922: -- I've pushed a branch 

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-09 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738600#comment-16738600 ] Benedict commented on CASSANDRA-14922: -- On a related topic, it might be nice to eventually

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-09 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738597#comment-16738597 ] Benedict commented on CASSANDRA-14922: -- In back porting this to 3.0, I wondered if it was worth

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-09 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738278#comment-16738278 ] Alex Petrov commented on CASSANDRA-14922: - Committed to trunk with

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737726#comment-16737726 ] Joseph Lynch commented on CASSANDRA-14922: -- {quote} Sure thing. I'll start the rebase

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737711#comment-16737711 ] Benedict commented on CASSANDRA-14922: -- bq. can we wait for Alex to see the latest diff

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737614#comment-16737614 ] Joseph Lynch commented on CASSANDRA-14922: -- [~benedict], Awesome, can we wait for Alex to

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737557#comment-16737557 ] Benedict commented on CASSANDRA-14922: -- Marking 'Ready to Commit' given [~ifesdjeen]'s

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737552#comment-16737552 ] Joseph Lynch commented on CASSANDRA-14922: -- {quote}The patch looks good, and I'd say 

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2019-01-08 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737083#comment-16737083 ] Alex Petrov commented on CASSANDRA-14922: - The patch looks good, and I'd say [~jolynch]

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-13 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720109#comment-16720109 ] Benedict commented on CASSANDRA-14922: -- Do you know where the soft references originate? I

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-12 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719715#comment-16719715 ] Joseph Lynch commented on CASSANDRA-14922: -- I found a better workaround (in

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-12 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718972#comment-16718972 ] Benedict commented on CASSANDRA-14922: -- [~jolynch]: nice work, somehow I hadn't spotted this

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-11 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718514#comment-16718514 ] Joseph Lynch commented on CASSANDRA-14922: -- I think I figured it out, it turns out that 

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-11 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718243#comment-16718243 ] Joseph Lynch commented on CASSANDRA-14922: -- Nailed the MessageSink leak and properly shuts

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-07 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713487#comment-16713487 ] Joseph Lynch commented on CASSANDRA-14922: -- Alright, I think I'm narrowing in on this. I've

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-04 Thread Joseph Lynch (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709389#comment-16709389 ] Joseph Lynch commented on CASSANDRA-14922: -- Definitely have to keep the shutdown fast, I

[jira] [Commented] (CASSANDRA-14922) In JVM dtests need to clean up after instance shutdown

2018-12-04 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709185#comment-16709185 ] Alex Petrov commented on CASSANDRA-14922: - {{close}} is not waiting for full instance