[jira] [Commented] (CASSANDRA-15098) Endpoints no longer owning tokens are not removed for vnode
[ https://issues.apache.org/jira/browse/CASSANDRA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372950#comment-17372950 ] Brandon Williams commented on CASSANDRA-15098: -- Needs minor rebasing. > Endpoints no longer owning tokens are not removed for vnode > --- > > Key: CASSANDRA-15098 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15098 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.x > > > The logical here to remove endpoints no longer owning tokens is not working > for multiple tokens (vnode): > https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/service/StorageService.java#L2505 > And it's very expensive to copy the tokenmetadata for every check. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15098) Endpoints no longer owning tokens are not removed for vnode
[ https://issues.apache.org/jira/browse/CASSANDRA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889202#comment-16889202 ] Jay Zhuang commented on CASSANDRA-15098: Rebased the code and passed tests, please review: | Branch | uTest | jvm-dTest | dTest | dTest vnode | | [15098-3.0|https://github.com/instagram/cassandra/tree/15098-3.0] | [#107 passed |https://circleci.com/gh/Instagram/cassandra/107] | [#108 failed|https://circleci.com/gh/Instagram/cassandra/108], known issue: CASSANDRA-15239 | [#110 failed|https://circleci.com/gh/Instagram/cassandra/110], passed locally, known issue: CASSANDRA-14595 | [#109 failed | https://circleci.com/gh/Instagram/cassandra/109], passed locally, known issue: CASSANDRA-14595 | | [15098-3.11|https://github.com/instagram/cassandra/tree/15098-3.11] | [#100 passed|https://circleci.com/gh/Instagram/cassandra/100] | [#99 passed|https://circleci.com/gh/Instagram/cassandra/99] | [#111 failed|https://circleci.com/gh/Instagram/cassandra/111], passed locally: CASSANDRA-14595 | [#112 failed|https://circleci.com/gh/Instagram/cassandra/112], passed locally: CASSANDRA-14595 | | [15098-trunk|https://github.com/instagram/cassandra/tree/15098-trunk] | [#104 failed|https://circleci.com/gh/Instagram/cassandra/104], passed locally and re-run passed [#117|https://circleci.com/gh/Instagram/cassandra/117] | [#105 passed|https://circleci.com/gh/Instagram/cassandra/105] | [#114 passed|https://circleci.com/gh/Instagram/cassandra/114] | [#113 passed|https://circleci.com/gh/Instagram/cassandra/113] | > Endpoints no longer owning tokens are not removed for vnode > --- > > Key: CASSANDRA-15098 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15098 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Normal > > The logical here to remove endpoints no longer owning tokens is not working > for multiple tokens (vnode): > https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/service/StorageService.java#L2505 > And it's very expensive to copy the tokenmetadata for every check. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15098) Endpoints no longer owning tokens are not removed for vnode
[ https://issues.apache.org/jira/browse/CASSANDRA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825447#comment-16825447 ] Jay Zhuang commented on CASSANDRA-15098: Here is an utest to reproduce the problem and a purposed fix, please review: | Branch | uTest | | [15098-3.0|https://github.com/cooldoger/cassandra/tree/15098-3.0] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.0.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.0] | | [15098-3.11|https://github.com/cooldoger/cassandra/tree/15098-3.11] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.11.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.11] | | [15098-trunk|https://github.com/cooldoger/cassandra/tree/15098-trunk] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-trunk.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-trunk] | > Endpoints no longer owning tokens are not removed for vnode > --- > > Key: CASSANDRA-15098 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15098 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Normal > > The logical here to remove endpoints no longer owning tokens is not working > for multiple tokens (vnode): > https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/service/StorageService.java#L2505 > And it's very expensive to copy the tokenmetadata for every check. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
