[jira] [Commented] (CASSANDRA-15112) StorageService.rebuild() throws RuntimeException when interrupted
[
https://issues.apache.org/jira/browse/CASSANDRA-15112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836682#comment-16836682
]
eBugs commented on CASSANDRA-15112:
---
Thanks Jon!
> StorageService.rebuild() throws RuntimeException when interrupted
> -
>
> Key: CASSANDRA-15112
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15112
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX, Tool/nodetool
>Reporter: eBugs
>Priority: Low
> Fix For: 4.x
>
>
> Dear Cassandra developers, we are developing a tool to detect
> exception-related bugs in Java. Our prototype has spotted the following
> {{throw}} statement whose exception class and error message indicate
> different error conditions.
>
> Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e)
> File: CASSANDRA-ROOT/src/java/org/apache/cassandra/service/StorageService.java
> Line: 1313
> {code:java}
> try
> {
> ...
> // wait for result
> resultFuture.get();
> }
> catch (InterruptedException e)
> {
> throw new RuntimeException("Interrupted while waiting on rebuild
> streaming");
> }{code}
>
> {{RuntimeException}} is usually used to represent errors in the program logic
> (think of one of its subclasses, {{NullPointerException}}), while the error
> message indicates that an interrupt has occurred. This mismatch could be a
> problem. For example, the callers may miss the possibility that
> {{StorageService.rebuild()}} can be interrupted because it does not throw any
> {{InterruptedException}}. Or, the callers trying to handle other
> {{RuntimeException}} may accidentally (and incorrectly) handle the interrupt.
>
> If throwing a {{RuntimeException}} is preferred, maybe it can wrap the cause
> exception so that the inner call stack is preserved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15112) StorageService.rebuild() throws RuntimeException when interrupted
[
https://issues.apache.org/jira/browse/CASSANDRA-15112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836663#comment-16836663
]
Jon Meredith commented on CASSANDRA-15112:
--
Similar to CASSANDRA-15112, I agree it would be better to wrap the
InterruptedException in the RuntimeException to retain the context, but cannot
justify risks to changing logging infrastructure in a minor. Set to 4.next.
> StorageService.rebuild() throws RuntimeException when interrupted
> -
>
> Key: CASSANDRA-15112
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15112
> Project: Cassandra
> Issue Type: Bug
>Reporter: eBugs
>Priority: Normal
>
> Dear Cassandra developers, we are developing a tool to detect
> exception-related bugs in Java. Our prototype has spotted the following
> {{throw}} statement whose exception class and error message indicate
> different error conditions.
>
> Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e)
> File: CASSANDRA-ROOT/src/java/org/apache/cassandra/service/StorageService.java
> Line: 1313
> {code:java}
> try
> {
> ...
> // wait for result
> resultFuture.get();
> }
> catch (InterruptedException e)
> {
> throw new RuntimeException("Interrupted while waiting on rebuild
> streaming");
> }{code}
>
> {{RuntimeException}} is usually used to represent errors in the program logic
> (think of one of its subclasses, {{NullPointerException}}), while the error
> message indicates that an interrupt has occurred. This mismatch could be a
> problem. For example, the callers may miss the possibility that
> {{StorageService.rebuild()}} can be interrupted because it does not throw any
> {{InterruptedException}}. Or, the callers trying to handle other
> {{RuntimeException}} may accidentally (and incorrectly) handle the interrupt.
>
> If throwing a {{RuntimeException}} is preferred, maybe it can wrap the cause
> exception so that the inner call stack is preserved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
