[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-14 Thread Sumanth Pasupuleti (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380869#comment-17380869
 ] 

Sumanth Pasupuleti commented on CASSANDRA-16467:


Updated PRs (after rebase)
*3.0.x*
[Patch|https://github.com/apache/cassandra/compare/cassandra-3.0...sumanth-pasupuleti:bugfix/30_speculative_retry_params_case]
UTs and Dtests passing except for three DTests that seem unrelated to me 
(test_sstableverify, test_simple_rebuild and test_closing_connections)
[Circle CI 
run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/79/workflows/b6f2cd11-d08d-46ef-acf8-6fd0ccf0d61e]

3.11.x
[Patch|https://github.com/apache/cassandra/compare/cassandra-3.11...sumanth-pasupuleti:bugfix/311_speculative_retry_params_case]
UTs and Dtests passing except for three DTests that seem unrelated to me 
(test_sstableverify, test_view_metadata_cleanup and test_closing_connections)
[Circle CI 
run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/81/workflows/6c45519e-1120-4fa5-8a72-3e465a5467cb]

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-14 Thread Sumanth Pasupuleti (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380855#comment-17380855
 ] 

Sumanth Pasupuleti commented on CASSANDRA-16467:


Thanks for the review [~azotcsit], [~maedhroz] and [~e.dimitrova]. I have 
rebased; CI runs are in progress - will update the ticket once the runs 
complete.

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-14 Thread Caleb Rackliffe (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380853#comment-17380853
 ] 

Caleb Rackliffe commented on CASSANDRA-16467:
-

bq. do you mind to rebase and submit new CI run?

[~sumanth.pasupuleti] I'll commit as soon as this is done. Thanks again!

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-14 Thread Ekaterina Dimitrova (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380680#comment-17380680
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16467:
-

The change moving from _toUpperCase_ to _toLowerCase_ was done as part of 
b31845c4a7982358a7c5bfd9bcf572fda6c1bfa9 (CASSANDRA-9712). I didn't find any 
reason for it, I suspect it was a mistake. 

About [~azotcsit]'s question around the "99p". I think the reason is that we 
fix here a bug/regression and that part was new in 4.0 ([~maedhroz] and 
[~sumanth.pasupuleti], please, correct me if I am wrong). 3.0 and 3.11 are only 
bug fixes. 

 [~sumanth.pasupuleti], do you mind to rebase and submit new CI run? 

+1 on green CI, thank you!

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-13 Thread Caleb Rackliffe (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380203#comment-17380203
 ] 

Caleb Rackliffe commented on CASSANDRA-16467:
-

+1 to both patches

The only minor nit I have is that in the 3.11 version, where we have Unit 4.12 
available, I would use {{@Parameters(name="\{0\}")}} to make the test names a 
bit more descriptive. (i.e. If they fail, the input would be obvious.)

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-13 Thread Caleb Rackliffe (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380176#comment-17380176
 ] 

Caleb Rackliffe commented on CASSANDRA-16467:
-

[~sumanth.pasupuleti] I'll make a pass at review, and then we would just need 
one more committer +1.

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-07-11 Thread Aleksei Zotov (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378774#comment-17378774
 ] 

Aleksei Zotov commented on CASSANDRA-16467:
---

Just curious - why did you decide to not include "99p"?

The changes look good to me.

PS: 

I'm not a committer, just checking existing patches as per Benjamin's email 
seeking for reviewers.

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break

2021-02-23 Thread Sumanth Pasupuleti (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289304#comment-17289304
 ] 

Sumanth Pasupuleti commented on CASSANDRA-16467:


*3.0.x*
[Patch|https://github.com/apache/cassandra/compare/cassandra-3.0...sumanth-pasupuleti:bugfix/30_speculative_retry_params_case]
[Passing 
UTs|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/53/workflows/3a0b4cdd-32c8-4b8a-83fa-34e6a78679d5]

*3.11.x*
[Patch|https://github.com/apache/cassandra/compare/cassandra-3.11...sumanth-pasupuleti:bugfix/311_speculative_retry_params_case]
[UTs|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/54/workflows/6241a82b-3dde-4599-9c72-7d11e39c7206]
 (one failing that seems unrelated)

> speculative retry should allow more friendly params, allowing upgrade from 
> 2.x not to break
> ---
>
> Key: CASSANDRA-16467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16467
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have 
> added case sensitivity. As as result of this, one of our internal 
> applications suffered an issue during 
> C* upgrade from 2.x to 3.0.
> This ticket is to propose making 3.0 and 3.11 speculative_retry params case 
> insensitive as well (essentially a slightly modified backport of 
> CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org