[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580902#comment-17580902
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
The one ran in a loop indeed has the same name, but it is different class - the
one tested was a unit test, the flaky one is in-jvm.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580401#comment-17580401
]
Andres de la Peña commented on CASSANDRA-17658:
---
It seems that the new {{SchemaTest.schemaReset}} is flaky, see CASSANDRA-17819.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578940#comment-17578940
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
Note that, in the end, I have renamed the incorrect branch from
CASSANDRA-17568-trunk to CASSANDRA-17658-trunk
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569433#comment-17569433
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
Hey [~jlewandowski] , did you try your commit rights? I don't think you will
get any notification or anything, they are just assigned pretty quickly
normally after you are told you are a committer already. Please let us know if
you need any help.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566793#comment-17566793
]
Andres de la Peña commented on CASSANDRA-17658:
---
I think there is some information about the account
[here|https://infra.apache.org/new-committers-guide.html#apache-committer-account-creation].
IIRC you have to upload you public key to
[https://id.apache.org|https://id.apache.org/]. Then you can link the
GitHub/GitBox accounts [here|https://git.apache.org/], so you can push to
GitHub.
As for the commit process itself, there are examples
[here|https://cassandra.apache.org/_/development/how_to_commit.html].
I don't know if you have received the email notifying that the committer
account has been created yet. If not, I can commit this for you in the
meantime, or we can wait a bit until you have the account, as you prefer.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566351#comment-17566351
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
thank you [~adelapena], yes, I need some help, but I think I don't have an
account yet :)
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565866#comment-17565866
]
Andres de la Peña commented on CASSANDRA-17658:
---
All looks good, I think we are ready to commit. [~jlewandowski] I think you
should be able to commit this yourself now that you are powerful committer.
Please let me know if you need any help.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565426#comment-17565426
]
Andres de la Peña commented on CASSANDRA-17658:
---
Looks good to me. Just in case, I have started some additional repeated runs of
{{KeyspaceMetricsTest}} with the most recent changes, and also of the new test
on {{{}SchemaTest{}}}:
||Test||CI||
|{{KeyspaceMetricsTest}}|[4.1|https://app.circleci.com/pipelines/github/adelapena/cassandra/1907/workflows/9106f6a3-08a9-4c86-8a3d-5ca9fd3d1868]
[trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/1908/workflows/3e31fa77-b3e7-42c2-aefd-4f6a86919f6a]|
|{{SchemaTest}}|[4.1|https://app.circleci.com/pipelines/github/adelapena/cassandra/1910/workflows/2ce26187-7143-4c70-a825-1636b78ac63d]
[trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/1909/workflows/b47cb176-62de-40a1-9df5-6e6224080971]|
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565356#comment-17565356
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1716]|[j8|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/239/workflows/b2cdc13f-f077-4741-80f9-b1bfa15b1d80](/),
[j11|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/239/workflows/a91a1f21-1ba8-4a3c-8987-831ad42ea40e](/)|
|[4.1|https://github.com/apache/cassandra/pull/1678]|[j8|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/238/workflows/3ea0df08-d74d-4b74-bb56-ffdfa9daf147](/),
[j11|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/238/workflows/5968ce11-1c64-4997-81c5-7e77327547de](/)|
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565106#comment-17565106
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
Latest changes seem reasonable to me and the CI looks quite green. +1 in case
[~adelapena] does not having anything against those synchronizations of course
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565028#comment-17565028
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
j11
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/238/workflows/5968ce11-1c64-4997-81c5-7e77327547de
(/)
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564927#comment-17564927
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
Thanks, I've applied your suggestions on 4.1 branch and started CI
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/238/workflows/3ea0df08-d74d-4b74-bb56-ffdfa9daf147
Once ok, I'll add changes to trunk branch and run the rest of the tests
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562884#comment-17562884
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
Overall LGTM and CI looks ok, I left a few small questions/comments in the 4.1
PR .
I saw a Jolokia issue again in the J11 runs and I noticed in the logs:
{code:java}
stdout = b"WARNING: An illegal reflective access operation has
occurred\nWARNING: Illegal reflective access by org.jolokia.jvma...rt '8778' is
already occupied.\nPlease check the standard output of the target process for a
detailed error message.\n" stderr = None, retcode = 1 {code}
So that reminded me to check our version of Jolokia for dtests it seems we are
on 1.6 and official support for Java 11 was added in 1.7 so I suspect we need
to update the agent. I will open a separate ticket to tackle this problem, not
related to the current ticket.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561625#comment-17561625
]
Andres de la Peña commented on CASSANDRA-17658:
---
Great, thanks. All the failed tests appear on Butler. Looks good to me, +1.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561486#comment-17561486
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
PR for trunk: https://github.com/apache/cassandra/pull/1716
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561137#comment-17561137
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
Setting to Needs Committer and if no one picks it until Tuesday I will do it,
thanks
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561135#comment-17561135
]
Andres de la Peña commented on CASSANDRA-17658:
---
[~e.dimitrova] I've removed you as reviewer since it was accidental. However
we'll need a second committer-reviewer for this, so it will be great if you
have some time to take a look.
[~jlewandowski] Do you have a patch and CI runs for trunk?
As for [this remaining
nit|https://github.com/apache/cassandra/pull/1678#discussion_r909498110], I can
remove the unneeded annotation on commit.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561120#comment-17561120
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/234/workflows/191b60a4-148d-4158-8885-267ea82210f6
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/234/workflows/15d428fe-7d12-4b42-995d-e395fb3a6fde
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561102#comment-17561102
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
For the record, it seems changing statuses marked me as a reviewer without
being one.
If you need me to review it, I can do it next week, otherwise, please, feel
free to remove me from the list of reviewers.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560925#comment-17560925
]
Andres de la Peña commented on CASSANDRA-17658:
---
I have run CI with the patch squashed, rebased, with [this remaining
nit|https://github.com/apache/cassandra/pull/1678#discussion_r909498110], and
also applied to trunk:
||PR||CI||
|[4.1
|https://github.com/adelapena/cassandra/commit/15370acb4f5c13b648d9862f408365c8768f7a6b]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1754/workflows/164a3773-009f-4f44-a720-43944f32b277]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1754/workflows/bab8309c-3c7d-4a3f-b48f-ea985a5f97bc]|
|[trunk|https://github.com/adelapena/cassandra/commit/7f7bb3ead9da2eec1332dcd25baccdc394aaa3bb]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1753/workflows/7f28cf83-3a39-4857-be94-ed80300fbaca]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1753/workflows/e928312c-f129-4417-9b80-ee746488b26f]|
All looks good. However these runs don't include [this last
nit|https://github.com/apache/cassandra/pull/1678/commits/32aba6148fadb2ca3d053213850c7fea69e51ebf].
[~jlewandowski] do we have full CI results for it?
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558459#comment-17558459
]
Andres de la Peña commented on CASSANDRA-17658:
---
CI hasn't finished yet with all the repeated test iterations, but the rest of
the jobs have already finished and they look good to me.
The failure of {{test_counter_node_down}} in 4.1 is due to the branch missing
the fix for CASSANDRA-17411. The failure should go aways once it's rebased. The
failure doesn't affect trunk because I have applied the proposed patch to a
more recent version of the branch that includes CASSANDRA-17411.
As for the failures of {{test_prefer_local_reconnect_on_listen_address}} on
trunk, it's a well-known bug reported on CASSANDRA-17700.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558454#comment-17558454
]
Andres de la Peña commented on CASSANDRA-17658:
---
No worries :). The fix looks good to me, I have left a couple of suggestions on
the PR. I have applied the patch to trunk without conflicts and I'm running CI:
||Branch||CI||
|[4.1
|https://github.com/apache/cassandra/pull/1678]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1727/workflows/82eb2761-d4cf-4fef-a33a-58327aada12d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1727/workflows/c05e2eea-bff1-4562-bb74-0c14a4da6a0c]|
|[trunk|https://github.com/adelapena/cassandra/tree/17658-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1728/workflows/cd55c0fa-c52c-44ce-9bfa-6460e79f331c]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1728/workflows/4b7e855a-b411-48a1-acfa-b2a87fcae7aa]|
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558010#comment-17558010
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
[~adelapena] my apologize for not being precise. What do you think about the
latest patch version? The problem was that the keyspace got opened during
removal. I think with the provided patch it is not longer possible.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557474#comment-17557474
]
Andres de la Peña commented on CASSANDRA-17658:
---
I wasn't aware of that PR. I have only seen the CI links on the ticket, and
they only point to the last pushed commit.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557420#comment-17557420
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
[~adelapena] I'm not sure what do you mean - there is a PR
https://github.com/apache/cassandra/pull/1678
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557339#comment-17557339
]
Andres de la Peña commented on CASSANDRA-17658:
---
[~jlewandowski]
[this|https://github.com/jacek-lewandowski/cassandra/commits/CASSANDRA-17658]
is the branch containing the patch, isn't it? The CI links only point to a
single commit, it might be useful to create a PR to be linked here.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557321#comment-17557321
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
Unfortunately, there was another problem, rerunning precommit tests:
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/229/workflows/3f710f6d-f67a-410a-814d-7698b5143b42
(?)
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557301#comment-17557301
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
[~adelapena] I think I found the real issue, here is the test results (5000
repetitions):
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/228/workflows/b125e7b6-d9d5-4756-84ed-9d03cb3f7c47/jobs/1533/steps
(/)
I'm running precommit now:
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/228/workflows/41d28ecb-e3b5-49f4-a88b-b6aba84fa11b
(?)
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556592#comment-17556592
]
Ekaterina Dimitrova commented on CASSANDRA-17658:
-
Triaging the 4.1 blockers board, moved to REVIEW IN PROGRESS this one to
reflect it is already under review, I hope you don't mind.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556305#comment-17556305
]
Andres de la Peña commented on CASSANDRA-17658:
---
[This
commit|https://github.com/jacek-lewandowski/cassandra/commit/e936f120b7ee1936bab6f62810a6d75af1bb7874],
applied to
[4.1|https://github.com/apache/cassandra/commit/7f7bfcb1f699214ac7178ae71f13d02ec71a87a3]
and
[trunk|https://github.com/apache/cassandra/commit/ecc4f3c07e1d13216c0708ed705bfc8de0cb6923].
I've got that commit from [the last CI run
above|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/226/workflows/808cc7d1-03a0-4161-b56c-ca3d6477dfaf/jobs/1491],
is that the right one?
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556206#comment-17556206
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
[~adelapena] which commit are you testing?
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555017#comment-17555017
]
Andres de la Peña commented on CASSANDRA-17658:
---
[~jlewandowski] is that the original run with 1000 repetitions? My runs above
have 5000 repetitions, all of them still hit the reported failure.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554950#comment-17554950
]
Jacek Lewandowski commented on CASSANDRA-17658:
---
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/226/workflows/808cc7d1-03a0-4161-b56c-ca3d6477dfaf/jobs/1491
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553632#comment-17553632
]
Andres de la Peña commented on CASSANDRA-17658:
---
[~jlewandowski] it seems that the repeated test runs above keep hitting the
failure.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553522#comment-17553522
]
Andres de la Peña commented on CASSANDRA-17658:
---
[Here|https://github.com/jacek-lewandowski/cassandra/commit/e936f120b7ee1936bab6f62810a6d75af1bb7874]
is the patch provided by [~jlewandowski], with [some repeated runs for 4.1
j8-j8|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/226/workflows/808cc7d1-03a0-4161-b56c-ca3d6477dfaf/jobs/1491].
I've started full CI for 4.1 and trunk:
||PR||CI||
|[4.1
|https://github.com/apache/cassandra/compare/trunk...adelapena:17658-4.1-review]
|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1700/workflows/4dd40b1d-8a89-42d2-b5eb-6df7d1f26820]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1700/workflows/33cb8efd-7883-4111-93ed-b248d163e204]|
|[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:17658-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1699/workflows/b994c61c-50d1-48af-8b86-f814919fabd3]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1699/workflows/d0d4ffc2-29f9-45be-95c4-3d4b6c4cdcd2]|
The method {{Schema#clear()}} is only meant to be called by tests. Perhaps we
should rename it to {{Schema#clearUnsafe()}} to prevent mistakes. This would be
in line with methods such as {{ColumnFamilyStore#clearUnsafe()}},
{{Gossiper#clearUnsafe()}}, {{TokenMetadata#clearUnsafe()}} and
{{Accumulator#clearUnsafe()}}.
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
[jira] [Commented] (CASSANDRA-17658) Test Failures: org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
[
https://issues.apache.org/jira/browse/CASSANDRA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542083#comment-17542083
]
Andres de la Peña commented on CASSANDRA-17658:
---
The test checks that deleting a keyspace also deletes its metrics. I suspect
that this failure is hitting a race introduced by CASSANDRA-17071, maybe around
{{{}Schema#maybeRemoveKeyspaceInstance{}}}. Indeed, the test used to pass right
before that commit
([j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1611/workflows/e2fe5f89-2ec9-4897-8f9a-07f467a874be]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1611/workflows/59e81b6c-4506-400e-8370-77125536c87a])
and it started to be flaky right after that commit
([j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1610/workflows/9ba746fc-574b-4e81-8f9a-0af278b9277d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1610/workflows/2eb057c6-ef97-4682-a32c-d1fa1bc2cb2d]).
CC [~jlewandowski] [~blambov] [~ifesdjeen]
> Test Failures:
> org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop
>
>
> Key: CASSANDRA-17658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17658
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> The test
> {{org.apache.cassandra.metrics.KeyspaceMetricsTest.testMetricsCleanupOnDrop}}
> seems to be flaky on CircleCI, although I haven't seen it failing on Jenkins.
> It was first detected during CASSANDRA-17509, on [this
> run|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977/tests]:
> {code}
> junit.framework.AssertionFailedError:
>
