[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803726#comment-17803726
]
Michael Semb Wever commented on CASSANDRA-18969:
Bringing latest 4.x changes into other branches:
-
https://github.com/apache/cassandra-java-driver/compare/4.12.x...thelastpickle:java-driver:mck/4.12.x/18969
-
https://github.com/apache/cassandra-java-driver/compare/4.11.x...thelastpickle:java-driver:mck/4.11.x/18969
-
https://github.com/apache/cassandra-java-driver/compare/4.8.0_fixes...thelastpickle:java-driver:mck/4.8.0_fixes/18969
-
https://github.com/apache/cassandra-java-driver/compare/4.7.x...thelastpickle:java-driver:mck/4.7.x/18970
-
https://github.com/apache/cassandra-java-driver/compare/4.6.1_fixes...thelastpickle:java-driver:mck/4.6.1_fixes/18970
-
https://github.com/apache/cassandra-java-driver/compare/4.6.x...thelastpickle:java-driver:mck/4.6.x/18970
-
https://github.com/apache/cassandra-java-driver/compare/4.5.0_fixes...thelastpickle:java-driver:mck/4.5.0_fixes/18970
-
https://github.com/apache/cassandra-java-driver/compare/4.5.x...thelastpickle:java-driver:mck/4.5.x/18970
-
https://github.com/apache/cassandra-java-driver/compare/4.x...thelastpickle:java-driver:mck/4.4.0_fixes/18970
– …wip…
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Urgent
> Time Spent: 37h 40m
> Remaining Estimate: 0h
>
> TODO
> * -there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )-
> * -"© DataStax" still appears in the README-
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794457#comment-17794457
]
Michael Semb Wever commented on CASSANDRA-18969:
latest commit
https://github.com/apache/cassandra-java-driver/commit/f11622308d031bf85047c4811e737aeb6ae236e9
will need to be replicated onto all branches…
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 37h 20m
> Remaining Estimate: 0h
>
> TODO
> * -there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )-
> * -"© DataStax" still appears in the README-
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791056#comment-17791056
]
Michael Semb Wever commented on CASSANDRA-18969:
All done.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 36h
> Remaining Estimate: 0h
>
> TODO
> * -there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )-
> * -"© DataStax" still appears in the README-
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787519#comment-17787519
]
Michael Semb Wever commented on CASSANDRA-18969:
The last remaining piece of work is being tackled in this PR
https://github.com/apache/cassandra-java-driver/pull/1864 (it will be
replicated for all branches).
It will separate the NOTICE.txt file into the source and binary distributable
variants.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 26.5h
> Remaining Estimate: 0h
>
> TODO
> * -there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )-
> * -"© DataStax" still appears in the README-
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785375#comment-17785375
]
Henry Hughes commented on CASSANDRA-18969:
--
{quote}are there any releases that bundle dependencies (like shaded jars
published to maven central) ?{quote}
Yes there is
[java-driver-core-shaded|https://central.sonatype.com/artifact/com.datastax.oss/java-driver-core-shaded]
which includes shaded versions of [netty and
jackson|https://github.com/apache/cassandra-java-driver/blob/4.x/core-shaded/pom.xml#L152],
jackson doesn't have a NOTICE file but netty has [a pretty long
one|https://github.com/netty/netty/blob/4.1/NOTICE.txt].
There is also a dependency on
[java-driver-shaded-guava|https://github.com/datastax/java-driver-shaded-guava],
but this was not part of the donation so may be out of scope for this ticket.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785274#comment-17785274
]
Michael Semb Wever commented on CASSANDRA-18969:
bq. A reminder that only things that are included/bundled in a release need to
be mentioned in LICENSE and NOTICE.
Yea, thanks for the reminder.
This java-driver does not bundle any dependencies in the source release, and
[~henry.hughes] are there any releases that bundle dependencies (like shaded
jars published to maven central) ?
bq. So in general, transitive dependencies don't need to be mentioned in
LICENSE or NOTICE.
That's kinda misleading. Transitive dependencies are to be treated no
differently. It is solely whether they are included or not.
See https://infra.apache.org/licensing-howto.html#deps-of-deps
{quote}Dependencies of dependencies (including so-called "transitive
dependencies") are no different from first-order dependencies for the purposes
of assembling LICENSE and NOTICE: LICENSE and NOTICE need only be modified to
accommodate them only if their bits are bundled.{quote}
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785238#comment-17785238
]
Justin Mclean commented on CASSANDRA-18969:
---
Looking at the latest PRs it's hard to know what the intent is here. A reminder
that only things that are included/bundled in a release need to be mentioned in
LICENSE and NOTICE. So in general, transitive dependencies don't need to be
mentioned in LICENSE or NOTICE. You may require different LICENSE and NOTICE
files for a source release and a binary convenience release as the contents of
the release are different. See
https://infra.apache.org/licensing-howto.html#guiding.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785159#comment-17785159
]
Michael Semb Wever commented on CASSANDRA-18969:
This [PR|https://github.com/apache/cassandra-java-driver/pull/1835] and the
replacing the "© DataStax" in the README in each branch, is the remaining work
to be done.
The PR we believe is propagating more NOTICES content than we believe is
necessary, investigating.
The NOTICEs' it is including are
- https://github.com/jakartaee/validation/blob/main/NOTICE.md
- https://github.com/eclipse-ee4j/jersey/blob/2.x/NOTICE.md
- https://github.com/netty/netty/blob/4.1/NOTICE.txt
- https://github.com/apache/tinkerpop/blob/master/NOTICE
- https://github.com/micrometer-metrics/micrometer/blob/main/NOTICE
At first glance it's only netty and jersey that has stuff that we might need to
include…?
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784538#comment-17784538 ] Justin Mclean commented on CASSANDRA-18969: --- Copyrights from license information do not belong in the NOTICE file, LICENSE information (including copyrights) goes into LICENSE. Again please see See https://infra.apache.org/licensing-howto.html. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Client/java-driver >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 10.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783299#comment-17783299 ] Michael Semb Wever commented on CASSANDRA-18969: Committed * https://github.com/apache/cassandra-java-driver/pull/1741 * https://github.com/apache/cassandra-java-driver/pull/1744 * https://github.com/apache/cassandra-java-driver/pull/1745 * https://github.com/apache/cassandra-java-driver/pull/1746 * https://github.com/apache/cassandra-java-driver/pull/1747 * https://github.com/apache/cassandra-java-driver/pull/1748 * https://github.com/apache/cassandra-java-driver/pull/1749 * https://github.com/apache/cassandra-java-driver/pull/1750 * https://github.com/apache/cassandra-java-driver/pull/1751 * https://github.com/apache/cassandra-java-driver/pull/1752 * https://github.com/apache/cassandra-java-driver/pull/1753 * https://github.com/apache/cassandra-java-driver/pull/1754 * https://github.com/apache/cassandra-java-driver/pull/1755 * https://github.com/apache/cassandra-java-driver/pull/1756 > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 5.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783206#comment-17783206 ] Michael Semb Wever commented on CASSANDRA-18969: bq. Since the install-jdk.sh is in the CI code do we list the copyright in the Notice file or not? Yes, as it will be included in the (source) release. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 3.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783196#comment-17783196 ] Claude Warren commented on CASSANDRA-18969: --- New question: ci/install-jdk.sh:# (C) 2018 Christian Stein Since the install-jdk.sh is in the CI code do we list the copyright in the Notice file or not? > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 3.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782592#comment-17782592 ] Michael Semb Wever commented on CASSANDRA-18969: CpuInfo is found here in 4.x (the default) branch: https://github.com/apache/cassandra-java-driver/blob/4.x/core/src/main/java/com/datastax/oss/driver/internal/core/os/CpuInfo.java#L34 > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 3h 20m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782553#comment-17782553 ] Claude Warren commented on CASSANDRA-18969: --- Question 4.1.0_fixes NOTICE file lists a Wayne Meissner copyright -- but there is no code in the codebase that has his copyright in it. The text in the Notice file reads JNR project Copyright (C) 2008-2010 Wayne Meissner This product includes software developed as part of the JNR project ([https://github.com/jnr/jnr-ffi] ). see core/src/main/java/com/datastax/oss/driver/internal/core/os/CpuInfo.java The CpuInfo.java file does not exist in the project. However there is adependency on the jrn-ffi jars. Should the Wayne Messiner entry be removed from the NOTICE? I think so. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 3h 10m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782408#comment-17782408 ] Justin Mclean commented on CASSANDRA-18969: --- Thanks, Henry, for answering my question (originally asked on the incubator general list) that these are indeed optional. Regarding dependencies, A Category X build dependency may output content that is under a license not compatible with the Apache license or if it's under a "community license", even if the license seems compatible, it may impose further restrictions that are not compatible with the Apache license e.g non-commercial use, so it always best to double-check. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 2h 40m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782302#comment-17782302 ] Henry Hughes commented on CASSANDRA-18969: -- https://github.com/apache/cassandra-java-driver/pull/1741 is ready for review. This change moves spotbugs (and similar JCIP-annotaitons) to the provided scope. It includes tests that verify these jars, and a few others such as graal-sdk (also provided) and TinkerPop (optional) etc, are not pulled in when depending on java-driver's published jars. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 20m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782181#comment-17782181 ] Henry Hughes commented on CASSANDRA-18969: -- Despite being in `provided` scope, both `graal-sdk` and `spotbugs` do not need to be provided by developers at compile-time or runtime in order for java-driver to function correctly. I have a [change|[https://github.com/apache/cassandra-java-driver/pull/1741]] in progress to move `spotbugs` to `provided` scope and an working on adding a test to assert we're not including either of these deps when projects depend on java-driver. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 20m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782176#comment-17782176 ] Michael Semb Wever commented on CASSANDRA-18969: "For example, using a GPL'ed tool during the build is okay, but including GPL'ed source code is not." > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 20m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782175#comment-17782175 ] Justin Mclean commented on CASSANDRA-18969: --- The NOTICE file contains: JNR project - Copyright (C) 2008-2010 Wayne Meissner Protocol Buffers - Copyright 2008 Google Inc. Guava - Copyright (C) 2007 The Guava Authors The file I mentioned above contains: (C) 2018 Christian Stein Can you please please show where ASF policy says it's OK for Category X to be in the provided scope? While ASF policy does make some exceptions for some well-known build tools, I don't think that applies here See https://www.apache.org/legal/resolved.html#build-tools So I fail to see how this is "Bullshit" as you put it. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 20m > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (alleged…?) > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * add copyright to a few missing files (e.g. ci/install-jdk.sh ), use rat > plugin to ensure all > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782054#comment-17782054 ] Michael Semb Wever commented on CASSANDRA-18969: Calling bullshit, please do your homework first Justin, you're now just wasting everyone's time here. The copyright is in the NOTICE file. And this is clear as it's intentionally the last commit before the donation. Provided scope, for the sake of build tools, while the distribution binary otherwise runs without it, is explicitly documented as ok for cat X. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Normal > > TODO > * there is still code copyrighted to others that isn't mentioned in NOTICE.txt > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > * add copyright to a few missing files (e.g. ci/install-jdk.sh ), use rat > plugin to ensure all > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781927#comment-17781927 ] Justin Mclean commented on CASSANDRA-18969: --- I discovered several files by running Apache Rat over the 4.x branch. The most obvious being ./ci/install-jdk.sh as it has no ASF header, copyright not mentioned in license/notice and GitHub url from where the code comes from. I can't recall the others off the top of my head, I suggest you use Apache Rat to find out. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Normal > > TODO > * there is still code copyrighted to others that isn't mentioned in NOTICE.txt > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope > * add any BSD/MIT deps to LICENCE > These things must be done before a release. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781143#comment-17781143 ] Henry Hughes commented on CASSANDRA-18969: -- Current 4.x branch depends on `com.github.spotbugs:spotbugs-annotations:3.1.12` which is [LGPLv2.1|[https://github.com/spotbugs/spotbugs/blob/master/LICENSE]] since version `3.1.0_RC6`. I think that's going to need to be removed before the next release is cut. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Normal > > * there is still code copyrighted to others that isn't mentioned in NOTICE.txt > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781136#comment-17781136 ] Michael Semb Wever commented on CASSANDRA-18969: The graalvm dep, which is GPL, was mentioned on general@incubator.a.o It is only in 4.x and already marked as provided scope. > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Normal > > * there is still code copyrighted to others that isn't mentioned in NOTICE.txt > * "© DataStax" still appears in the README > * spotbugs is LGPL, in 4.x, and not correctly made provided scope. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
