[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827380#comment-17827380 ] n.v.harikrishna commented on CASSANDRA-19393: - Thanks [~smiklosovic] ! And apologies for the slow trun around. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.1 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827262#comment-17827262 ] Stefan Miklosovic commented on CASSANDRA-19393: --- These two tests are the only ones dealing with cms: storage_engine_upgrade_test upgrade_through_versions_test repeated dtest for the first one is here https://app.circleci.com/pipelines/github/instaclustr/cassandra/4009/workflows/2b9fd421-82bc-47a8-9d82-7c76c1a22bc8/jobs/204887 I also run the the job for the second one but after 5h it timeouted, probably circle thing / flakiness. I do not have any reason to think that my changed introduced the timeouts. It is literally just "initializecms -> cms initialize" dtest branch tested: https://github.com/smiklosovic/cassandra-dtest/commit/505e78ce3d5f1bcc596b29ffdb8a4e10de2b3a33 I am going to ship this. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825985#comment-17825985 ] Stefan Miklosovic commented on CASSANDRA-19393: --- good catch! yeah, I haven't run upgrades ... I dont have CI plan for that. I need to check if we can run this thing in Jenkins ... > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825983#comment-17825983 ] n.v.harikrishna commented on CASSANDRA-19393: - There are couple of places where "initializecms" is used in python dtests. [https://github.com/search?q=repo%3Aapache%2Fcassandra-dtest%20initializecms=code] . Making changes there as well and checking other commands. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825982#comment-17825982 ] Stefan Miklosovic commented on CASSANDRA-19393: --- trunks's CI is a little bit wild but nothing out of ordinary, harry and fuzz failing as usually, couple flakes in between > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825979#comment-17825979 ] Stefan Miklosovic commented on CASSANDRA-19393: --- [CASSANDRA-19393-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19393-trunk] {noformat} java17_pre-commit_tests ✓ j17_build4m 23s ✓ j17_cqlsh_dtests_py311 6m 42s ✓ j17_cqlsh_dtests_py311_vnode 7m 4s ✓ j17_cqlsh_dtests_py386m 44s ✓ j17_cqlsh_dtests_py38_vnode 7m 25s ✓ j17_cqlshlib_cython_tests9m 17s ✓ j17_cqlshlib_tests 6m 34s ✓ j17_dtests 34m 7s ✓ j17_dtests_vnode34m 16s ✓ j17_jvm_dtests_latest_vnode_repeat 0m 12s ✓ j17_unit_tests 13m 11s ✓ j17_utests_latest 14m 29s ✓ j17_utests_latest_repeat 0m 30s ✓ j17_utests_oa14m 3s ✕ j17_dtests_latest35m 8s offline_tools_test.TestOfflineTools test_sstablelevelreset offline_tools_test.TestOfflineTools test_sstableofflinerelevel ✕ j17_dtests_latest_repeat 0m 25s ✕ j17_jvm_dtests 26m 10s org.apache.cassandra.fuzz.ring.ConsistentBootstrapTest coordinatorIsBehindTest org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN TIMEOUTED ✕ j17_jvm_dtests_latest_vnode 22m 46s junit.framework.TestSuite org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest TIMEOUTED java17_separate_tests java11_pre-commit_tests ✓ j11_build9m 21s ✓ j11_cqlsh_dtests_py311 8m 31s ✓ j11_cqlsh_dtests_py311_vnode 8m 52s ✓ j11_cqlsh_dtests_py38 10m 45s ✓ j11_cqlsh_dtests_py38_vnode 7m 58s ✓ j11_cqlshlib_cython_tests 10m 41s ✓ j11_cqlshlib_tests 10m 16s ✓ j11_dtests 43m 20s ✓ j11_dtests_latest_repeat 4m 6s ✓ j11_dtests_vnode41m 39s ✓ j11_jvm_dtests_latest_vnode 22m 25s ✓ j11_jvm_dtests_latest_vnode_repeat 0m 41s ✓ j11_unit_tests 18m 24s ✓ j11_utests_latest14m 1s ✓ j11_utests_latest_repeat 4m 17s ✓ j11_utests_oa17m 3s ✓ j11_utests_system_keyspace_directory17m 46s ✓ j17_cqlsh_dtests_py311 6m 59s ✓ j17_cqlsh_dtests_py311_vnode 7m 13s ✓ j17_cqlsh_dtests_py38 7m 7s ✓ j17_cqlsh_dtests_py38_vnode 7m 39s ✓ j17_cqlshlib_cython_tests7m 42s ✓ j17_cqlshlib_tests 6m 44s ✓ j17_dtests 35m 49s ✓ j17_dtests_latest_repeat 0m 30s ✓ j17_dtests_vnode35m 17s ✓ j17_jvm_dtests_latest_vnode_repeat 2m 27s ✓ j17_unit_tests 14m 21s ✓ j17_utests_latest 14m 24s ✓ j17_utests_latest_repeat 0m 20s ✓ j17_utests_oa 13m 25s ✕ j11_dtests_latest 42m 26s bootstrap_test.TestBootstrap test_bootstrap_with_reset_bootstrap_state client_request_metrics_local_remote_test.TestClientRequestMetricsLocalRemote test_batch_and_slice offline_tools_test.TestOfflineTools test_sstablelevelreset offline_tools_test.TestOfflineTools test_sstableofflinerelevel ✕ j11_jvm_dtests 26m 6s org.apache.cassandra.fuzz.ring.ConsistentBootstrapTest coordinatorIsBehindTest ✕ j11_simulator_dtests 3m 49s org.apache.cassandra.simulator.test.HarrySimulatorTest test ✕ j17_dtests_latest34m 8s bootstrap_test.TestBootstrap test_bootstrap_with_reset_bootstrap_state offline_tools_test.TestOfflineTools test_sstablelevelreset offline_tools_test.TestOfflineTools test_sstableofflinerelevel streaming_test.TestStreaming test_zerocopy_streaming_no_replication ✕ j17_jvm_dtests 27m 0s
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825221#comment-17825221 ] Marcus Eriksson commented on CASSANDRA-19393: - +1 > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822519#comment-17822519 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I dont think this will be reviewed anytime soon. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818773#comment-17818773 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I took a look at this more closely and critically and I think that this set of changes should be introduced https://github.com/smiklosovic/cassandra/commit/639a18c4712b70beca81bafa280c4ebac0c3c2a8 I think we should copy the case of repair_admin, I put the comments into the PR and I did the work so we may speed things up a little bit if another committer evaluates that it makes sense as well ... cc [~marcuse] > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818383#comment-17818383 ] Stefan Miklosovic commented on CASSANDRA-19393: --- [~n.v.harikrishna] thank you, all looks good to me, [~brandon.williams] [~marcuse] I am waiting for a +1 here. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818134#comment-17818134 ] n.v.harikrishna commented on CASSANDRA-19393: - [~smiklosovic] pushed the changes. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818065#comment-17818065 ] n.v.harikrishna commented on CASSANDRA-19393: - Thanks for the review. Sure, will add the commit and update documentation. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818061#comment-17818061 ] Stefan Miklosovic commented on CASSANDRA-19393: --- [~n.v.harikrishna] could you please incorporate my suggestion https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee and go through the documentation and replace all occurrences of the individual commands by their new counter parts? > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818020#comment-17818020 ] Stefan Miklosovic commented on CASSANDRA-19393: --- [CASSANDRA-19393-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19393-trunk] {noformat} java17_pre-commit_tests ✓ j17_build4m 25s ✓ j17_cqlsh_dtests_py311 6m 47s ✓ j17_cqlsh_dtests_py311_vnode 7m 27s ✓ j17_cqlsh_dtests_py386m 51s ✓ j17_cqlsh_dtests_py38_vnode 7m 36s ✓ j17_cqlshlib_cython_tests 8m 5s ✓ j17_cqlshlib_tests 8m 14s ✓ j17_dtests 36m 18s ✓ j17_dtests_vnode34m 20s ✓ j17_jvm_dtests_repeat0m 15s ✓ j17_jvm_dtests_vnode_repeat 0m 16s ✕ j17_jvm_dtests 25m 29s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest unencryptedNativeConnectionNotlisteningOnTlsPortTest org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest optionalTlsConnectionAllowedToRegularPortTest org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN ✕ j17_jvm_dtests_vnode20m 51s junit.framework.TestSuite org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest TIMEOUTED org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest optionalTlsConnectionAllowedToRegularPortTest ✕ j17_unit_tests 14m 49s org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest ✕ j17_utests_oa 13m 47s org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest java17_separate_tests java11_pre-commit_tests java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3885/workflows/020458e0-fc10-4765-bf5a-900ba189db43] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3885/workflows/8925f011-d0c6-4266-8dfe-fc0dcc9d5e4b] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3885/workflows/7b483fec-bfc0-4a0d-a8f5-2323b75e82a0] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3885/workflows/af6219bb-abf0-41da-86c7-87f9e2193386] > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817961#comment-17817961 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I propose these minor fixes (1) otherwise all good. Can be done on commit. I need another committer. (1) https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817363#comment-17817363 ] n.v.harikrishna commented on CASSANDRA-19393: - Thanks you all for the inputs! I will update the PR as per the discussion. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817360#comment-17817360 ] Brandon Williams commented on CASSANDRA-19393: -- bq. While it does make sense to group this, there is some kind of a habit in nodetool that each command is standalone. I agree with Marcus, we have repair_admin already and I think going to git-style subcommands is the inevitable evolution as the number of commands we have grows. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org