[jira] [Commented] (CASSANDRA-19561) finish_release.sh does not handle jfrog errors
[ https://issues.apache.org/jira/browse/CASSANDRA-19561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837886#comment-17837886 ] Brandon Williams commented on CASSANDRA-19561: -- I don't really want to pull in jq just to use a non-standard error mechanism, but even so with the execution passed through the 'execute()' function, we can't pass the output to it or even grep. Even if we could, if the script aborts at that you still can't rerun it to try again and finish things without some hackery. > finish_release.sh does not handle jfrog errors > -- > > Key: CASSANDRA-19561 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19561 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Priority: Normal > > If there is any "soft" problem (not network) uploading to jfrog, > finish_release.sh will keep on going and then delete the packages regardless > of whether they could be uploaded or not. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19561) finish_release.sh does not handle jfrog errors
[
https://issues.apache.org/jira/browse/CASSANDRA-19561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837751#comment-17837751
]
Brandon Williams commented on CASSANDRA-19561:
--
The root cause seems to be that jfrog returns its errors in json instead of
http return codes, so curl will always exit with zero:
{noformat}
drift@phoenix:/tmp$ curl -X PUT -T foo -ubad:password
https://apache.jfrog.io/artifactory/cassandra/whatever?override=1
{
"errors" : [ {
"status" : 401,
"message" : "Bad credentials"
} ]
}drift@phoenix:/tmp$ echo $?
0
{noformat}
> finish_release.sh does not handle jfrog errors
> --
>
> Key: CASSANDRA-19561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19561
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Brandon Williams
>Priority: Normal
>
> If there is any problem uploading to jfrog, finish_release.sh will keep on
> going and then delete the packages regardless of whether they could be
> uploaded or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
