[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119712#comment-13119712 ] Hudson commented on CASSANDRA-3198: --- Integrated in Cassandra-0.8 #358 (See [https://builds.apache.org/job/Cassandra-0.8/358/]) set ownership on new installs Patch by Sylvain Lebresne; reviewed by eevans for CASSANDRA-3198 eevans : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1178592 Files : * /cassandra/branches/cassandra-0.8/debian/cassandra.postinst debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.7 Attachments: 3198.patch, debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116564#comment-13116564 ] Shyamal Prasad commented on CASSANDRA-3198: --- Any chance this can be fixed for the upcoming 1.0.0 release? debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.7 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116834#comment-13116834 ] Shyamal Prasad commented on CASSANDRA-3198: --- Agree completely, Thanks! debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.7 Attachments: 3198.patch, debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105262#comment-13105262 ] Sylvain Lebresne commented on CASSANDRA-3198: - bq. we didn't always create the cassandra user and chown in postinst Yes, and to make it clear what my point is: while we do create the cassandra user since 0.6.4-2, we *never* chown in the postinst _excepted_ for people that upgraded *all the way* since a pre 0.6.4 release. That is, any current new installation (say of 0.8.5) *does not* chown in the postint and /var/lib/cassandra and /var/log/cassandra (the directories) are owned by root, not cassandra. Now I'm perfectly fine saying that there is no point in changing things during upgrades and to only fix the chown in the postinst for new installs, but just wanted to make it clear that this has nothing to do with upgrades from some 0.6.x versions. debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104501#comment-13104501 ] Sylvain Lebresne commented on CASSANDRA-3198: - That second patch looks good, but maybe we should change that 0.6.4-2 to 0.8.6. Eric, since you initially added that test, an opinion ? debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104583#comment-13104583 ] Eric Evans commented on CASSANDRA-3198: --- The comparison to 0.6.4-2 can be safely removed now, so it should look something like: {noformat} if [ -z $2 ]; then chown -R cassandra: /var/lib/cassandra chown -R cassandra: /var/log/cassandra fi {noformat} debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104604#comment-13104604 ] Sylvain Lebresne commented on CASSANDRA-3198: - bq. The comparison to 0.6.4-2 can be safely removed now Hum, the goal of this ticket is that anyone that have started using the deb package after 0.6.4-2 have /var/{lib,log}/cassandra owned by root.root, which was not intended. So we can decide that we want to leave all those people with those wrong permissions, but it's not safer to remove the comparison now that it was when the patch was initially committed. debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104787#comment-13104787 ] Eric Evans commented on CASSANDRA-3198: --- {quote} Hum, the goal of this ticket is that anyone that have started using the deb package after 0.6.4-2 have /var/{lib,log}/cassandra owned by root.root, which was not intended. So we can decide that we want to leave all those people with those wrong permissions, but it's not safer to remove the comparison now that it was when the patch was initially committed. {quote} I think that statement was always bugged. What it _should_ do is to ensure that /var/{lib,log}/cassandra are owned by user cassandra on new installs only, not upgrades (allowing the user to override that ownership). At this point, I'm not sure what the comparison to 0.6.4-2 was supposed to accomplish, I assume it was a (misguided )attempt at applying this policy to versions greater than or equal to 0.6.4-2 (we didn't always create the cassandra user and chown in postinst). Either way, the current packaging will never be used to upgrade from an 0.6.x release directly, so there is no danger in removing it. So, looking at that (untested )snippet again: {noformat} if [ -z $2 ]; then chown -R cassandra: /var/lib/cassandra chown -R cassandra: /var/log/cassandra fi {noformat} would only apply ownership changes if argument #2 is empty, that is to say, there is no previously configured version (i.e. not an upgrade). debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104791#comment-13104791 ] Jérémy Sevellec commented on CASSANDRA-3198: I agree with that too debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time
[ https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105042#comment-13105042 ] Shyamal Prasad commented on CASSANDRA-3198: --- BTW, I tested the snippet in Eric's comment with the additional pre-0.6.4-2 check (my patch) pretty extensively: install, upgrade to package with new version, remove and reinstall etc. It certainly looks right, and I am sure it works because I tried it, several ways. I did not test the upgrade from 0.6.4-2 since I did not completely understand why it was important, but I left it in once I traced it down to CASSANDRA-1004. As I suspected there's people out there that know better :-) (BTW, in testing I found one minor irritation that /var/log/cassandra/output.log gets created owned by root after installation. I suspect this is because it is created before jsvc switches the user to after allowing privileged operations to complete...once I'm sure the problem is real I'll file it separatelybut it was a good test case for the patch!) debian packaging installation problem when installing for the first time Key: CASSANDRA-3198 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.5 Reporter: Jérémy Sevellec Assignee: Jérémy Sevellec Fix For: 0.8.6 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch when installing cassandra through the debian packaging for the first time, there is permission problem when starting Cassandra. Normally, the postinst script change owner of /var/log/cassandra and /var/lib/cassandra from root to cassandra user. there is a problem with the test which verify if threre is a need to change the owner of these directory or not. On a new install, the $2 parameter is not set and the the test is false and the owner is not changed. (simply, i think replace with || might work) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira