[jira] [Commented] (CASSANDRA-4322) Error in CLI when updating keyspace
[
https://issues.apache.org/jira/browse/CASSANDRA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452668#comment-13452668
]
Dave Brosius commented on CASSANDRA-4322:
-
+1 patch LGTM
Error in CLI when updating keyspace
---
Key: CASSANDRA-4322
URL: https://issues.apache.org/jira/browse/CASSANDRA-4322
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.1
Reporter: Richard Low
Assignee: Pavel Yaskevich
Priority: Minor
Fix For: 1.1.6
Attachments: auth_for_mod_ks.txt, CASSANDRA-4322.patch
To repro:
1. Open the cli
2. Create a keyspace:
create keyspace ks1 with placement_strategy = SimpleStrategy and
strategy_options = {replication_factor:1};
3. Update the keyspace:
update keyspace ks1 with strategy_options = {replication_factor:3};
The output is:
[default@unknown] create keyspace ks1 with placement_strategy =
SimpleStrategy and strategy_options = {replication_factor:1};
8ecd5e16-e0f7-37e7-850e-38ee1a3a510e
Waiting for schema agreement...
... schemas agree across the cluster
[default@unknown] update keyspace ks1 with strategy_options =
{replication_factor:3};
857af387-6677-3e39-bdf6-e1132673c25b
Waiting for schema agreement...
... schemas agree across the cluster
org.apache.thrift.protocol.TProtocolException: Required field 'keyspace' was
not present! Struct: describe_keyspace_args(keyspace:null)
[default@unknown]
The problem is that the patch in CASSANDRA-4052 assumes the CLI is
authenticated to a working keyspace. getKSMetaData in executeUpdateKeySpace
is called with keySpace, which is null.
Changing this to keyspaceName partially solves it, we now get:
[default@unknown] update keyspace ks1 with strategy_options =
{replication_factor:3};
Not authenticated to a working keyspace.
18d750fc-19d9-30f0-b8b9-18b2e4a0a0d4
Waiting for schema agreement...
... schemas agree across the cluster
Not authenticated to a working keyspace.
This comes from replayAssumptions in getKSMetaData.
It seems that the refresh code needs to be reworked slightly to not assume
the CLI is authenticated to a keyspace.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4322) Error in CLI when updating keyspace
[
https://issues.apache.org/jira/browse/CASSANDRA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292703#comment-13292703
]
Richard Low commented on CASSANDRA-4322:
This patch breaks backwards compatibility, so now operations that used to not
require setting a keyspace do. Do we aim to keep the cassandra-cli interface
compatible within the same x.x release?
Error in CLI when updating keyspace
---
Key: CASSANDRA-4322
URL: https://issues.apache.org/jira/browse/CASSANDRA-4322
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.1
Reporter: Richard Low
Assignee: Dave Brosius
Priority: Minor
Attachments: auth_for_mod_ks.txt
To repro:
1. Open the cli
2. Create a keyspace:
create keyspace ks1 with placement_strategy = SimpleStrategy and
strategy_options = {replication_factor:1};
3. Update the keyspace:
update keyspace ks1 with strategy_options = {replication_factor:3};
The output is:
[default@unknown] create keyspace ks1 with placement_strategy =
SimpleStrategy and strategy_options = {replication_factor:1};
8ecd5e16-e0f7-37e7-850e-38ee1a3a510e
Waiting for schema agreement...
... schemas agree across the cluster
[default@unknown] update keyspace ks1 with strategy_options =
{replication_factor:3};
857af387-6677-3e39-bdf6-e1132673c25b
Waiting for schema agreement...
... schemas agree across the cluster
org.apache.thrift.protocol.TProtocolException: Required field 'keyspace' was
not present! Struct: describe_keyspace_args(keyspace:null)
[default@unknown]
The problem is that the patch in CASSANDRA-4052 assumes the CLI is
authenticated to a working keyspace. getKSMetaData in executeUpdateKeySpace
is called with keySpace, which is null.
Changing this to keyspaceName partially solves it, we now get:
[default@unknown] update keyspace ks1 with strategy_options =
{replication_factor:3};
Not authenticated to a working keyspace.
18d750fc-19d9-30f0-b8b9-18b2e4a0a0d4
Waiting for schema agreement...
... schemas agree across the cluster
Not authenticated to a working keyspace.
This comes from replayAssumptions in getKSMetaData.
It seems that the refresh code needs to be reworked slightly to not assume
the CLI is authenticated to a keyspace.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
