[jira] [Commented] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
[ https://issues.apache.org/jira/browse/CASSANDRA-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935309#comment-13935309 ] Nick Bailey commented on CASSANDRA-6418: This doesn't handle the entire keyspace no longer existing. Due to calling 'getValidKeyspace' in storage service. auto_snapshots are not removable via 'nodetool clearsnapshot' - Key: CASSANDRA-6418 URL: https://issues.apache.org/jira/browse/CASSANDRA-6418 Project: Cassandra Issue Type: Bug Components: Tools Environment: auto_snapshot: true Reporter: J. Ryan Earl Assignee: Lyuben Todorov Priority: Minor Fix For: 2.0.5 Attachments: 6418_cassandra-2.0.patch, 6418_cassandra-2.0_v5.patch, 6418_v2.patch, 6418_v3_cassandra-2.0.patch, CASSANDRA-2.0-6418_v4.patch Snapshots of deleted CFs created via the auto_snapshot configuration parameter appear to not be tracked. The result is that 'nodetool clearsnapshot keyspace with deleted CFs' does nothing, and short of manually removing the files from the filesystem, deleted CFs remain indefinitely taking up space. I'm not sure if this is intended, but it seems pretty counter-intuitive. I haven't found any documentation that indicates auto_snapshots would be ignored by 'nodetool clearsnapshot'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
[ https://issues.apache.org/jira/browse/CASSANDRA-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13854759#comment-13854759 ] Mikhail Stepura commented on CASSANDRA-6418: +1 auto_snapshots are not removable via 'nodetool clearsnapshot' - Key: CASSANDRA-6418 URL: https://issues.apache.org/jira/browse/CASSANDRA-6418 Project: Cassandra Issue Type: Bug Components: Tools Environment: auto_snapshot: true Reporter: J. Ryan Earl Assignee: Lyuben Todorov Priority: Minor Fix For: 2.0.5 Attachments: 6418_cassandra-2.0.patch, 6418_cassandra-2.0_v5.patch, 6418_v2.patch, 6418_v3_cassandra-2.0.patch, CASSANDRA-2.0-6418_v4.patch Snapshots of deleted CFs created via the auto_snapshot configuration parameter appear to not be tracked. The result is that 'nodetool clearsnapshot keyspace with deleted CFs' does nothing, and short of manually removing the files from the filesystem, deleted CFs remain indefinitely taking up space. I'm not sure if this is intended, but it seems pretty counter-intuitive. I haven't found any documentation that indicates auto_snapshots would be ignored by 'nodetool clearsnapshot'. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
[
https://issues.apache.org/jira/browse/CASSANDRA-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841036#comment-13841036
]
Mikhail Stepura commented on CASSANDRA-6418:
* {{getCFDirectory}} assumes that CF resides in a single location. If I'm
correct, a CF can be in multiple dirs from
{{DatabaseDescriptor.getAllDataFileLocations()}}
* I suspect {{File.listFiles()}} can return NULL if a directory doesn't exist
Minor remarks
* {{cfDir.exists() cfDir.isDirectory()}} can be reduced to just
{{cfDir.isDirectory()}}
* You can use {{dataFileLocations}} instead of
{{DatabaseDescriptor.getAllDataFileLocations()}}
auto_snapshots are not removable via 'nodetool clearsnapshot'
-
Key: CASSANDRA-6418
URL: https://issues.apache.org/jira/browse/CASSANDRA-6418
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: auto_snapshot: true
Reporter: J. Ryan Earl
Assignee: Lyuben Todorov
Priority: Minor
Fix For: 2.0.4
Attachments: 6418_cassandra-2.0.patch, 6418_v2.patch
Snapshots of deleted CFs created via the auto_snapshot configuration
parameter appear to not be tracked. The result is that 'nodetool
clearsnapshot keyspace with deleted CFs' does nothing, and short of
manually removing the files from the filesystem, deleted CFs remain
indefinitely taking up space.
I'm not sure if this is intended, but it seems pretty counter-intuitive. I
haven't found any documentation that indicates auto_snapshots would be
ignored by 'nodetool clearsnapshot'.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
[
https://issues.apache.org/jira/browse/CASSANDRA-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839830#comment-13839830
]
Mikhail Stepura commented on CASSANDRA-6418:
{code}[javac]
C:\Users\mishail\workspace\cassandra\src\java\org\apache\cassandra\db\compaction\CompactionManager.java:810:
error: cannot find symbol
[javac] cfs.clearSnapshot(snapshotName);
[javac]^
[javac] symbol: method clearSnapshot(String)
[javac] location: variable cfs of type ColumnFamilyStore
{code}
For *getAllKSDirectories*
* {{ListFile snapshotDirs = new ArrayList();}} .It's a raw data type. You
probably meant either {{newArrayList()}} or {{new ArrayList()}}
* {{new File(dataDirectory + / + ksName)}} and {{File(dataDirectory + / +
ksName + / + cfDir)}} - you should use
{{org.apache.cassandra.db.Directories.join(String...)}} instead that
concatenation.
* I think it would be better to use one of {{File.listFiles}} methods instead
of {{File.list()}}
auto_snapshots are not removable via 'nodetool clearsnapshot'
-
Key: CASSANDRA-6418
URL: https://issues.apache.org/jira/browse/CASSANDRA-6418
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: auto_snapshot: true
Reporter: J. Ryan Earl
Assignee: Lyuben Todorov
Priority: Minor
Fix For: 2.0.4
Attachments: 6418_cassandra-2.0.patch
Snapshots of deleted CFs created via the auto_snapshot configuration
parameter appear to not be tracked. The result is that 'nodetool
clearsnapshot keyspace with deleted CFs' does nothing, and short of
manually removing the files from the filesystem, deleted CFs remain
indefinitely taking up space.
I'm not sure if this is intended, but it seems pretty counter-intuitive. I
haven't found any documentation that indicates auto_snapshots would be
ignored by 'nodetool clearsnapshot'.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
