[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126399#comment-14126399 ] Benedict commented on CASSANDRA-7736: - LGTM +1 > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.1 > > Attachments: 7736.txt > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094098#comment-14094098 ] T Jake Luciani commented on CASSANDRA-7736: --- Yup. That's fine by me and was the intent at the time of CASSANDRA-6755 > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.1 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094093#comment-14094093 ] Jonathan Ellis commented on CASSANDRA-7736: --- Jake means the @inline stuff wasn't committed to 2.1.0 in the first place. > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.1 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093737#comment-14093737 ] Jeremiah Jordan commented on CASSANDRA-7736: Was something committed for this already? I did't see a patch go in. I think [~jbellis] just changed the Fix Version because this isn't going to go in 2.1.0? > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.1 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093589#comment-14093589 ] T Jake Luciani commented on CASSANDRA-7736: --- Noticed this was only committed in 2.1 branch not 2.1.0 > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.1 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092484#comment-14092484 ] Benedict commented on CASSANDRA-7736: - Thanks. In general inlining is unlikely to ever have a material difference if it impacts only a handful of calls for each database operation. We should restrict its use to methods invoked disproportionately often and, especially, in tight loops, where we know the instruction cache pollution will pay off (ie where the heuristics fall down). > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.0 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
[ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092300#comment-14092300 ] T Jake Luciani commented on CASSANDRA-7736: --- My approach was turn on hotspot logging, run stress, then grepped for: "hot method too big", repeat. The performance gains seemed to increase with each one but I'll try to only keep the ones that made a material difference. > Clean-up, justify (and reduce) each use of @Inline > -- > > Key: CASSANDRA-7736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7736 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: T Jake Luciani >Priority: Minor > Fix For: 2.1.0 > > > \@Inline is a delicate tool, and should in all cases we've used it (and use > it in future) be accompanied by a comment justifying its use in the given > context both theoretically and, preferably, with some brief description > of/link to steps taken to demonstrate its benefit. We should aim to not use > it unless we are very confident we can do better than the normal behaviour, > as poor use can result in a polluted instruction cache, which can yield > better results in tight benchmarks, but worse results in general use. > It looks to me that we have too many uses already. I'll look over each one as > well, and we can compare notes. If there's disagreement on any use, we can > discuss, and if still there is any dissent should always err in favour of > *not* using \@Inline. -- This message was sent by Atlassian JIRA (v6.2#6252)
