[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140749#comment-15140749
]
Aleksey Yeschenko commented on CASSANDRA-8180:
--
Committed as
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140087#comment-15140087
]
Stefania commented on CASSANDRA-8180:
-
CI looks good, this is ready to commit.
> Optimize disk
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138226#comment-15138226
]
Stefania commented on CASSANDRA-8180:
-
Thanks for the review Branimir!
The patch for trunk is
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136987#comment-15136987
]
Branimir Lambov commented on CASSANDRA-8180:
Changes look good and patch looks good.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125613#comment-15125613
]
Stefania commented on CASSANDRA-8180:
-
Thank you for your comments, refer to [this
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123535#comment-15123535
]
Benedict commented on CASSANDRA-8180:
-
One other nit: for debugging it's much clearer if we create
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123275#comment-15123275
]
Branimir Lambov commented on CASSANDRA-8180:
LGTM.
Nits (feel free to ignore):
You can
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121128#comment-15121128
]
Stefania commented on CASSANDRA-8180:
-
Latest commit available
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118892#comment-15118892
]
Stefania commented on CASSANDRA-8180:
-
The latest commit is ready for review
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119159#comment-15119159
]
Branimir Lambov commented on CASSANDRA-8180:
Thank you, this now looks almost ready to go.
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117151#comment-15117151
]
Branimir Lambov commented on CASSANDRA-8180:
bq. Further, it seems that static columns
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116655#comment-15116655
]
Stefania commented on CASSANDRA-8180:
-
bq. That is, your code is currently completely disabled by
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116897#comment-15116897
]
Stefania commented on CASSANDRA-8180:
-
I think the issue is in {{MetadataCollector}}:
{code}
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116781#comment-15116781
]
Stefania commented on CASSANDRA-8180:
-
bq. It seems we can have sstables with no tombstones, valid
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115132#comment-15115132
]
Branimir Lambov commented on CASSANDRA-8180:
bq. iter.partitionLevelDeletion() is
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114909#comment-15114909
]
Stefania commented on CASSANDRA-8180:
-
Pushed a
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110307#comment-15110307
]
Branimir Lambov commented on CASSANDRA-8180:
bq. What is an example of any other
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110332#comment-15110332
]
Stefania commented on CASSANDRA-8180:
-
bq. Tombstones. A {{DELETE WHERE pk = ? AND ck1 = ?}} in a
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109971#comment-15109971
]
Stefania commented on CASSANDRA-8180:
-
Thank you for the review.
bq. updateClusteringValues()
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109052#comment-15109052
]
Branimir Lambov commented on CASSANDRA-8180:
I personally would prefer to not modify the
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108363#comment-15108363
]
Branimir Lambov commented on CASSANDRA-8180:
{{updateClusteringValues()}} doesn't produce
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106233#comment-15106233
]
Stefania commented on CASSANDRA-8180:
-
Rebased and squashed [~blambov]:
||trunk||
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096458#comment-15096458
]
Sylvain Lebresne commented on CASSANDRA-8180:
-
[~Stefania] Could you have a shot at
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096476#comment-15096476
]
Stefania commented on CASSANDRA-8180:
-
Will rebase and also try to see if we can leverage
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642236#comment-14642236
]
Stefania commented on CASSANDRA-8180:
-
[~blambov] I've pushed a new commit where I
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640182#comment-14640182
]
Branimir Lambov commented on CASSANDRA-8180:
Yes, I have started looking
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640206#comment-14640206
]
Stefania commented on CASSANDRA-8180:
-
Thanks, make sure you have the latest code
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640223#comment-14640223
]
Benedict commented on CASSANDRA-8180:
-
Support for that isn't fantastic, but
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640202#comment-14640202
]
Stefania commented on CASSANDRA-8180:
-
We definitely need a place to archive these
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640337#comment-14640337
]
Branimir Lambov commented on CASSANDRA-8180:
I have some worries that
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640475#comment-14640475
]
Stefania commented on CASSANDRA-8180:
-
bq. I have some worries that relate to the
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637037#comment-14637037
]
Joshua McKenzie commented on CASSANDRA-8180:
Do we have a place where
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636514#comment-14636514
]
Sylvain Lebresne commented on CASSANDRA-8180:
-
bq. Sylvain Lebresne are
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636538#comment-14636538
]
Stefania commented on CASSANDRA-8180:
-
Thanks. [~blambov] would you have time to
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636477#comment-14636477
]
Stefania commented on CASSANDRA-8180:
-
I have attached the latest patch based on
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636584#comment-14636584
]
Stefania commented on CASSANDRA-8180:
-
Noted. I'll work on a suitable stress
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636566#comment-14636566
]
Sylvain Lebresne commented on CASSANDRA-8180:
-
Side note: would be nice to
[
https://issues.apache.org/jira/browse/CASSANDRA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516104#comment-14516104
]
Stefania commented on CASSANDRA-8180:
-
Rebased to latest 8099 branch.
Test
38 matches
Mail list logo