[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494200#comment-14494200 ] Nick Bailey commented on CASSANDRA-8348: +1 from me. Tested the patches out on 3.0 and 2.1 allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.5 Attachments: 8348_21.patch, 8348_trunk.patch, 8348_v2.patch, Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487850#comment-14487850 ] Nick Bailey commented on CASSANDRA-8348: [~SachinJanani] ^ allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.5 Attachments: 8348_v2.patch, Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483359#comment-14483359 ] Nick Bailey commented on CASSANDRA-8348: bq. Also I think the imports should be managed properly and unnecessary imports should be avoided I'm fine with it personally. I didn't see anything in the contributor guidelines so I think you are good to leave it. bq. Regarding the other patch for 3.0 I cant find the branch for 3.0 version on github https://github.com/apache/cassandra 3.0 is trunk, you likely need an additional patch for the 2.1 branch. https://github.com/apache/cassandra/tree/cassandra-2.1 Other notes, * You added some tabs into this new patch. Whitespace should be spaces only. * Your check if (splittedString.length == 2) will catch both cases where a column family isn't passed in or a secondary index is passed in. Can probably remove those additional checks in the if block and update the error message. So nothing major to change, looks good to me besides that. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.5 Attachments: 8348_v2.patch, Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482530#comment-14482530 ] Sachin Janani commented on CASSANDRA-8348: -- [~nickmbailey] Have you got any chance to review the updated patch? Regarding the other patch for 3.0 I cant find the branch for 3.0 version on github [https://github.com/apache/cassandra] .Is it the same as current trunk if yes than the updated patch is created using the trunk, if not can you please point me to the correct branch? allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.5 Attachments: 8348_v2.patch, Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392834#comment-14392834 ] Sachin Janani commented on CASSANDRA-8348: -- [~nickmbailey] I have created the new patch using latest code from trunk and also removed the redundant calls to *getValidKeySpace*. Also I think the imports should be managed properly and unnecessary imports should be avoided.Do you want me to remove it? Whats your opinion? allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.5 Attachments: 8348_v2.patch, Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388846#comment-14388846 ] Nick Bailey commented on CASSANDRA-8348: Unfortunately the patch doesn't apply to 2.1 anymore. Sorry for the delay, can you update the patch [~SachinJanani]? The code looks pretty good to me except I think you call getValidKeyspace() on the same keyspace twice. Also it looks like your IDE auto expanded any '*' imports. I don't remember what the c* team's policy on that is. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.4 Attachments: Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388850#comment-14388850 ] Nick Bailey commented on CASSANDRA-8348: Also, we'll probably want a second patch against 3.0 since we changed 'column family' to 'table' everywhere. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.4 Attachments: Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387011#comment-14387011 ] Jonathan Ellis commented on CASSANDRA-8348: --- [~nickmbailey] or [~hoangelos] can you review? allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 2.1.4 Attachments: Patch-8348.patch Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289198#comment-14289198 ] Sachin Janani commented on CASSANDRA-8348: -- Going ahead I have implemented the approach 2 and uploaded the patch.So now the nodetool have a separate option in snapshot command (--kc-list) where we can provide list of column family from different keyspace in the form ks.cf.But currently this does not support regular expression in column family name like ks.c*,ks.* etc. Also [~hoangelos] [~nickmbailey] I have added a separate method takeMultipleColumnFamilySnapshot in StorageServiceBean.java for this option.Please let me know if there are any changes need to be done. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 3.0, 2.1.3 Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282184#comment-14282184 ] Sachin Janani commented on CASSANDRA-8348: -- I am taking up this jira.I would like to propose following 2 approaches: 1) To provide ks.cf list in the already available option -cf This approach will take the following types of arguments: e.g: nodetool snapshot -cf ks1.cf1 ks2.cf3 ks4.* The above command will take snapshot of column family cf1 from keyspace ks1 and cf3 from keyspace ks2 and all column families from keyspace ks4 Pros: No need to add extra option Existing keyspace option will be obsolete Cons: Users may need to change their existing scripts and -cf will no longer support only column family name 2) To provide separate option to accept keyspace.columnfamily list: This approach will add a new option which will take following parameters: e.g nodetool -kclist ks1.cf1 ks2.cf2 ks2.cf3 ks4.* The above command will take snapshot of column family cf1 from keyspace ks1 and cf3 from keyspace ks2 and all column families from keyspace ks4 Pros: Will support existing option so no need to change existing scripts Will help to take snapshot of multiple columnfamily from different keyspace in one go Cons: Need to add extra option Can anyone please suggest the approach that I should follow or if you have some different approach please let me know. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Fix For: 3.0, 2.1.3 Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
[ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219742#comment-14219742 ] Nick Bailey commented on CASSANDRA-8348: It make make sense to include a method that takes a list of ks.cf pairs to snapshot as well. allow takeColumnFamilySnapshot to take a list of ColumnFamilies --- Key: CASSANDRA-8348 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348 Project: Cassandra Issue Type: Improvement Reporter: Peter Halliday Priority: Minor Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces to snapshot. However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily to snapshot. This should allow for multiple ColumnFamilies within the same Keyspace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
