[jira] [Commented] (CASSANDRA-9374) Remove thrift dependency in stress schema creation
[
https://issues.apache.org/jira/browse/CASSANDRA-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545403#comment-14545403
]
Aleksey Yeschenko commented on CASSANDRA-9374:
--
I haven't verified it operating, since you already have, and code LGTM overall.
Some potential issues:
1. in {{createKeyspaceNative()}} we should quote the name of the keyspace
2. in {{createKeyspaceStatementCQL3()}} we should quote it as well
3. same goes for {{createStandard1StatementCQL3()}} and
{{createCounter1StatementCQL3()}}, although there we can drop the keyspace name
from {{CREATE TABLE}} entirely, since we'd have set it by calling {{USE}} anyway
Nit: in {{createKeySpacesThrift()}} , in the try/catch block, could clean up
counters related comments and also get rid of all {{set_cql_version()}} calls
- those are no-op.
Remove thrift dependency in stress schema creation
--
Key: CASSANDRA-9374
URL: https://issues.apache.org/jira/browse/CASSANDRA-9374
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Ryan McGuire
Assignee: T Jake Luciani
Priority: Minor
Fix For: 2.2.x
With CASSANDRA-9319 the thrift server is turned off by default, which makes
stress no longer work out of the box. Even though stress uses native CQL3 by
default, there is still some remaining piece that uses thrift for schema
creation.
This is what you get by default now:
{code}
$ JAVA_HOME=~/fab/java ~/fab/stress/default/tools/bin/cassandra-stress write
n=1900 -rate threads=300 -node blade-11-4a,blade-11-3a,blade-11-2a
Exception in thread main java.lang.RuntimeException:
org.apache.thrift.transport.TTransportException: java.net.ConnectException:
Connection refused
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:144)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:110)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpacesThrift(SettingsSchema.java:111)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpaces(SettingsSchema.java:59)
at
org.apache.cassandra.stress.settings.StressSettings.maybeCreateKeyspaces(StressSettings.java:205)
at org.apache.cassandra.stress.StressAction.run(StressAction.java:55)
at org.apache.cassandra.stress.Stress.main(Stress.java:109)
Caused by: org.apache.thrift.transport.TTransportException:
java.net.ConnectException: Connection refused
at org.apache.thrift.transport.TSocket.open(TSocket.java:187)
at
org.apache.thrift.transport.TFramedTransport.open(TFramedTransport.java:81)
at
org.apache.cassandra.thrift.TFramedTransportFactory.openTransport(TFramedTransportFactory.java:41)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:124)
... 6 more
Caused by: java.net.ConnectException: Connection refused
at java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at org.apache.thrift.transport.TSocket.open(TSocket.java:182)
... 9 more
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9374) Remove thrift dependency in stress schema creation
[
https://issues.apache.org/jira/browse/CASSANDRA-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542394#comment-14542394
]
Nick Bailey commented on CASSANDRA-9374:
It seems fine that this doesn't block a beta release but I'd say this needs to
target an rc at least. Requiring turning on thrift and doing a rolling restart
to run stress doesn't seem very friendly.
Remove thrift dependency in stress schema creation
--
Key: CASSANDRA-9374
URL: https://issues.apache.org/jira/browse/CASSANDRA-9374
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Ryan McGuire
Assignee: T Jake Luciani
Priority: Minor
Fix For: 2.2.x
With CASSANDRA-9319 the thrift server is turned off by default, which makes
stress no longer work out of the box. Even though stress uses native CQL3 by
default, there is still some remaining piece that uses thrift for schema
creation.
This is what you get by default now:
{code}
$ JAVA_HOME=~/fab/java ~/fab/stress/default/tools/bin/cassandra-stress write
n=1900 -rate threads=300 -node blade-11-4a,blade-11-3a,blade-11-2a
Exception in thread main java.lang.RuntimeException:
org.apache.thrift.transport.TTransportException: java.net.ConnectException:
Connection refused
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:144)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:110)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpacesThrift(SettingsSchema.java:111)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpaces(SettingsSchema.java:59)
at
org.apache.cassandra.stress.settings.StressSettings.maybeCreateKeyspaces(StressSettings.java:205)
at org.apache.cassandra.stress.StressAction.run(StressAction.java:55)
at org.apache.cassandra.stress.Stress.main(Stress.java:109)
Caused by: org.apache.thrift.transport.TTransportException:
java.net.ConnectException: Connection refused
at org.apache.thrift.transport.TSocket.open(TSocket.java:187)
at
org.apache.thrift.transport.TFramedTransport.open(TFramedTransport.java:81)
at
org.apache.cassandra.thrift.TFramedTransportFactory.openTransport(TFramedTransportFactory.java:41)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:124)
... 6 more
Caused by: java.net.ConnectException: Connection refused
at java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at org.apache.thrift.transport.TSocket.open(TSocket.java:182)
... 9 more
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9374) Remove thrift dependency in stress schema creation
[
https://issues.apache.org/jira/browse/CASSANDRA-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542488#comment-14542488
]
Brandon Williams commented on CASSANDRA-9374:
-
I think a nodetool enablethrift would at least eliminate the restart, but I
agree with you.
Remove thrift dependency in stress schema creation
--
Key: CASSANDRA-9374
URL: https://issues.apache.org/jira/browse/CASSANDRA-9374
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Ryan McGuire
Assignee: T Jake Luciani
Priority: Minor
Fix For: 2.2.x
With CASSANDRA-9319 the thrift server is turned off by default, which makes
stress no longer work out of the box. Even though stress uses native CQL3 by
default, there is still some remaining piece that uses thrift for schema
creation.
This is what you get by default now:
{code}
$ JAVA_HOME=~/fab/java ~/fab/stress/default/tools/bin/cassandra-stress write
n=1900 -rate threads=300 -node blade-11-4a,blade-11-3a,blade-11-2a
Exception in thread main java.lang.RuntimeException:
org.apache.thrift.transport.TTransportException: java.net.ConnectException:
Connection refused
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:144)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:110)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpacesThrift(SettingsSchema.java:111)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpaces(SettingsSchema.java:59)
at
org.apache.cassandra.stress.settings.StressSettings.maybeCreateKeyspaces(StressSettings.java:205)
at org.apache.cassandra.stress.StressAction.run(StressAction.java:55)
at org.apache.cassandra.stress.Stress.main(Stress.java:109)
Caused by: org.apache.thrift.transport.TTransportException:
java.net.ConnectException: Connection refused
at org.apache.thrift.transport.TSocket.open(TSocket.java:187)
at
org.apache.thrift.transport.TFramedTransport.open(TFramedTransport.java:81)
at
org.apache.cassandra.thrift.TFramedTransportFactory.openTransport(TFramedTransportFactory.java:41)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:124)
... 6 more
Caused by: java.net.ConnectException: Connection refused
at java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at org.apache.thrift.transport.TSocket.open(TSocket.java:182)
... 9 more
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9374) Remove thrift dependency in stress schema creation
[
https://issues.apache.org/jira/browse/CASSANDRA-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542261#comment-14542261
]
Jonathan Ellis commented on CASSANDRA-9374:
---
(Marking 2.2.x since consensus is this should not block beta.)
Remove thrift dependency in stress schema creation
--
Key: CASSANDRA-9374
URL: https://issues.apache.org/jira/browse/CASSANDRA-9374
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Ryan McGuire
Assignee: T Jake Luciani
Fix For: 2.2.x
With CASSANDRA-9319 the thrift server is turned off by default, which makes
stress no longer work out of the box. Even though stress uses native CQL3 by
default, there is still some remaining piece that uses thrift for schema
creation.
This is what you get by default now:
{code}
$ JAVA_HOME=~/fab/java ~/fab/stress/default/tools/bin/cassandra-stress write
n=1900 -rate threads=300 -node blade-11-4a,blade-11-3a,blade-11-2a
Exception in thread main java.lang.RuntimeException:
org.apache.thrift.transport.TTransportException: java.net.ConnectException:
Connection refused
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:144)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:110)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpacesThrift(SettingsSchema.java:111)
at
org.apache.cassandra.stress.settings.SettingsSchema.createKeySpaces(SettingsSchema.java:59)
at
org.apache.cassandra.stress.settings.StressSettings.maybeCreateKeyspaces(StressSettings.java:205)
at org.apache.cassandra.stress.StressAction.run(StressAction.java:55)
at org.apache.cassandra.stress.Stress.main(Stress.java:109)
Caused by: org.apache.thrift.transport.TTransportException:
java.net.ConnectException: Connection refused
at org.apache.thrift.transport.TSocket.open(TSocket.java:187)
at
org.apache.thrift.transport.TFramedTransport.open(TFramedTransport.java:81)
at
org.apache.cassandra.thrift.TFramedTransportFactory.openTransport(TFramedTransportFactory.java:41)
at
org.apache.cassandra.stress.settings.StressSettings.getRawThriftClient(StressSettings.java:124)
... 6 more
Caused by: java.net.ConnectException: Connection refused
at java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at org.apache.thrift.transport.TSocket.open(TSocket.java:182)
... 9 more
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
