[jira] [Commented] (CASSANDRA-9941) SSTableVerify has wrong return codes on windows
[
https://issues.apache.org/jira/browse/CASSANDRA-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652136#comment-14652136
]
Philip Thompson commented on CASSANDRA-9941:
+1, and verified the test is fixed.
SSTableVerify has wrong return codes on windows
---
Key: CASSANDRA-9941
URL: https://issues.apache.org/jira/browse/CASSANDRA-9941
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Philip Thompson
Assignee: Paulo Motta
Labels: windows
Fix For: 2.2.x
The dtest {{offline_tools_test.py:TestOfflineTools.sstableverify_test}} is
failing on windows. When running sstableverify.bat on a nonexistent keyspace,
the correct error message is printed, but an error code of 0 for success is
returned, which does not match the correct behavior on linux, which returns 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9941) SSTableVerify has wrong return codes on windows
[
https://issues.apache.org/jira/browse/CASSANDRA-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652142#comment-14652142
]
Paulo Motta commented on CASSANDRA-9941:
Nice. The ccm [fix|https://github.com/pcmanus/ccm/pull/343] and
cassandra.in.bat
[fix|https://github.com/apache/cassandra/commit/e93b86c2b3fb1bef33900d2c24427852044e2e54]
might help other Windows tests, so we should keep an eye on Windows tests
after this is merged.
SSTableVerify has wrong return codes on windows
---
Key: CASSANDRA-9941
URL: https://issues.apache.org/jira/browse/CASSANDRA-9941
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Philip Thompson
Assignee: Paulo Motta
Labels: windows
Fix For: 2.2.x
The dtest {{offline_tools_test.py:TestOfflineTools.sstableverify_test}} is
failing on windows. When running sstableverify.bat on a nonexistent keyspace,
the correct error message is printed, but an error code of 0 for success is
returned, which does not match the correct behavior on linux, which returns 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9941) SSTableVerify has wrong return codes on windows
[
https://issues.apache.org/jira/browse/CASSANDRA-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649799#comment-14649799
]
Joshua McKenzie commented on CASSANDRA-9941:
Testing on this brought up a different issue: the ccm call to run_sstableverify
is actually checking the contents of the data\ folder on the *root* cassandra
installation directory rather than the ccm nodes. The test was failing out for
me on the assertion checking for the failure text as I was sourcing from a
local 2.2 checkout that I'd happened to perform stress on yesterday which still
had data files lying around and it had the KS/CF that this test was looking for.
It's a separate ccm-bug that I'm discussing w/[~philipthompson] offline that
shouldn't hold up inspection of this ticket. I'm out for the next week so if
anyone wants to grab this in the interim, feel free.
SSTableVerify has wrong return codes on windows
---
Key: CASSANDRA-9941
URL: https://issues.apache.org/jira/browse/CASSANDRA-9941
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: Philip Thompson
Assignee: Joshua McKenzie
Fix For: 2.2.x
The dtest {{offline_tools_test.py:TestOfflineTools.sstableverify_test}} is
failing on windows. When running sstableverify.bat on a nonexistent keyspace,
the correct error message is printed, but an error code of 0 for success is
returned, which does not match the correct behavior on linux, which returns 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
