[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2020-04-20 Thread Josh McKenzie (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh McKenzie updated CASSANDRA-14330:
--
Component/s: Local/SSTable
 Consistency/Coordination

> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Coordination, Local/SSTable
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 3.0.17, 3.11.3, 4.0
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request:
> {code:java}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
> versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
> /127.0.0.2]}, responses:
> /127.0.0.1 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=1] ]: ck=0 | ,
>/127.0.0.2 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
> localDeletion=1521572669 ]: ck=0 |
>Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-throwing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2020-04-18 Thread Josh McKenzie (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh McKenzie updated CASSANDRA-14330:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Transient 
Incorrect Response(12987)

> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 3.0.17, 3.11.3, 4.0
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request:
> {code:java}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
> versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
> /127.0.0.2]}, responses:
> /127.0.0.1 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=1] ]: ck=0 | ,
>/127.0.0.2 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
> localDeletion=1521572669 ]: ck=0 |
>Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-throwing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2018-03-23 Thread Jeremy Hanna (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Hanna updated CASSANDRA-14330:
-
Description: 
If there is an open range tombstone in an iterator, a short read protection 
request for it will include a repeat open bound. Currently, {{DataResolver}} 
doesn't expect this, and will raise an assertion, timing out the request:
{code:java}
java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
/127.0.0.2]}, responses:
/127.0.0.1 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=1] ]: ck=0 | ,
   /127.0.0.2 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
localDeletion=1521572669 ]: ck=0 |
   Row[info=[ts=1] ]: ck=1 | 
{code}
As this is a completely normal/common scenario, we should allow for this, and 
relax the assertion.

Additionally, the linked branch makes the re-throwing {{AssertionError}} more 
detailed and more correct: the responses are now printed out in the correct 
order, respecting {{isReversed}}, the command causing the assertion is now 
logged, as is {{isReversed}} itself, and local deletion times for RTs.

  was:
If there is an open range tombstone in an iterator, a short read protection 
request for it will include a repeat open bound. Currently, {{DataResolver}} 
doesn't expect this, and will raise an assertion, timing out the request:

{code}
java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
/127.0.0.2]}, responses:
/127.0.0.1 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=1] ]: ck=0 | ,
   /127.0.0.2 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
localDeletion=1521572669 ]: ck=0 |
   Row[info=[ts=1] ]: ck=1 | 
{code}

As this is a completely normal/common scenario, we should allow for this, and 
relax the assertion.

Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
detailed and more correct: the responses are now printed out in the correct 
order, respecting {{isReversed}}, the command causing the assertion is now 
logged, as is {{isReversed}} itself, and local deletion times for RTs.


> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 4.0, 3.0.17, 3.11.3
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request:
> {code:java}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
> versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
> /127.0.0.2]}, responses:
> /127.0.0.1 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=1] ]: ck=0 | ,
>/127.0.0.2 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
> localDeletion=1521572669 ]: ck=0 |
>Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-throwing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2018-03-23 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-14330:
--
   Resolution: Fixed
Fix Version/s: (was: 3.11.x)
   (was: 4.x)
   (was: 3.0.x)
   3.11.3
   3.0.17
   4.0
   Status: Resolved  (was: Patch Available)

> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 4.0, 3.0.17, 3.11.3
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request:
> {code}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
> versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
> /127.0.0.2]}, responses:
> /127.0.0.1 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=1] ]: ck=0 | ,
>/127.0.0.2 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
> localDeletion=1521572669 ]: ck=0 |
>Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2018-03-21 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-14330:
--
Description: 
If there is an open range tombstone in an iterator, a short read protection 
request for it will include a repeat open bound. Currently, {{DataResolver}} 
doesn't expect this, and will raise an assertion, timing out the request:

{code}
java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
/127.0.0.2]}, responses:
/127.0.0.1 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=1] ]: ck=0 | ,
   /127.0.0.2 => [test.test] key=0 
partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
columns=[[] | []]
   Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
localDeletion=1521572669 ]: ck=0 |
   Row[info=[ts=1] ]: ck=1 | 
{code}

As this is a completely normal/common scenario, we should allow for this, and 
relax the assertion.

Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
detailed and more correct: the responses are now printed out in the correct 
order, respecting {{isReversed}}, the command causing the assertion is now 
logged, as is {{isReversed}} itself, and local deletion times for RTs.

  was:
If there is an open range tombstone in an iterator, a short read protection 
request for it will include a repeat open bound. Currently, {{DataResolver}} 
doesn't expect this, and will raise an assertion, timing out the request.

As this is a completely normal/common scenario, we should allow for this, and 
relax the assertion.

Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
detailed and more correct: the responses are now printed out in the correct 
order, respecting {{isReversed}}, the command causing the assertion is now 
logged, as is {{isReversed}} itself, and local deletion times for RTs.


> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request:
> {code}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, 
> versions=[Marker EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, 
> /127.0.0.2]}, responses:
> /127.0.0.1 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=1] ]: ck=0 | ,
>/127.0.0.2 => [test.test] key=0 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | []]
>Row[info=[ts=-9223372036854775808] del=deletedAt=1, 
> localDeletion=1521572669 ]: ck=0 |
>Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2018-03-21 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-14330:
--
Reviewer: Sylvain Lebresne
  Status: Patch Available  (was: Open)

> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request.
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair

2018-03-21 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-14330:
--
Description: 
If there is an open range tombstone in an iterator, a short read protection 
request for it will include a repeat open bound. Currently, {{DataResolver}} 
doesn't expect this, and will raise an assertion, timing out the request.

As this is a completely normal/common scenario, we should allow for this, and 
relax the assertion.

Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
detailed and more correct: the responses are now printed out in the correct 
order, respecting {{isReversed}}, the command causing the assertion is now 
logged, as is {{isReversed}} itself, and local deletion times for RTs.
Summary: Handle repeat open bound from SRP in read repair  (was: TBA)

> Handle repeat open bound from SRP in read repair
> 
>
> Key: CASSANDRA-14330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If there is an open range tombstone in an iterator, a short read protection 
> request for it will include a repeat open bound. Currently, {{DataResolver}} 
> doesn't expect this, and will raise an assertion, timing out the request.
> As this is a completely normal/common scenario, we should allow for this, and 
> relax the assertion.
> Additionally, the linked branch makes the re-trhowing {{AssertionError}} more 
> detailed and more correct: the responses are now printed out in the correct 
> order, respecting {{isReversed}}, the command causing the assertion is now 
> logged, as is {{isReversed}} itself, and local deletion times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org