[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15163:
--
Source Control Link:
https://github.com/apache/cassandra/commit/f9ff88437742675db5c53f5834884b43f8937e00
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0
>
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15163:
Reviewers: Blake Eggleston, Blake Eggleston (was: Blake Eggleston)
Blake Eggleston, Blake Eggleston (was: Blake Eggleston)
Status: Review In Progress (was: Patch Available)
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0
>
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15163:
Status: Ready to Commit (was: Review In Progress)
+1
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0
>
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15163:
--
Test and Documentation Plan: N/A
Status: Patch Available (was: Open)
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15163:
--
Complexity: Low Hanging Fruit
Assignee: Aleksey Yeschenko
Change Category: Semantic
Reviewers: Blake Eggleston
Status: Open (was: Triage Needed)
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15163) Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15163:
--
Fix Version/s: 4.0
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
> correctly
>
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0
>
>
> There is currently a nested sub-hierarchy of messages used by repair - in
> {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all
> sharing one verb handler. The first two can and should be addressed, and it’s
> mostly a mechanical task to do so. The last one should be tackled separately,
> when we get to refactor repair some day (and it could definitely use some
> love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes
> repair use the new messaging service in a more correct way, making verbs and
> deserialization more explicit. It wasn't included into the original commit so
> that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
