[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-19551: - Fix Version/s: (was: 5.x) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 3.0.31, 3.11.17, 4.0.13, 5.0-beta2, 5.1 > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151] > and if nodes modify the map, such as in {{start}} when [updating the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860] > then when {{get_env}} runs it will [overwrite the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244] > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-19551: - Fix Version/s: 3.0.31 3.11.17 4.0.13 5.0-beta2 5.1 Since Version: NA Source Control Link: https://github.com/riptano/ccm/commit/ce69e9df94f9e44f3f5b36f8ed4e2d07f734195f Resolution: Fixed Status: Resolved (was: Ready to Commit) I committed this and updated the cassandra-test tag. > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 3.0.31, 3.11.17, 4.0.13, 5.0-beta2, 5.x, 5.1 > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151] > and if nodes modify the map, such as in {{start}} when [updating the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860] > then when {{get_env}} runs it will [overwrite the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244] > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-19551: --- Description: In {{node.py}} {{__environment_variables}} is generally always set with a map that is passed in from {{cluster.py}} so it is [shared between nodes|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151] and if nodes modify the map, such as in {{start}} when [updating the Java version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860] then when {{get_env}} runs it will [overwrite the Java version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244] that is selected by {{update_java_version}}. This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in some of the upgrade tests because after the first node upgrades to 4.0 it's not longer possible for the subsequent nodes to select a Java version that isn't 11 because it's overridden by {{__environment_variables}}. I'm not even 100% clear on why the code in {{start}} should update {{__environment_variables}} at all if we calculate the correct java version on every invocation of other tools. was: In {{node.py}} {{__environment_variables}} is generally always set with a map that is passed in from {{cluster.py}} so it is [shared between nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) and if nodes modify the map, such as in {{start}} when [updating the Java version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) then when {{get_env}} runs it will [overwrite the Java version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) that is selected by {{update_java_version}}. This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in some of the upgrade tests because after the first node upgrades to 4.0 it's not longer possible for the subsequent nodes to select a Java version that isn't 11 because it's overridden by {{__environment_variables}}. I'm not even 100% clear on why the code in {{start}} should update {{__environment_variables}} at all if we calculate the correct java version on every invocation of other tools. > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151] > and if nodes modify the map, such as in {{start}} when [updating the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860] > then when {{get_env}} runs it will [overwrite the Java > version|https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244] > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-19551: Reviewers: Berenguer Blasi, Josh McKenzie, Joshua McKenzie (was: Josh McKenzie, Joshua McKenzie) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-19551: -- Status: Ready to Commit (was: Review In Progress) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-19551: -- Reviewers: Joshua McKenzie, Josh McKenzie (was: Joshua McKenzie) Joshua McKenzie, Josh McKenzie (was: Josh McKenzie, Joshua McKenzie) Status: Review In Progress (was: Patch Available) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-19551: --- Attachment: ci_summary.html > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > Attachments: ci_summary.html > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-19551: --- Test and Documentation Plan: Run all python dtests Status: Patch Available (was: Open) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19551) CCM nodes share the same environment variable map breaking upgrade tests
[ https://issues.apache.org/jira/browse/CASSANDRA-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-19551: --- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Low Hanging Fruit Discovered By: DTest Fix Version/s: 5.x Reviewers: Joshua McKenzie Severity: Normal Assignee: Ariel Weisberg Status: Open (was: Triage Needed) > CCM nodes share the same environment variable map breaking upgrade tests > > > Key: CASSANDRA-19551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19551 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Fix For: 5.x > > > In {{node.py}} {{__environment_variables}} is generally always set with a map > that is passed in from {{cluster.py}} so it is [shared between > nodes](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L151) > and if nodes modify the map, such as in {{start}} when [updating the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L860) > then when {{get_env}} runs it will [overwrite the Java > version](https://github.com/riptano/ccm/blob/ac264706c8ca007cc584871ce907d48db334d36d/ccmlib/node.py#L244) > that is selected by {{update_java_version}}. > This results in {{nodetool drain}} failing when upgrading from 3.11 to 4.0 in > some of the upgrade tests because after the first node upgrades to 4.0 it's > not longer possible for the subsequent nodes to select a Java version that > isn't 11 because it's overridden by {{__environment_variables}}. > I'm not even 100% clear on why the code in {{start}} should update > {{__environment_variables}} at all if we calculate the correct java version > on every invocation of other tools. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org