[jira] [Updated] (CASSANDRA-9067) BloomFilter serialization format should not change byte ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-9067: --- Resolution: Fixed Fix Version/s: (was: 4.x) 4.0 Status: Resolved (was: Patch Available) committed as sha {{d6cc5943250a7c19adb42ef86dc9a186d4e52166}} Thanks, [~jay.zhuang]! > BloomFilter serialization format should not change byte ordering > > > Key: CASSANDRA-9067 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9067 > Project: Cassandra > Issue Type: Improvement >Reporter: Benedict >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.0 > > > As a follow-up to CASSANDRA-9066 and CASSANDRA-9060, it appears we do some > unnecessary byte swapping during the serialization of bloom filters, which > makes the logic slower and harder to follow. We should either perform them > more efficiently (using Long.reverseBytes) or, preferably, eliminate the > conversion altogether since it does not appear to serve any purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9067) BloomFilter serialization format should not change byte ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-9067: --- Reviewer: Jason Brown > BloomFilter serialization format should not change byte ordering > > > Key: CASSANDRA-9067 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9067 > Project: Cassandra > Issue Type: Improvement >Reporter: Benedict >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > > As a follow-up to CASSANDRA-9066 and CASSANDRA-9060, it appears we do some > unnecessary byte swapping during the serialization of bloom filters, which > makes the logic slower and harder to follow. We should either perform them > more efficiently (using Long.reverseBytes) or, preferably, eliminate the > conversion altogether since it does not appear to serve any purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9067) BloomFilter serialization format should not change byte ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Zhuang updated CASSANDRA-9067: -- Status: Patch Available (was: Awaiting Feedback) > BloomFilter serialization format should not change byte ordering > > > Key: CASSANDRA-9067 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9067 > Project: Cassandra > Issue Type: Improvement >Reporter: Benedict >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > > As a follow-up to CASSANDRA-9066 and CASSANDRA-9060, it appears we do some > unnecessary byte swapping during the serialization of bloom filters, which > makes the logic slower and harder to follow. We should either perform them > more efficiently (using Long.reverseBytes) or, preferably, eliminate the > conversion altogether since it does not appear to serve any purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9067) BloomFilter serialization format should not change byte ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Zhuang updated CASSANDRA-9067: -- Status: Awaiting Feedback (was: Open) > BloomFilter serialization format should not change byte ordering > > > Key: CASSANDRA-9067 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9067 > Project: Cassandra > Issue Type: Improvement >Reporter: Benedict >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > > As a follow-up to CASSANDRA-9066 and CASSANDRA-9060, it appears we do some > unnecessary byte swapping during the serialization of bloom filters, which > makes the logic slower and harder to follow. We should either perform them > more efficiently (using Long.reverseBytes) or, preferably, eliminate the > conversion altogether since it does not appear to serve any purpose. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org