Jenkins build is back to normal : cayenne-master » h2,JDK 1.8 (latest),ubuntu #829

2018-04-19 Thread Apache Jenkins Server 
See

[jira] [Commented] (CAY-2430) Redo throws NPE

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAY-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443822#comment-16443822
 ] 

ASF GitHub Bot commented on CAY-2430:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cayenne/pull/290


> Redo throws NPE
> ---
>
> Key: CAY-2430
> URL: https://issues.apache.org/jira/browse/CAY-2430
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
>
> Redo throws NPE
> Exception occurs in different cases, below is the simplest way to reproduce
>  # Add stored procedure
>  # Remove stored procedure
>  # Select Undo
>  # Select Redo
> -> Cayenne Modeler error appears
>  
> Log:
>  Apr 14, 2018 7:47:52 AM ERROR: CayenneModeler Error
>  java.lang.NullPointerException
>      at 
> org.apache.cayenne.modeler.action.RemoveAction.removeDataMapFromDataNode(RemoveAction.java:463)
>      at 
> org.apache.cayenne.modeler.undo.RemoveUndoableEdit.redo(RemoveUndoableEdit.java:215)
>      at javax.swing.undo.UndoManager.redoTo(UndoManager.java:351)
>      at javax.swing.undo.UndoManager.redo(UndoManager.java:458)
>      at 
> org.apache.cayenne.modeler.undo.CayenneUndoManager.redo(CayenneUndoManager.java:65)
>      at 
> org.apache.cayenne.modeler.action.RedoAction.performAction(RedoAction.java:65)
>      at 
> org.apache.cayenne.modeler.util.CayenneAction.actionPerformed(CayenneAction.java:171)
>      at 
> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
>      at 
> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
>      at 
> javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
>      at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
>      at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
>      at 
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
>      at java.awt.Component.processMouseEvent(Component.java:6533)
>      at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
>      at java.awt.Component.processEvent(Component.java:6298)
>      at java.awt.Container.processEvent(Container.java:2236)
>      at java.awt.Component.dispatchEventImpl(Component.java:4889)
>      at java.awt.Container.dispatchEventImpl(Container.java:2294)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
>      at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
>      at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
>      at java.awt.Container.dispatchEventImpl(Container.java:2280)
>      at java.awt.Window.dispatchEventImpl(Window.java:2746)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
>      at java.awt.EventQueue.access$500(EventQueue.java:97)
>      at java.awt.EventQueue$3.run(EventQueue.java:709)
>      at java.awt.EventQueue$3.run(EventQueue.java:703)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
>      at java.awt.EventQueue$4.run(EventQueue.java:731)
>      at java.awt.EventQueue$4.run(EventQueue.java:729)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
>      at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>      at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>      at 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
>      at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
>      at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>      at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cayenne pull request #290: CAY-2430

2018-04-19 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cayenne/pull/290


---

[3/3] cayenne git commit: CAY-2430 Modeler: Redo throws NPE release notes

2018-04-19 Thread ntimofeev 
CAY-2430 Modeler: Redo throws NPE
  release notes


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/fed6bcb9
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/fed6bcb9
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/fed6bcb9

Branch: refs/heads/master
Commit: fed6bcb95dba8f0bfed1a24dff4375ad9618eb9a
Parents: 07611d9
Author: Nikita Timofeev 
Authored: Thu Apr 19 13:06:43 2018 +0300
Committer: Nikita Timofeev 
Committed: Thu Apr 19 13:06:43 2018 +0300

--
 RELEASE-NOTES.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cayenne/blob/fed6bcb9/RELEASE-NOTES.txt
--
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 99cc961..f8b777f 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -35,7 +35,6 @@ CAY-2414 Modeler: new icon design
 CAY-2415 Transaction isolation and propagation support
 CAY-2416 Change TreeMap for HashMap to store data in Cayenne model classes
 CAY-2422 Modeler: Open driver setup window on driver load error
-CAY-2430 Modeler: Redo throws NPE
 
 Bug Fixes:
 
@@ -57,6 +56,7 @@ CAY-2420 Modeler: search is not performed for Stored 
Procedures
 CAY-2425 Modeler: Migrate DB Direction field is locked if no option was 
selected in dropdown list
 CAY-2427 Modeler: Undo throws exception
 CAY-2429 Generate classes: Invalid template type: EMBEDDABLE_SINGLE_CLASS
+CAY-2430 Modeler: Redo throws NPE
 
 --
 Release: 4.1.M1

[1/3] cayenne git commit: CAY-2430

2018-04-19 Thread ntimofeev 
Repository: cayenne
Updated Branches:
  refs/heads/master d2fb2de46 -> fed6bcb95


CAY-2430

Fixed NPE on redo delete procedure action.


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/cf2a1a06
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/cf2a1a06
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/cf2a1a06

Branch: refs/heads/master
Commit: cf2a1a060444a3717bf8c8f1d1dee1163e5dbbed
Parents: d2fb2de
Author: kkomyak 
Authored: Thu Apr 12 09:20:03 2018 +0300
Committer: kkomyak 
Committed: Thu Apr 19 10:35:29 2018 +0300

--
 RELEASE-NOTES.txt  | 1 +
 .../java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java   | 2 ++
 2 files changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/cayenne/blob/cf2a1a06/RELEASE-NOTES.txt
--
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 6440065..99cc961 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -35,6 +35,7 @@ CAY-2414 Modeler: new icon design
 CAY-2415 Transaction isolation and propagation support
 CAY-2416 Change TreeMap for HashMap to store data in Cayenne model classes
 CAY-2422 Modeler: Open driver setup window on driver load error
+CAY-2430 Modeler: Redo throws NPE
 
 Bug Fixes:
 

http://git-wip-us.apache.org/repos/asf/cayenne/blob/cf2a1a06/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java
--
diff --git 
a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java
 
b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java
index fd22b74..fe662b2 100644
--- 
a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java
+++ 
b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java
@@ -211,6 +211,7 @@ public class RemoveUndoableEdit extends CayenneUndoableEdit 
{
 break;
 case PROCEDURE:
 action.removeProcedure(map, procedure);
+break;
 case MAP_FROM_NODE:
 action.removeDataMapFromDataNode(dataNode, map);
 break;
@@ -222,6 +223,7 @@ public class RemoveUndoableEdit extends CayenneUndoableEdit 
{
 break;
 case EMBEDDABLE:
 action.removeEmbeddable(map, embeddable);
+break;
 }
 }

[jira] [Commented] (CAY-2424) Migrate DB: error query is not skipped, further excecution is not possible

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAY-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443820#comment-16443820
 ] 

ASF GitHub Bot commented on CAY-2424:
-

GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/291

CAY-2424

Added setting selected catalog to connection before executing scripts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2424

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #291


commit 332dcb41e97efaa9ea26d2ba636e6aff5ae8a5e7
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2424

Added setting selected catalog to connection before executing scripts.




> Migrate DB: error query is not skipped, further excecution is not possible
> --
>
> Key: CAY-2424
> URL: https://issues.apache.org/jira/browse/CAY-2424
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
> Attachments: c3.png
>
>
> # Reverse Engineer db
>  # Update model, add new db entity
>  # Run Migrate db Schema
>  # Select connection with no DB in url
>  # Select needed db in next popup window
>  # Select required 'To DB' operations, click Migrate
> There are 2 issues:
> -> selected db is not applied to auto_pk_support table creation
> -> error query is not skipped, and further queries are not executed, thus 
> 'awards' table is not created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[2/3] cayenne git commit: Merge PR #290

2018-04-19 Thread ntimofeev 
Merge PR #290


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/07611d93
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/07611d93
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/07611d93

Branch: refs/heads/master
Commit: 07611d930163d346bedb596cf9b6d8e0d1d65625
Parents: d2fb2de cf2a1a0
Author: Nikita Timofeev 
Authored: Thu Apr 19 13:05:58 2018 +0300
Committer: Nikita Timofeev 
Committed: Thu Apr 19 13:05:58 2018 +0300

--
 RELEASE-NOTES.txt  | 1 +
 .../java/org/apache/cayenne/modeler/undo/RemoveUndoableEdit.java   | 2 ++
 2 files changed, 3 insertions(+)
--

[GitHub] cayenne pull request #291: CAY-2424

2018-04-19 Thread const1993 
GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/291

CAY-2424

Added setting selected catalog to connection before executing scripts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2424

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #291


commit 332dcb41e97efaa9ea26d2ba636e6aff5ae8a5e7
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2424

Added setting selected catalog to connection before executing scripts.




---

[jira] [Commented] (CAY-2424) Migrate DB: error query is not skipped, further excecution is not possible

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAY-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443741#comment-16443741
 ] 

ASF GitHub Bot commented on CAY-2424:
-

Github user const1993 closed the pull request at:

https://github.com/apache/cayenne/pull/289


> Migrate DB: error query is not skipped, further excecution is not possible
> --
>
> Key: CAY-2424
> URL: https://issues.apache.org/jira/browse/CAY-2424
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
> Attachments: c3.png
>
>
> # Reverse Engineer db
>  # Update model, add new db entity
>  # Run Migrate db Schema
>  # Select connection with no DB in url
>  # Select needed db in next popup window
>  # Select required 'To DB' operations, click Migrate
> There are 2 issues:
> -> selected db is not applied to auto_pk_support table creation
> -> error query is not skipped, and further queries are not executed, thus 
> 'awards' table is not created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cayenne pull request #289: CAY-2424

2018-04-19 Thread const1993 
Github user const1993 closed the pull request at:

https://github.com/apache/cayenne/pull/289


---

[jira] [Updated] (CAY-2430) Redo throws NPE

2018-04-19 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAY-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated CAY-2430:

Labels: pull-request-available  (was: )

> Redo throws NPE
> ---
>
> Key: CAY-2430
> URL: https://issues.apache.org/jira/browse/CAY-2430
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
>
> Redo throws NPE
> Exception occurs in different cases, below is the simplest way to reproduce
>  # Add stored procedure
>  # Remove stored procedure
>  # Select Undo
>  # Select Redo
> -> Cayenne Modeler error appears
>  
> Log:
>  Apr 14, 2018 7:47:52 AM ERROR: CayenneModeler Error
>  java.lang.NullPointerException
>      at 
> org.apache.cayenne.modeler.action.RemoveAction.removeDataMapFromDataNode(RemoveAction.java:463)
>      at 
> org.apache.cayenne.modeler.undo.RemoveUndoableEdit.redo(RemoveUndoableEdit.java:215)
>      at javax.swing.undo.UndoManager.redoTo(UndoManager.java:351)
>      at javax.swing.undo.UndoManager.redo(UndoManager.java:458)
>      at 
> org.apache.cayenne.modeler.undo.CayenneUndoManager.redo(CayenneUndoManager.java:65)
>      at 
> org.apache.cayenne.modeler.action.RedoAction.performAction(RedoAction.java:65)
>      at 
> org.apache.cayenne.modeler.util.CayenneAction.actionPerformed(CayenneAction.java:171)
>      at 
> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
>      at 
> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
>      at 
> javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
>      at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
>      at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
>      at 
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
>      at java.awt.Component.processMouseEvent(Component.java:6533)
>      at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
>      at java.awt.Component.processEvent(Component.java:6298)
>      at java.awt.Container.processEvent(Container.java:2236)
>      at java.awt.Component.dispatchEventImpl(Component.java:4889)
>      at java.awt.Container.dispatchEventImpl(Container.java:2294)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
>      at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
>      at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
>      at java.awt.Container.dispatchEventImpl(Container.java:2280)
>      at java.awt.Window.dispatchEventImpl(Window.java:2746)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
>      at java.awt.EventQueue.access$500(EventQueue.java:97)
>      at java.awt.EventQueue$3.run(EventQueue.java:709)
>      at java.awt.EventQueue$3.run(EventQueue.java:703)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
>      at java.awt.EventQueue$4.run(EventQueue.java:731)
>      at java.awt.EventQueue$4.run(EventQueue.java:729)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
>      at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>      at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>      at 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
>      at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
>      at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>      at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAY-2424) Migrate DB: error query is not skipped, further excecution is not possible

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAY-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443662#comment-16443662
 ] 

ASF GitHub Bot commented on CAY-2424:
-

GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/289

CAY-2424

Added setting selected catalog to connection before executing scripts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2424

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289


commit de5667fc41df2fea626a2ef50a64f1e87166bc50
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2424

Added setting selected catalog to connection before executing scripts.




> Migrate DB: error query is not skipped, further excecution is not possible
> --
>
> Key: CAY-2424
> URL: https://issues.apache.org/jira/browse/CAY-2424
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
> Attachments: c3.png
>
>
> # Reverse Engineer db
>  # Update model, add new db entity
>  # Run Migrate db Schema
>  # Select connection with no DB in url
>  # Select needed db in next popup window
>  # Select required 'To DB' operations, click Migrate
> There are 2 issues:
> -> selected db is not applied to auto_pk_support table creation
> -> error query is not skipped, and further queries are not executed, thus 
> 'awards' table is not created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cayenne pull request #289: CAY-2424

2018-04-19 Thread const1993 
GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/289

CAY-2424

Added setting selected catalog to connection before executing scripts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2424

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289


commit de5667fc41df2fea626a2ef50a64f1e87166bc50
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2424

Added setting selected catalog to connection before executing scripts.




---

[jira] [Commented] (CAY-2430) Redo throws NPE

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAY-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443664#comment-16443664
 ] 

ASF GitHub Bot commented on CAY-2430:
-

GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/290

CAY-2430

Fixed NPE on redo delete procedure action.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit cf2a1a060444a3717bf8c8f1d1dee1163e5dbbed
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2430

Fixed NPE on redo delete procedure action.




> Redo throws NPE
> ---
>
> Key: CAY-2430
> URL: https://issues.apache.org/jira/browse/CAY-2430
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
>
> Redo throws NPE
> Exception occurs in different cases, below is the simplest way to reproduce
>  # Add stored procedure
>  # Remove stored procedure
>  # Select Undo
>  # Select Redo
> -> Cayenne Modeler error appears
>  
> Log:
>  Apr 14, 2018 7:47:52 AM ERROR: CayenneModeler Error
>  java.lang.NullPointerException
>      at 
> org.apache.cayenne.modeler.action.RemoveAction.removeDataMapFromDataNode(RemoveAction.java:463)
>      at 
> org.apache.cayenne.modeler.undo.RemoveUndoableEdit.redo(RemoveUndoableEdit.java:215)
>      at javax.swing.undo.UndoManager.redoTo(UndoManager.java:351)
>      at javax.swing.undo.UndoManager.redo(UndoManager.java:458)
>      at 
> org.apache.cayenne.modeler.undo.CayenneUndoManager.redo(CayenneUndoManager.java:65)
>      at 
> org.apache.cayenne.modeler.action.RedoAction.performAction(RedoAction.java:65)
>      at 
> org.apache.cayenne.modeler.util.CayenneAction.actionPerformed(CayenneAction.java:171)
>      at 
> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
>      at 
> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
>      at 
> javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
>      at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
>      at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
>      at 
> javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
>      at 
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
>      at java.awt.Component.processMouseEvent(Component.java:6533)
>      at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
>      at java.awt.Component.processEvent(Component.java:6298)
>      at java.awt.Container.processEvent(Container.java:2236)
>      at java.awt.Component.dispatchEventImpl(Component.java:4889)
>      at java.awt.Container.dispatchEventImpl(Container.java:2294)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
>      at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
>      at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
>      at java.awt.Container.dispatchEventImpl(Container.java:2280)
>      at java.awt.Window.dispatchEventImpl(Window.java:2746)
>      at java.awt.Component.dispatchEvent(Component.java:4711)
>      at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
>      at java.awt.EventQueue.access$500(EventQueue.java:97)
>      at java.awt.EventQueue$3.run(EventQueue.java:709)
>      at java.awt.EventQueue$3.run(EventQueue.java:703)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
>      at java.awt.EventQueue$4.run(EventQueue.java:731)
>      at java.awt.EventQueue$4.run(EventQueue.java:729)
>      at java.security.AccessController.doPrivileged(Native Method)
>      at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>      at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
>      at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>      at 
>

[jira] [Updated] (CAY-2424) Migrate DB: error query is not skipped, further excecution is not possible

2018-04-19 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAY-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated CAY-2424:

Labels: pull-request-available  (was: )

> Migrate DB: error query is not skipped, further excecution is not possible
> --
>
> Key: CAY-2424
> URL: https://issues.apache.org/jira/browse/CAY-2424
> Project: Cayenne
>  Issue Type: Bug
>  Components: Modeler
>Affects Versions: 4.0.B3, 4.1.M2
>Reporter: ana benko
>Priority: Major
>  Labels: pull-request-available
> Attachments: c3.png
>
>
> # Reverse Engineer db
>  # Update model, add new db entity
>  # Run Migrate db Schema
>  # Select connection with no DB in url
>  # Select needed db in next popup window
>  # Select required 'To DB' operations, click Migrate
> There are 2 issues:
> -> selected db is not applied to auto_pk_support table creation
> -> error query is not skipped, and further queries are not executed, thus 
> 'awards' table is not created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cayenne pull request #290: CAY-2430

2018-04-19 Thread const1993 
GitHub user const1993 opened a pull request:

https://github.com/apache/cayenne/pull/290

CAY-2430

Fixed NPE on redo delete procedure action.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/const1993/cayenne bugfix/CAY-2430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cayenne/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit cf2a1a060444a3717bf8c8f1d1dee1163e5dbbed
Author: kkomyak 
Date:   2018-04-12T06:20:03Z

CAY-2430

Fixed NPE on redo delete procedure action.




---