[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462638457
 
 
   Trillian test result (tid-3402)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28145 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3171-t3402-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 66 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1517.14 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.05 | test_iso.py
   test_04_extract_template | `Failure` | 1.05 | test_templates.py
   test_06_download_detached_volume | `Failure` | 10.29 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] falcon78921 opened a new pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py

2019-02-11 Thread GitBox
falcon78921 opened a new pull request #3174: scripts/network/ping: cleaned up 
code in baremetal_user_data.py
URL: https://github.com/apache/cloudstack/pull/3174
 
 
   ## Description
   
   
   Cleaned up code in ``baremetal_user_data.py``. Updated string formatting
   to ``str.format()``. Introduced ``pathlib`` as an alternative to ``os.path``.
   
   Signed-off-by: James McClune 
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   Checked the syntax using PythonBuddy. If there are any errors, please let me 
know
   and I'll fix. :)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462525975
 
 
   Trillian test result (tid-3401)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31633 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3166-t3401-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 66 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1519.82 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.08 | test_iso.py
   test_04_extract_template | `Failure` | 1.09 | test_templates.py
   test_06_download_detached_volume | `Failure` | 11.51 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462523001
 
 
   @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462522925
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin
URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462519520
 
 
   Trillian test result (tid-3400)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33878 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3146-t3400-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 65 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1520.08 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.08 | test_iso.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 150.25 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 1.09 | test_templates.py
   test_06_download_detached_volume | `Failure` | 11.45 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462515034
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2607


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462508326
 
 
   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462508072
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3161: Fix behavior of multiselect in list view

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3161: Fix behavior of multiselect in list 
view
URL: https://github.com/apache/cloudstack/pull/3161#issuecomment-462507582
 
 
   @svenvogel The master branch is in freeze state due to the 4.12 releasing 
process. As soon as we have master open for merging we can merge this one. 
Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462499878
 
 
   Trillian test result (tid-3398)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31980 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3171-t3398-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 64 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1519.95 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.11 | test_iso.py
   test_04_extract_template | `Failure` | 1.09 | test_templates.py
   test_06_download_detached_volume | `Failure` | 10.42 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 274.57 | 
test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 4.39 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462491959
 
 
   Trillian test result (tid-3399)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28964 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3170-t3399-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 66 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1524.57 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.15 | test_iso.py
   test_04_extract_template | `Failure` | 1.09 | test_templates.py
   test_06_download_detached_volume | `Failure` | 11.53 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462486369
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2606


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462479558
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462479186
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland removed a comment on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
DaanHoogland removed a comment on issue #3173: Mock Scanner, instead of scan 
the computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462475199
 
 
   @GabrielBrascher I tried your branch and it still doesn't compile:
   ```
   [INFO]
   [INFO] Results:
   [INFO]
   [ERROR] Errors:
   [ERROR]   LibvirtComputingResourceTest.diskUuidToSerialTest:437 » Runtime 
File /proc/mem...
   [ERROR]   
LibvirtComputingResourceTest.testAddExtraConfigComponentEmptyExtraConfig:5235 » 
Runtime
   [ERROR]   
LibvirtComputingResourceTest.testAddExtraConfigComponentNotEmptyExtraConfig:5242
 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpec:324 » Runtime 
File /proc/mem...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecLegacy:224 » 
Runtime File /pr...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecWithTopology4:288 
» Runtime F...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecWithTopology6:256 
» Runtime F...
   [ERROR]   LibvirtComputingResourceTest.testGetVmStat:509 » Runtime File 
/proc/meminfo no...
   [ERROR]   LibvirtComputingResourceTest.testIsInterface:5118 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtComputingResourceTest.testKnownCommand:5222 » Runtime File 
/proc/meminf...
   [ERROR]   
LibvirtComputingResourceTest.testMemoryFreeInKBsDomainReturningNoMemoryStatistics:5149
 » Runtime
   [ERROR]   
LibvirtComputingResourceTest.testMemoryFreeInKBsDomainReturningOfSomeMemoryStatistics:5138
 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testSetQuotaAndPeriod:5178 » Runtime 
File /proc/m...
   [ERROR]   LibvirtComputingResourceTest.testSetQuotaAndPeriodMinQuota:5202 » 
Runtime File...
   [ERROR]   
LibvirtComputingResourceTest.testSetQuotaAndPeriodNoCpuLimitUse:5190 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testUUID:444 » Runtime File 
/proc/meminfo not fou...
   [ERROR]   LibvirtComputingResourceTest.testUnknownCommand:5210 » Runtime 
File /proc/memi...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   
LibvirtMigrateCommandWrapperTest.deleteOrDisconnectDisksOnSourcePoolTest:410 » 
Runtime
   [ERROR]   LibvirtMigrateCommandWrapperTest.testMigrationUri:333 » Runtime 
File /proc/mem...
   [ERROR]   LibvirtMigrateCommandWrapperTest.testMigrationUriException »  
Unexpected excep...
   [ERROR]   LibvirtNetworkElementCommandWrapperTest.setUp:217 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtNetworkElementCommandWrapperTest.setUp:217 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtReplugNicCommandWrapperTest.setUp:189 » Runtime File 
/proc/meminfo not ...
   [ERROR]   MemStatTest.getMemInfoParseTest:43 » Runtime File /proc/meminfo 
not found:java...
   [INFO]
   [ERROR] Tests run: 214, Failures: 0, Errors: 31, Skipped: 2
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462475199
 
 
   @GabrielBrascher I tried your branch and it still doesn't compile:
   ```
   [INFO]
   [INFO] Results:
   [INFO]
   [ERROR] Errors:
   [ERROR]   LibvirtComputingResourceTest.diskUuidToSerialTest:437 » Runtime 
File /proc/mem...
   [ERROR]   
LibvirtComputingResourceTest.testAddExtraConfigComponentEmptyExtraConfig:5235 » 
Runtime
   [ERROR]   
LibvirtComputingResourceTest.testAddExtraConfigComponentNotEmptyExtraConfig:5242
 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpec:324 » Runtime 
File /proc/mem...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecLegacy:224 » 
Runtime File /pr...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecWithTopology4:288 
» Runtime F...
   [ERROR]   LibvirtComputingResourceTest.testCreateVMFromSpecWithTopology6:256 
» Runtime F...
   [ERROR]   LibvirtComputingResourceTest.testGetVmStat:509 » Runtime File 
/proc/meminfo no...
   [ERROR]   LibvirtComputingResourceTest.testIsInterface:5118 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtComputingResourceTest.testKnownCommand:5222 » Runtime File 
/proc/meminf...
   [ERROR]   
LibvirtComputingResourceTest.testMemoryFreeInKBsDomainReturningNoMemoryStatistics:5149
 » Runtime
   [ERROR]   
LibvirtComputingResourceTest.testMemoryFreeInKBsDomainReturningOfSomeMemoryStatistics:5138
 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testSetQuotaAndPeriod:5178 » Runtime 
File /proc/m...
   [ERROR]   LibvirtComputingResourceTest.testSetQuotaAndPeriodMinQuota:5202 » 
Runtime File...
   [ERROR]   
LibvirtComputingResourceTest.testSetQuotaAndPeriodNoCpuLimitUse:5190 » Runtime
   [ERROR]   LibvirtComputingResourceTest.testUUID:444 » Runtime File 
/proc/meminfo not fou...
   [ERROR]   LibvirtComputingResourceTest.testUnknownCommand:5210 » Runtime 
File /proc/memi...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   LibvirtVifDriverTest.setUp:54 » Runtime File /proc/meminfo not 
found:java.io.F...
   [ERROR]   
LibvirtMigrateCommandWrapperTest.deleteOrDisconnectDisksOnSourcePoolTest:410 » 
Runtime
   [ERROR]   LibvirtMigrateCommandWrapperTest.testMigrationUri:333 » Runtime 
File /proc/mem...
   [ERROR]   LibvirtMigrateCommandWrapperTest.testMigrationUriException »  
Unexpected excep...
   [ERROR]   LibvirtNetworkElementCommandWrapperTest.setUp:217 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtNetworkElementCommandWrapperTest.setUp:217 » Runtime File 
/proc/meminfo...
   [ERROR]   LibvirtReplugNicCommandWrapperTest.setUp:189 » Runtime File 
/proc/meminfo not ...
   [ERROR]   MemStatTest.getMemInfoParseTest:43 » Runtime File /proc/meminfo 
not found:java...
   [INFO]
   [ERROR] Tests run: 214, Failures: 0, Errors: 31, Skipped: 2
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] svenvogel commented on issue #3161: Fix behavior of multiselect in list view

2019-02-11 Thread GitBox
svenvogel commented on issue #3161: Fix behavior of multiselect in list view
URL: https://github.com/apache/cloudstack/pull/3161#issuecomment-462473528
 
 
   @rhtyd can we merge it? can you have a look?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462439520
 
 
   still getting failures, but in a new place.  I've attached logs
   
   
[mac_test_fail.tar.gz](https://github.com/apache/cloudstack/files/2852491/mac_test_fail.tar.gz)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462429480
 
 
   Updated the code with a _setup_ method and removed a variable that I left 
without mocking. Thanks for testing @nathanejohnson. Could you please test it 
again to make sure that it has been fixed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nathanejohnson edited a comment on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson edited a comment on issue #3173: Mock Scanner, instead of scan 
the computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462425427
 
 
   Still getting failures on mac:
   
   ```
 
   java.lang.RuntimeException: File 
/proc/meminfo not found:java.io.FileNotFoundException: /proc/meminfo (No such 
file or directory)
   at 
org.apache.cloudstack.utils.linux.MemStatTest.getMemInfoParseTest(MemStatTest.java:43)
   
 
   ```
   
   
[mac_mem_test_fail.tar.gz](https://github.com/apache/cloudstack/files/2852307/mac_mem_test_fail.tar.gz)
   
   
   ```
   (njohnson@greyeagle:~/src/cloudstack)$ git branch
 master
   * test-running-only-on-linux
   (njohnson@greyeagle:~/src/cloudstack)$ git remote -v
   origin   https://github.com/PCextreme/cloudstack.git (fetch)
   origin   https://github.com/PCextreme/cloudstack.git (push)
   (njohnson@greyeagle:~/src/cloudstack)$ 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462425427
 
 
   Still getting failures on mac:
   
   ```
 
   java.lang.RuntimeException: File 
/proc/meminfo not found:java.io.FileNotFoundException: /proc/meminfo (No such 
file or directory)
   at 
org.apache.cloudstack.utils.linux.MemStatTest.getMemInfoParseTest(MemStatTest.java:43)
   
 
   ```
   
   
[mac_mem_test_fail.tar.gz](https://github.com/apache/cloudstack/files/2852307/mac_mem_test_fail.tar.gz)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462420138
 
 
   Ping for review @kiwiflyer @nathanejohnson @DaanHoogland and others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a 
local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255531228
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +71,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new 
NotImplementedProvisioningTypeException(String.format("type {} not defined as 
member-value of PreallocationType", provisioningType));
 
 Review comment:
   hm, i might be mixing python and java, will check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-11 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-462337097
 
 
   framework/managed-context uses slf4j and is not dependend on utils. This 
needs to be solved by
   1. isolating logging in its own project and make it second to checkstyle
   1. exclude managed context from the standard use of logging


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher opened a new pull request #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher opened a new pull request #3173: Mock Scanner, instead of scan 
the computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173
 
 
   This allows computers with Windows or MacOS to run the tests without 
scanning for `/proc/meminfo` path.
   
   At the class 
[MemStat.java](https://github.com/apache/cloudstack/blob/c496c84c6c727a84862cbbe2d870ff57939488b4/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/MemStat.java#L71),
 the `refresh()` method (called in MemStat constructor) has the following lines:
   
   ```
   public void refresh() {
   File f = new File(MEMINFO_FILE);
   try (Scanner scanner = new Scanner(f,"UTF-8")) {
   parseFromScanner(scanner);
   } catch (FileNotFoundException ex) {
   throw new RuntimeException("File " + MEMINFO_FILE + " not 
found:" + ex.toString());
   }
   }
   ```
   When executing `Scanner scanner = new Scanner(f,"UTF-8")` it scans the file 
_MEMINFO_FILE_ (`/proc/meminfo`); however, if the OS running this test is not a 
Linux then it throws `FileNotFoundException`, failing the test.
   
   Thus, by Mocking the Scanner constructor, the `new Scanner(f,"UTF-8")` 
execution returns the desired Scanner.
   
   ## Description
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov opened a new issue #3172: java download client - unable to download/register when there's a trusted ssl connection

2019-02-11 Thread GitBox
borisstoyanov opened a new issue #3172: java download client - unable to 
download/register when there's a trusted ssl connection 
URL: https://github.com/apache/cloudstack/issues/3172
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   SSVM
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11
   ~~~
   
   # CONFIGURATION
   
   Setup a valid/trusted ssl certificate for the ssvm 
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   test_templates:test_04_extract_template
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   Test would pass
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   Fails with the following: 
   `2019-02-11 10:57:22,658 - CRITICAL - FAILED: test_04_extract_template: 
['Traceback (most recent call last):\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', 
'  File "/marvin/tests/smoke/test_templates.py", line 778, in 
test_04_extract_template\n% (formatted_url, self.template_2.id)\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 450, in fail\nraise 
self.failureException(msg)\n', 'AssertionError: Extract Template Failed with 
invalid URL 
https://10-1-35-4.sbcloud.uk/userdata/e60c42e1-43b3-422d-936d-1dbe4c7b2c61.qcow2
 (template id: 9fc2d490-bec5-4f3d-b9ff-046be227f037)\n']`
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462327044
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462327130
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
rafaelweingartner commented on a change in pull request #3170: NotImplemented 
as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255496880
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +71,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new 
NotImplementedProvisioningTypeException(String.format("type {} not defined as 
member-value of PreallocationType", provisioningType));
 
 Review comment:
   Is this a new type of `String.format` use? I am missing a `%s` there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a 
local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255496081
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -399,4 +397,9 @@ public void resize(final QemuImgFile file, final long 
size, final boolean delta)
 public void resize(final QemuImgFile file, final long size) throws 
QemuImgException {
 this.resize(file, size, false);
 }
+
+static class NotImplementedProvisioningTypeException extends 
RuntimeException {
+}
 }
+
+;
 
 Review comment:
   of course, sorry


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462315777
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2605


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nvazquez commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
nvazquez commented on a change in pull request #3170: NotImplemented as a local 
exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255490327
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -399,4 +397,9 @@ public void resize(final QemuImgFile file, final long 
size, final boolean delta)
 public void resize(final QemuImgFile file, final long size) throws 
QemuImgException {
 this.resize(file, size, false);
 }
+
+static class NotImplementedProvisioningTypeException extends 
RuntimeException {
+}
 }
+
+;
 
 Review comment:
   Can this be removed please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nvazquez commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
nvazquez commented on a change in pull request #3170: NotImplemented as a local 
exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255489681
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   Agree :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a 
local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255488013
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   check


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin
URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462310748
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3146: RIP Nuage Cloudstack Plugin
URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462310659
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462310240
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462310233
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462310179
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462310007
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
rafaelweingartner commented on a change in pull request #3170: NotImplemented 
as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255483128
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   It also works. I only think that we need to add something in the exception. 
I mean, a message saying what is not implemented (the preallocation type 
selected/sent by the user).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a 
local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255481242
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   That is certainly an option, @rafaelweingartner . I had discussed with 
@nvazquez and he suggested the commons-lang NotImplementedException as it is 
loaded through the storage module anyhow. Thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462304132
 
 
   @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462304083
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462293752
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2604


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ustcweizhou commented on issue #3048: Copy template/iso tags into VM

2019-02-11 Thread GitBox
ustcweizhou commented on issue #3048: Copy template/iso tags into VM
URL: https://github.com/apache/cloudstack/issues/3048#issuecomment-462290963
 
 
   @bwsw @anuragaw 
   I do not understand what's the proposal of this request.
   in my opinion, templete/iso tag should be taken into consideration when 
deploy/start/migrate a vm. for now, it is not working well in cloudstack. we 
can fix the issues instead of copying the tags into vm attributes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462288551
 
 
   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462288432
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML 
after live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462281826
 
 
   Trillian test result (tid-3397)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32920 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3171-t3397-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 66 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1519.22 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.09 | test_iso.py
   test_04_extract_template | `Failure` | 1.08 | test_templates.py
   test_06_download_detached_volume | `Failure` | 11.46 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ustcweizhou commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
ustcweizhou commented on issue #3171: Keep iotune section in the VM's XML after 
live migration
URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462279056
 
 
   code LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services