[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472238769
 
 
   Trillian test result (tid-3419)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23399 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3210-t3419-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 68 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472114945
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472114567
 
 
   @GabrielBrascher okay I'll move that to logging tomorrow.
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher closed pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
GabrielBrascher closed pull request #3207: Fix #3203 usage server broken in 
4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3207: Fix #3203 usage server broken in 
4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-472093475
 
 
   Closing this in favor of #3210


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] onitake opened a new issue #3221: Proposal: Specify INVOKER security on table views to avoid DB user dependency

2019-03-12 Thread GitBox
onitake opened a new issue #3221: Proposal: Specify INVOKER security on table 
views to avoid DB user dependency
URL: https://github.com/apache/cloudstack/issues/3221
 
 
   
   
   # ISSUE TYPE
   
* Improvement Request
   
   # COMPONENT NAME
   
   ~~~
   DB
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11.2
   ~~~
   
   # CONFIGURATION
   
   N/A
   
   # OS / ENVIRONMENT
   
   MySQL 5.5 (later versions have the same issue)
   
   # SUMMARY
   
   According to 
https://dev.mysql.com/doc/refman/5.5/en/stored-programs-security.html , views 
on MySQL are created with SQL SECURITY DEFINER and the creator's user account 
as DEFINER by default.
   
   This causes problems when changing database access control or migrating the 
database, as the user (which includes a host name suffix) may no longer exist.
   
   Since there is no specific definition of security in the CloudStack database 
schema, I propose that views are created with SQL SECURITY INVOKER instead, as 
that would adopt the grants of the user executing the query on view.
   
   # STEPS TO REPRODUCE
   
   On a database server with a user `cloud@localhost` but no user `cloud@%`, 
import a database dump from a server that had such a user:
   
   
   ~~~
   zcat cloud.sql.gz | mysql -u cloud cloud
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   No error is reported.
   
   # ACTUAL RESULTS
   
   The import fails because setting the DEFINER to a different user than the 
one creating it requires superuser privileges.
   
   
   ~~~
   ERROR 1227 (42000) at line : Access denied; you need (at least one of) 
the SUPER privilege(s) for this operation
   
   : /*!50013 DEFINER=`cloud`@`%` SQL SECURITY DEFINER */
   ~~~
   
   # WORKAROUND
   There are two possible workarounds.
   
   Export the database with `mysqlpump` and specify `--skip-definer` (requires 
MySQL 5.7):
   ~~~
   mysqlpump --skip-definer -h old-server -u cloud -p cloud | gzip -c > 
cloud.sql.gz
   ~~~
   
   Or remove the lines from the dump during import:
   ~~~
   zcat cloud.sql.gz | grep -v "50013 DEFINER" | mysql -u cloud cloud
   ~~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
blueorangutan commented on issue #3209: server: make snapshotting on KVM 
non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-472017557
 
 
   Trillian test result (tid-3417)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 24373 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3209-t3417-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 69 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.66 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472008746
 
 
   Trillian test result (tid-3418)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22699 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3210-t3418-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Smoke tests completed. 68 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
blueorangutan commented on issue #3220: ui: allow user template sharing through 
UI
URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-472000124
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2629


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
blueorangutan commented on issue #3220: ui: allow user template sharing through 
UI
URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-471992436
 
 
   @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] dhlaluku commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
dhlaluku commented on issue #3220: ui: allow user template sharing through UI
URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-471992282
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] dhlaluku opened a new pull request #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
dhlaluku opened a new pull request #3220: ui: allow user template sharing 
through UI
URL: https://github.com/apache/cloudstack/pull/3220
 
 
   updateTemplate permissions API
   
   ## Description
   
   UI integration of the updateTemplatePermissions API. This will allow users 
to share templates.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rafaelweingartner commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
rafaelweingartner commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471986861
 
 
   @DaanHoogland I selected the wrong label. Thanks Daan.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
DaanHoogland commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471986489
 
 
   @NicoWohlfarth Can you explain what these pictures are making clear? not all 
of them are selfevident.
   @rafaelweingartner aren't these bugfixes, instead of enhancements?
   LGTM overall, thanks @NicoWohlfarth .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing 
to systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471977036
 
 
   @rhtyd it looks good. Thanks!
   
   Can you please also remove the lines that are silencing the exception? I 
don't see any reason for print on the stack trace (console) the exceptions.
   
https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/usage/src/main/java/com/cloud/usage/UsageServer.java#L54
   
   ```
   } catch (Exception e) {
   e.printStackTrace();
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471977036
 
 
   @rhtyd it looks good. Thanks!
   
   Can you please also remove the lines that are silencing the exception?
   
https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/usage/src/main/java/com/cloud/usage/UsageServer.java#L54
   
   ```
   } catch (Exception e) {
   e.printStackTrace();
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471973804
 
 
   Cool - let's LGTM this one and close if you are OK with it @GabrielBrascher  
?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471973377
 
 
   @rhtyd @andrijapanic nevermind, my mistake when updating the script at this 
time. Due to the /bin/sh -ec '' it works now. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471972723
 
 
   yes, Centos7
   let me build Ubuntu lab - 18.04 sounds fine ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471972171
 
 
   @rhtyd @andrijapanic are you testing it with CentOS? On Ubuntu I still get 
error. Now the exception is: `java.lang.NumberFormatException: For input 
string: "$$"`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471961003
 
 
   LGTM
   
   Tested and the job does kick in as expected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3207: Fix #3203 usage server broken in 
4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-471960744
 
 
   I did not review this one (test it), but already had env for 
https://github.com/apache/cloudstack/pull/3210 and confirm it works fine - 
usage jobs does kick in as it should.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471950676
 
 
   https://user-images.githubusercontent.com/5433844/54194494-ae47eb00-44bc-11e9-9e9b-3d96ed082a7d.png;>
   
   
![fix4](https://user-images.githubusercontent.com/5433844/54194535-c15abb00-44bc-11e9-92b2-add42f499625.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
rhtyd commented on issue #3211: ui: remove CA certificate button from UI
URL: https://github.com/apache/cloudstack/pull/3211#issuecomment-471949805
 
 
   @svenvogel in 4.11+ if you notice there is a button on right/top side that 
downloads the CA certificate. This is not used at all and confuses 
users/admins. This removes it. The original use-case was something to do with 
cert setup, but that never got implemented. We may put it back if we do that in 
future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471949268
 
 
   https://user-images.githubusercontent.com/5433844/54194297-2e218580-44bc-11e9-8f65-3bf176459d6c.png;>
   
   
![fix3](https://user-images.githubusercontent.com/5433844/54194314-3aa5de00-44bc-11e9-9c7e-2c02c10003ae.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel edited a comment on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel edited a comment on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471948361
 
 
   this pr fixes the following problems.
   
   https://user-images.githubusercontent.com/5433844/54194040-a0459a80-44bb-11e9-9b24-aeb89541a6b6.png;>
   
   
![image](https://user-images.githubusercontent.com/5433844/54194135-d3882980-44bb-11e9-8384-be2fc6642c08.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471948361
 
 
   this pr fixes the following problems.
   
   https://user-images.githubusercontent.com/5433844/54194040-a0459a80-44bb-11e9-9b24-aeb89541a6b6.png;>
   
![image](https://user-images.githubusercontent.com/5433844/54194135-d3882980-44bb-11e9-8384-be2fc6642c08.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
svenvogel commented on issue #3211: ui: remove CA certificate button from UI
URL: https://github.com/apache/cloudstack/pull/3211#issuecomment-471947467
 
 
   @rhtyd what was the use case before?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3219: server: publish volume resize event for volumes

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3219: server: publish volume resize event for 
volumes
URL: https://github.com/apache/cloudstack/pull/3219
 
 
   This fixes the issue that the disk offering change is not reflected in
   the cloud_usage table.
   
   Moves the method that published events for volumes in Ready state from
   the VolumeStateListener class to the orchestrateResizeVolume method in
   the VolumeApiService.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update
URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471945164
 
 
   @wido @GabrielBrascher @borisstoyanov @rhtyd @rafaelweingartner can anybody 
add a ui symbol and review it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3218: vmware: don't use redundant worker VM to extract volume

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3218: vmware: don't use redundant worker VM to 
extract volume
URL: https://github.com/apache/cloudstack/pull/3218
 
 
   This fixes the issue that VM with VMsnapshots fails to start after
   extract volume is done on a stopped VM, on VMware.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for NIC

2019-03-12 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-471943632
 
 
   @wido can you check again?
   @rhtyd @borisstoyanov @rafaelweingartner can you check this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3198: Set service offering unique name over api and gui

2019-03-12 Thread GitBox
svenvogel commented on issue #3198: Set service offering unique name over api 
and gui
URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-471943215
 
 
   @rhtyd @GabrielBrascher @rafaelweingartner @borisroman can you add a ui icon 
and check these?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3217: ui: introduce new UI config file

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3217: ui: introduce new UI config file
URL: https://github.com/apache/cloudstack/pull/3217
 
 
   This introduces a new UI `config.js` file using which the UI could be
   configured by the admin from a single config/js file.
   
   In the first commit this allows for easy configuration of list of
   keyboards.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3216: api: include tags in listvmsnapshots response

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3216: api: include tags in listvmsnapshots 
response
URL: https://github.com/apache/cloudstack/pull/3216
 
 
   This ensures that tags of a VM snapshot are listed in the UI, available
   in the list vmsnapshots API response.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3215: storage: post process locally uploaded multi-disk ova template

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3215: storage: post process locally uploaded 
multi-disk ova template
URL: https://github.com/apache/cloudstack/pull/3215
 
 
   This processes and handles multi-disk ova templates, checks and creates
   data disk templates on image storage pool and in DB.
   
   Test cases:
   - Upload template and check it creates multi-disk folders on secondary
 storage and entries in cloud.vm_template table
   - Upload template and kill/shutdown management server. Then restart MS
 to check if template sync works
   - Copy template across zone of an uploaded template
   
   Signed-off-by: Rohit Yadav 
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471933312
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2628


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3214: ui: use executable template filter for users

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3214: ui: use executable template filter for 
users
URL: https://github.com/apache/cloudstack/pull/3214
 
 
   This uses the `executable` tempalte filter for fetching templates in
   reinstall VM form, otherwise not all allowable templates were being
   listed.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3213: server: allow admins to blacklist vm details that users should not see

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3213: server: allow admins to blacklist vm 
details that users should not see
URL: https://github.com/apache/cloudstack/pull/3213
 
 
   This introduces a new global setting `user.vm.blacklisted.details` that
   allows admins to blacklist VM details that non-admin users should not
   see via the VM's settings tab.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471925386
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471925187
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471920817
 
 
   @GabrielBrascher fixed the issue, it was systemd variable referencing/syntax 
issue which per following docs should be `${VAR}` instead of `$VAR`:
   
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines
   
   After my last commit, it's working again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3210: systemd: Fix -Dpid arg 
passing to systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#discussion_r264584537
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.service
 ##
 @@ -24,7 +24,8 @@ After=network.target network-online.target
 [Service]
 Type=simple
 EnvironmentFile=/etc/default/cloudstack-usage
-ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS
+Environment=JAVA_PID=$$
 
 Review comment:
   @GabrielBrascher @andrijapanic moved the JAVA_PID here so users can't 
change/mess it around. The systemd variable referencing is limiting, the fix 
was to use the `${VAR}` syntax and not `$VAR` syntax. Can you believe it! 
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
blueorangutan commented on issue #3207: Fix #3203 usage server broken in 
4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-471903860
 
 
   Trillian test result (tid-3416)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28344 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3207-t3416-kvm-centos7.zip
   Smoke tests completed. 70 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3212: storage: publish delete usage event for snapshot deletion

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3212: storage: publish delete usage event for 
snapshot deletion
URL: https://github.com/apache/cloudstack/pull/3212
 
 
   This publishes VM snapshot delete event after a snapshot is removed,
   this will ensure that usage records are not generated for deleted
   snapshots.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3211: ui: remove CA certificate button from UI
URL: https://github.com/apache/cloudstack/pull/3211
 
 
   This removes CA certificate button from UI as this is not used and
   confuses both admin and users how to use it. This may be re-introduced
   in future when a use-case can be justified.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471878789
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471878493
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471877933
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2627


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
blueorangutan commented on issue #3209: server: make snapshotting on KVM 
non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-471877931
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
rhtyd commented on issue #3209: server: make snapshotting on KVM non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-471877707
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
blueorangutan commented on issue #3209: server: make snapshotting on KVM 
non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-471874848
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2626


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database

2019-03-12 Thread GitBox
rhtyd commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on 
CloudStack database
URL: https://github.com/apache/cloudstack/pull/2479#issuecomment-471874000
 
 
   Nice, looks like many more changes. @ustcweizhou do you intend to get 
cloudstack completely move to flyway in next major/lts 4.13 release? If so, 
please start a discussion on dev list, I would like to engage and discuss both 
upgrade and migration paths from old system to new system. cc @PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3205: server: update dhcp configurations in vrs while update default nic of running vms

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3205: server: update dhcp 
configurations in vrs while update default nic of running vms
URL: https://github.com/apache/cloudstack/pull/3205#discussion_r264535778
 
 

 ##
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -1448,6 +1448,19 @@ public UserVm 
updateDefaultNicForVirtualMachine(UpdateDefaultNicForVMCmd cmd) th
 newNetworkOfferingId, null, 0L, 
VirtualMachine.class.getName(), vmInstance.getUuid(), vmInstance.isDisplay());
 
UsageEventUtils.publishUsageEvent(EventTypes.EVENT_NETWORK_OFFERING_ASSIGN, 
vmInstance.getAccountId(), vmInstance.getDataCenterId(), vmInstance.getId(),
 oldNicIdString, oldNetworkOfferingId, null, 0L, 
VirtualMachine.class.getName(), vmInstance.getUuid(), vmInstance.isDisplay());
+
+if (vmInstance.getState() != State.Stopped) {
+try {
+VirtualMachineProfile vmProfile = new 
VirtualMachineProfileImpl(vmInstance);
+User callerUser = 
_accountMgr.getActiveUser(CallContext.current().getCallingUserId());
+ReservationContext context = new 
ReservationContextImpl(null, null, callerUser, caller);
+DeployDestination dest = new DeployDestination(dc, null, 
null, null);
+_networkMgr.prepare(vmProfile, dest, context);
+} catch (final Exception e) {
+s_logger.info("Got exception: ", e);
 
 Review comment:
   Can you fix and elaborate the exception. And should we be doing 
network-manager.prepare()? Will this remove old configuration (all metadata and 
config) for the VM? Should we check for vm state to be running instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471873064
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-471873002
 
 
   Please review/test - https://github.com/apache/cloudstack/pull/3210


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471872901
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage 
service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471872867
 
 
   cc @andrijapanic  @PaulAngus @ustcweizhou 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3210: systemd: Fix -Dpid arg passing to 
systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210
 
 
   This fixes regression introduced by refactoring PR #3163 where `-Dpid`
   was incorrectly passed string `$$` instead of parent PID integer.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3207: Fix #3203 usage server 
broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533511
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.default
 ##
 @@ -15,8 +15,18 @@
 # specific language governing permissions and limitations
 # under the License.
 
-JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m"
 
 Review comment:
   Btw, this without quotes would work


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3207: Fix #3203 usage server 
broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533385
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.service
 ##
 @@ -24,7 +24,9 @@ After=network.target network-online.target
 [Service]
 Type=simple
 EnvironmentFile=/etc/default/cloudstack-usage
-ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS
 
 Review comment:
   Comment: this would need to be fixed for 4.11 as well, let me send a quick 
fix instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3207: Fix #3203 usage server 
broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533298
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.service
 ##
 @@ -24,7 +24,9 @@ After=network.target network-online.target
 [Service]
 Type=simple
 EnvironmentFile=/etc/default/cloudstack-usage
-ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS
 
 Review comment:
   Put this and this would fix the pid issue:
   ```
   Environment=JAVA_PID=$$
   ExecStart=/usr/bin/java $JAVA_DEBUG -Dpid=$JAVA_PID $JAVA_OPTS -cp 
$CLASSPATH $JAVA_CLASS
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3207: Fix #3203 usage server 
broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533039
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.default
 ##
 @@ -15,8 +15,18 @@
 # specific language governing permissions and limitations
 # under the License.
 
-JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m"
 
 Review comment:
   Nevermind, re-read the description. Alright keep this change, I'll advise 
you a simpler fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3207: Fix #3203 usage server 
broken in 4.11/4.12
URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264532941
 
 

 ##
 File path: packaging/systemd/cloudstack-usage.default
 ##
 @@ -15,8 +15,18 @@
 # specific language governing permissions and limitations
 # under the License.
 
-JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m"
 
 Review comment:
   @GabrielBrascher What's the issue, this should work? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
blueorangutan commented on issue #3209: server: make snapshotting on KVM 
non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-471870103
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
rhtyd commented on issue #3209: server: make snapshotting on KVM non-blocking
URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-471869962
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services