[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101965 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke

[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101888 @blueorangutan test centos7 vmware-55u3

[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299101715 Hi @jayapalu, sorry for the delay, we're using port 8096 in the config file and no API keys are configured in the cfg

[GitHub] sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management serve

2017-05-03 Thread git
sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. URL: https://github.com/apache/cloudstack/pull/1875#issuecomment-299101726 The above

[GitHub] sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2017-05-03 Thread git
sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-299100369 >Can we remove the config param

[GitHub] sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.

2017-05-03 Thread git
sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. URL: https://github.com/apache/cloudstack/pull/1878#issuecomment-299098640 @sureshanaparti LGTM code change, please incorporate changes suggested by

[GitHub] abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-299088351 LGTM, on code review. This is

[GitHub] leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-05-03 Thread git
leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-299039096 @rossor @nathanejohnson Can we get the code formatted correctly so the tests pass?

[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298992375 Trillian test result (tid-1055) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31904

[GitHub] kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced

2017-05-03 Thread git
kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-298962214 @rhtyd Can we create a jira issue for this? This is an

[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-05-03 Thread git
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645 Simple fix for log consistency. LGTM This is an

[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-05-03 Thread git
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645 Simple fix for log consistency. LGTM This is an

[GitHub] rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface

2017-05-03 Thread git
rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface URL: https://github.com/apache/cloudstack/pull/1908#issuecomment-298896670 Disable static NAT working fine, IP's are leaving interface as soon as they are disabled. ![screenshot

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298893728 @borisstoyanov In marvin config with port 8080 and without keys, Is this valid configuration test ? Because with port 8080

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298597383 @borisstoyanov Can you upload the your "mgtSvr" from the .cfg. I am getting the error when port is 8080 and apikey and

[GitHub] DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29382 LGTM, I already approved but since we have this string in our policy... ;)

[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29353 Thanks @rashmidixit for reviewing This is

[GitHub] yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible

2017-05-03 Thread git
yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible URL: https://github.com/apache/cloudstack/pull/2047#issuecomment-298885131 @ustcweizhou LGTM for the code I have updated my PR to make use of this fix

[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-298873490 few of the cleanup of test cases are failing and these are not related my changes. @borisstoyanov Can

[GitHub] rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298867373 LGTM This is an automated message

[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298866549 @DaanHoogland fixed thanks This is an

[GitHub] karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-03 Thread git
karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string URL: https://github.com/apache/cloudstack/pull/927#issuecomment-298863250 update the PR with testcase fix

[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862135 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862111 @blueorangutan test This is an automated message from the Apache Git

[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114501952 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114502094 ## File path:

[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298854263 Screenshots: ![screenshot from 2017-05-03

[GitHub] rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075 HostStats returns cpu usage in percentage while memory usage in bytes. This fixes a regression in maximum CPU usage