[GitHub] niteshsarda commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

2017-09-20 Thread git
niteshsarda commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-331066581 LGTM for code. This is an automated message fro

[GitHub] vedulasantosh commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-09-20 Thread git
vedulasantosh commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#discussion_r140154390 ## File path: systemvm/js/jquery.flot.navigate.js ## @@ -0,0 +1,336 @

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-09-20 Thread git
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-331055575 Thanks @resmo, test LGTM, additional code review is requested after which this can be merged

[GitHub] blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-331054301 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-331054196 @blueorangutan test This is an automated messa

[cloudstack] branch master updated: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry for disabled host (#876)

2017-09-20 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c670691 CLOUDSTACK-8865: Adding SR doesn'

[GitHub] rhtyd closed pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
rhtyd closed pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-331053657 Okay test LGTM, give this has enough code review/LGTM from others I'll merge this. Thanks. -

[GitHub] SudharmaJain opened a new pull request #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

2017-09-20 Thread git
SudharmaJain opened a new pull request #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271 ?s https ca certificates were missing in realhostip.keystore. Before adding the fix while registering the te

[GitHub] blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-331048988 Trillian test result (tid-1534) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330977316 Trillian test result (tid-1533) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] niteshsarda opened a new pull request #2270: CLOUDSTACK-10085 : Upload volume from local fails when global config max.account.seconday.storage is set to -1

2017-09-20 Thread git
niteshsarda opened a new pull request #2270: CLOUDSTACK-10085 : Upload volume from local fails when global config max.account.seconday.storage is set to -1 URL: https://github.com/apache/cloudstack/pull/2270 **ISSUE** Upload volume from local fails when global config max.account.sec

[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-09-20 Thread git
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969 ## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ## @@ -1054,8 +1

[GitHub] resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-09-20 Thread git
resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-330830509 travis build error looks unrelated to me. Trilian test failure, AFAICS, are also unrelated.

[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-09-20 Thread git
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969 ## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ## @@ -1054,8 +1

[GitHub] blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330824608 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-330824619 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330824520 @blueorangutan test This is an automated message

[GitHub] rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-330824426 @blueorangutan test This is an automated messa

[GitHub] blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-330823347 Packaging result: ?centos6 ?centos7 ?debian. JID-1108 -

[GitHub] blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330822931 Packaging result: ?centos6 ?centos7 ?debian. JID-1107 ---

[GitHub] rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
rhtyd commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-330817016 LGTM @blueorangutan package This is an auto

[GitHub] blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-20 Thread git
blueorangutan commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-330817093 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rhtyd closed pull request #1252: CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance.

2017-09-20 Thread git
rhtyd closed pull request #1252: CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance. URL: https://github.com/apache/cloudstack/pull/1252 This is

[GitHub] rhtyd commented on issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance.

2017-09-20 Thread git
rhtyd commented on issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance. URL: https://github.com/apache/cloudstack/pull/1252#issuecomment-330816775 Tests LGTM, merging. --

[cloudstack] branch master updated: CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance. (#1252)

2017-09-20 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new f2584bb CLOUDSTACK-9182: Some running VMs

[GitHub] rhtyd commented on a change in pull request #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-09-20 Thread git
rhtyd commented on a change in pull request #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#discussion_r139936130 ## File path: test/integration/testpaths/Upload_Volume_test_case.py ##

[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-20 Thread git
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-330816426 LGTM, @DaanHoogland @borisstoyanov advise if we're happy with the PR. I'll merge on your confirmation. -

[GitHub] blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
blueorangutan commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330816255 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-09-20 Thread git
rhtyd commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-330816085 @SudharmaJain I can rekick the tests, will rebuild packages as well @blueorangutan package ---

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-20 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330815965 @borisstoyanov can you check failures related to libvirt tests on kvm/centos6, however those failures are not seen in kvm/centos7?

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-09-20 Thread git
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-330815830 Additional code review requested and please also see Travis failures. -

[GitHub] rhtyd commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-09-20 Thread git
rhtyd commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139935400 ## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ## @@ -1054,8 +1054,6

[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-09-20 Thread git
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139921404 ## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ## @@ -1054,8 +1