[GitHub] resmo commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

resmo commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i? URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-343399473 Related https://issues.apache.org/jira/browse/CLOUDSTACK-10043 we are verifying

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-343376245 tag:This is Ready to Merge This

[GitHub] yvsubhash commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

yvsubhash commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-343375522 LGTM for code This is an automated message

[GitHub] rafaelweingartner opened a new pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

rafaelweingartner opened a new pull request #2315: A comprehensive solution for #CLOUDSTACK-9025. URL: https://github.com/apache/cloudstack/pull/2315 The first PR(#1176) intended to solve #CLOUDSTACK-9025 was only tackling the problem for CloudStack deployments that use single hypervisor

[GitHub] blueorangutan commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

blueorangutan commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-343221894 Packaging result: ?centos6 ?centos7 ?debian. JID-1237

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-343220616 @svenvogel Frank asked if we've a 4.9 baseline to compare against, I closed the last 4.9 smoketests PR #2217

[GitHub] blueorangutan commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped

blueorangutan commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped URL: https://github.com/apache/cloudstack/pull/2308#issuecomment-343218896 Packaging result: ?centos6 ?centos7 ?debian. JID-1235

[GitHub] svenvogel commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

svenvogel commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-343214212 @rhtyd Close the old PR? Which one is the old one?

[GitHub] blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i? URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-343212053 Packaging result: ?centos6 ?centos7 ?debian. JID-1234

[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-343212003 Packaging result: ?centos6 ?centos7 ?debian. JID-1233

[GitHub] blueorangutan commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system

blueorangutan commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system URL: https://github.com/apache/cloudstack/pull/2310#issuecomment-343211266 Packaging result: ?centos6 ?centos7 ?debian. JID-1232

[GitHub] rhtyd commented on issue #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5

rhtyd commented on issue #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5 URL: https://github.com/apache/cloudstack/pull/2050#issuecomment-343204057 @pdion891 please fix conflicts and move changes to 4.10->4.11 sql

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-343203650 @pavanaravapalli please fix the conflicts

[cloudstack] branch master updated: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway (#2157)

This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 4af82bb CLOUDSTACK-9961: Fixed adding

[GitHub] rhtyd closed pull request #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway

rhtyd closed pull request #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway URL: https://github.com/apache/cloudstack/pull/2157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rhtyd commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway

rhtyd commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway URL: https://github.com/apache/cloudstack/pull/2157#issuecomment-343203210 LGTM. This ensure that we throw exception only when the provided gateway is neither a valid ip or domain.

[GitHub] rhtyd commented on issue #2152: improved logging, removed usued code

rhtyd commented on issue #2152: improved logging, removed usued code URL: https://github.com/apache/cloudstack/pull/2152#issuecomment-343202543 @pdion891 - ping? This is an automated message from the Apache Git Service. To

[GitHub] rhtyd closed pull request #2170: Corrected Apache Git URL, was git-wip-us

rhtyd closed pull request #2170: Corrected Apache Git URL, was git-wip-us URL: https://github.com/apache/cloudstack/pull/2170 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rhtyd commented on issue #2170: Corrected Apache Git URL, was git-wip-us

rhtyd commented on issue #2170: Corrected Apache Git URL, was git-wip-us URL: https://github.com/apache/cloudstack/pull/2170#issuecomment-343202097 Thanks @alexhitchins for the PR, the latest master has the url fixed - will close this PR.

[GitHub] blueorangutan commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

blueorangutan commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-343201939 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-343201716 @blueorangutan package

[GitHub] blueorangutan commented on issue #2303: CLOUDSTACK-10123: any entity should use GMT timestamp values

blueorangutan commented on issue #2303: CLOUDSTACK-10123: any entity should use GMT timestamp values URL: https://github.com/apache/cloudstack/pull/2303#issuecomment-343201278 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch? URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-343201223 @SudharmaJain can you fix the conflicts ? This

[GitHub] rhtyd commented on issue #2303: CLOUDSTACK-10123: any entity should use GMT timestamp values

rhtyd commented on issue #2303: CLOUDSTACK-10123: any entity should use GMT timestamp values URL: https://github.com/apache/cloudstack/pull/2303#issuecomment-343200899 LGTM, pending testing. @blueorangutan package This is

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-343200668 @fmaximus I think I closed that old PR, can kick one over the weekend.

[GitHub] blueorangutan commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped

blueorangutan commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped URL: https://github.com/apache/cloudstack/pull/2308#issuecomment-343200245 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] rhtyd commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped

rhtyd commented on issue #2308: CLOUDSTACK-8908 After copying the template charging for that template is stopped URL: https://github.com/apache/cloudstack/pull/2308#issuecomment-34329 @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i? URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-343199858 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ? URL: https://github.com/apache/cloudstack/pull/2312#discussion_r150003501 ## File path: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ##

[GitHub] rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i? URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-343199651 LGTM, pending testing. @blueorangutan package

[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-343199503 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-343199371 LGTM, pending testing. @blueorangutan package This

[GitHub] fmaximus commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

fmaximus commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-343199401 @rhtyd This branch is against 4.9, is there a baseline of failures on 4.9?

[GitHub] rhtyd commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system

rhtyd commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system URL: https://github.com/apache/cloudstack/pull/2310#issuecomment-343199061 LGTM, pending testing. @blueorangutan package

[GitHub] blueorangutan commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system

blueorangutan commented on issue #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system URL: https://github.com/apache/cloudstack/pull/2310#issuecomment-343199135 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack] branch master updated: Fix GroupBy (+ having) condition and tests (#1723)

This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new f0eabad Fix GroupBy (+ having) condition

[GitHub] rhtyd closed pull request #1723: Fix GroupBy (+ having) condition and tests

rhtyd closed pull request #1723: Fix GroupBy (+ having) condition and tests URL: https://github.com/apache/cloudstack/pull/1723 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rhtyd commented on issue #1723: Fix GroupBy (+ having) condition and tests

rhtyd commented on issue #1723: Fix GroupBy (+ having) condition and tests URL: https://github.com/apache/cloudstack/pull/1723#issuecomment-343190547 LGTM. Given it's just refactoring method (dead code) used only in a unit test (possible other forks/integrations), I'll merge this.

[GitHub] blueorangutan commented on issue #1723: Fix GroupBy (+ having) condition and tests

blueorangutan commented on issue #1723: Fix GroupBy (+ having) condition and tests URL: https://github.com/apache/cloudstack/pull/1723#issuecomment-343177285 Trillian test result (tid-1639) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29263

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343171696 Packaging result: ?centos6 ?centos7 ?debian. JID-1231 This is an automated message

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343164514 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343164479 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343090317 Packaging result: ?centos6 ?centos7 ?debian. JID-1230 This is an automated message

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343084070 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343084312 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nvazquez commented on issue #2281: CLOUDSTACK-10102: New network type (L2)

nvazquez commented on issue #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-343122237 @borisstoyanov @rhtyd tests fixed, thanks for your review This is an

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343090317 Packaging result: ?centos6 ?centos7 ?debian. JID-1230 This is an automated message

[GitHub] blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)

blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-343089930 Trillian test result (tid-1638) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26048

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343084312 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-342839257 Packaging result: ?centos6 ?centos7 ?debian. JID-1226 This is an automated message

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-343084070 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-342831824 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-342831989 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2314: CLOUDSTACK-10136: Fix RemoteHostEndPoint thread growth

borisstoyanov commented on issue #2314: CLOUDSTACK-10136: Fix RemoteHostEndPoint thread growth URL: https://github.com/apache/cloudstack/pull/2314#issuecomment-343081802 LGTM, tests does not show any regressions related to this change.