[GitHub] greut commented on issue #2392: dateutil: constistency of tzdate input and output

greut commented on issue #2392: dateutil: constistency of tzdate input and output URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367932264 @rafaelweingartner after a rebase, the only thing I see is _The job exceeded the maximum time limit for jobs, and has been

[GitHub] niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM. URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367904712 @rhtyd @rafaelweingartner : As there are issues in rebasing against 4.11, I am

[GitHub] blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367856506 Packaging result: ?centos6 ?centos7 ?debian. JID-1731

[GitHub] rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-367855144 Ping @syed This is an automated message from the Apache Git

[GitHub] rafaelweingartner commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

rafaelweingartner commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-367854738 Ping @SudharmaJain This is an

[GitHub] rafaelweingartner commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

rafaelweingartner commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds URL: https://github.com/apache/cloudstack/pull/2244#issuecomment-367854564 @DaanHoogland and @rhtyd what are your stances here?

[GitHub] rafaelweingartner commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

rafaelweingartner commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-367854135 @GabrielBrascher can you rebase and fix conflicts?

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367853792 @greut can you take a look into travis failures? This

[GitHub] rafaelweingartner commented on issue #2400: CLOUDSTACK-8900 listLdapUsers with listType=new only filters users for logged-in user account

rafaelweingartner commented on issue #2400: CLOUDSTACK-8900 listLdapUsers with listType=new only filters users for logged-in user account URL: https://github.com/apache/cloudstack/pull/2400#issuecomment-367853649 Ping @SudharmaJain

[GitHub] rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-367853242 @khos2ow can you provide some inputs regarding @rhtyd inquiry? This one is ready to go.

[GitHub] rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-367852939 Ok, no problem. Can you look into travis errors?

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-367852746 @marcaurele there are some tests using an assert with a string `'true'`, and not a

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-367851868 @rhtyd what is your stance here? This is an automated

[cloudstack] annotated tag 4.8.2.0 updated (4a1f7ed -> 8c948ac)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to annotated tag 4.8.2.0 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. *** WARNING: tag 4.8.2.0 was modified! *** from 4a1f7ed (commit) to 8c948ac (tag) tagging

[cloudstack] annotated tag portgroup_no_gc_tag updated (9a8841d -> ffe8428)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to annotated tag portgroup_no_gc_tag in repository https://gitbox.apache.org/repos/asf/cloudstack.git. *** WARNING: tag portgroup_no_gc_tag was modified! *** from 9a8841d (commit) to ffe8428

[cloudstack] annotated tag 4.9.1-RC1 updated (af26799 -> 2d788ee)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to annotated tag 4.9.1-RC1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. *** WARNING: tag 4.9.1-RC1 was modified! *** from af26799 (commit) to 2d788ee (tag) tagging

[GitHub] blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367848555 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack] 01/01: Merge pull request #2454 from shapeblue/keystore-utils-sudoer

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit cae32925608815f7defa76621ed9c6a23fab1cef Merge: 264036b f1cf5f9 Author: Rafael Weingärtner

[GitHub] rafaelweingartner closed pull request #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

rafaelweingartner closed pull request #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure URL: https://github.com/apache/cloudstack/pull/2454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[cloudstack] branch 4.11 updated (264036b -> cae3292)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 264036b Merge pull request #2402 from rafaelweingartner/fixCLOUDSTACK-10128 add f1cf5f9 CLOUDSTACK-10283:

[GitHub] rafaelweingartner commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

rafaelweingartner commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367848375 Tests and reviews are ok. I will merge this one then.

[GitHub] rafaelweingartner closed pull request #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

rafaelweingartner closed pull request #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates URL: https://github.com/apache/cloudstack/pull/2457 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[cloudstack] branch master updated (e9da30b -> 06c2948)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e9da30b Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293 add eeba3e4 CLOUDSTACK-10295

[cloudstack] 01/01: Merge pull request #2457 from HiagData/CLOUDSTACK-10295

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 06c2948c65512e52eee26c37ee7d0650f558b658 Merge: e9da30b eeba3e4 Author: Rafael Weingärtner

[GitHub] rafaelweingartner commented on issue #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

rafaelweingartner commented on issue #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates URL: https://github.com/apache/cloudstack/pull/2457#issuecomment-367847724 The tests that failed do not seem to be related to changes introduced here. So, the PR has integration

[cloudstack] 01/01: Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit e9da30b24e8d4df4b22451488e459361435da80c Merge: e532b57 a436426 Author: Rafael Weingärtner

[GitHub] rafaelweingartner closed pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

rafaelweingartner closed pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[cloudstack] branch master updated (e532b57 -> e9da30b)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e532b57 Forward merge #2402 merged on '4.11' branch add 6897155 [CLOUDSTACK-10293] Single view network

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367846443 Two LGTMs, and as it is only a change in JavaScript there is no need for the integration tests. I will merge this

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367846158 @bwsw are you +1 here?

[GitHub] blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367845502 Trillian test result (tid-2277) Environment: kvm-centos7 (x2), Advanced

[GitHub] GabrielBrascher commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

GabrielBrascher commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367841826 Thanks, @rafaelweingartner! Code and Screenshots LGTM.

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367841653 @khos2ow and @pdion891 thanks for this one! BTW, when you mean a load test, you are only talking about

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170110155 ## File path:

[GitHub] rafaelweingartner commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method

rafaelweingartner commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method URL: https://github.com/apache/cloudstack/pull/2439#issuecomment-367838927 Do we need to wait for the integration tests on this one?

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-367838510 Folks, what are the thoughts here? use this ad-hoc approach? Work a bit harder to a more comprehensive solution using a

[GitHub] rafaelweingartner commented on issue #2466: Rare race condition in KVM migration

rafaelweingartner commented on issue #2466: Rare race condition in KVM migration URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-367837741 So, the idea to solve this rare case, is just ignore the exception that happens when you reach such conditions? Will everything else

[GitHub] rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM. URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367836751 @niteshsarda can you please provide us a feedback regarding @rhtyd inquiry?

[GitHub] pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367834144 BTW we are doing some test of this on our side, to make sure we keep support of VR running as PV on legacy

[GitHub] rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170083404 ## File path:

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170077117 ## File path:

[GitHub] rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170073522 ## File path:

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170060637 ## File path:

[GitHub] syed commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

syed commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170059191 ## File path:

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170022564 ## File path:

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367741560 Packaging result: ?centos6 ?centos7 ?debian. JID-1730

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170010228 ## File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config ## @@ -42,7

[GitHub] wido commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

wido commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170009008 ## File path:

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367728567 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

rhtyd commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367728245 @blueorangutan package This is an automated message

[GitHub] rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170005233 ## File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config ## @@ -42,7

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367725070 Ping for review: @DaanHoogland @rafaelweingartner @rhtyd @wido /cc @syed @pdion891

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367725070 Ping for review: @DaanHoogland @rafaelweingartner @rhtyd @wido

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169993368 ## File path:

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169993368 ## File path:

[GitHub] mrunalinikankariya commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

mrunalinikankariya commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169992289 ## File path:

[GitHub] nvazquez opened a new pull request #2466: Rare race condition in KVM migration

nvazquez opened a new pull request #2466: Rare race condition in KVM migration URL: https://github.com/apache/cloudstack/pull/2466 There is a race condition in the monitoring of the migration process on KVM. If the monitor wakes up in the tight window after the migration succeeds, but

[GitHub] blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367692266 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has

[GitHub] borisstoyanov commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

borisstoyanov commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367692200 @blueorangutan test

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169939634 ## File path:

[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-367614531 @rafaelweingartner I'd rather push all together since it does not disturb the build. I had a hard time