[GitHub] rhtyd commented on issue #2552: debian: remove old usage jars during upgrade

2018-04-08 Thread GitBox
rhtyd commented on issue #2552: debian: remove old usage jars during upgrade URL: https://github.com/apache/cloudstack/pull/2552#issuecomment-379573658 @DaanHoogland thanks, I've kept the changes limited to address the issue https://github.com/apache/cloudstack/issues/2542 Ideally, all the

[GitHub] rhtyd commented on issue #2552: debian: remove old usage jars during upgrade

2018-04-08 Thread GitBox
rhtyd commented on issue #2552: debian: remove old usage jars during upgrade URL: https://github.com/apache/cloudstack/pull/2552#issuecomment-379573658 @DaanHoogland thanks, I've kept the changes limited to address the issue https://github.com/apache/cloudstack/issues/2542

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-04-08 Thread GitBox
blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-379571068 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-04-08 Thread GitBox
DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-379571001 @blueorangutan test This is an

[GitHub] rhtyd commented on issue #2551: agent: import letsencrypt X3 cross signed certificate to ssvm agent keystore

2018-04-08 Thread GitBox
rhtyd commented on issue #2551: agent: import letsencrypt X3 cross signed certificate to ssvm agent keystore URL: https://github.com/apache/cloudstack/pull/2551#issuecomment-379559006 Let me re-visit the approach this or next week, we have an interim solution that works if anyone wants to

[GitHub] nitin-maharana commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-08 Thread GitBox
nitin-maharana commented on issue #2536: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-379540352 @DaanHoogland, Thanks for the fix. @rafaelweingartner, I just had a look at the code. Everywhere the check for netmask is performed

[GitHub] nitin-maharana commented on issue #2553: Update inconsistent debugging info in catch block

2018-04-08 Thread GitBox
nitin-maharana commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-379537060 LGTM. This is an automated message from the Apache Git