[GitHub] [cloudstack] rafaelweingartner commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
rafaelweingartner commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488528832 the maven-rats configs can be found in the pom.xml of "cloudstack" java project

[GitHub] [cloudstack] svenvogel commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
svenvogel commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488439687 @rafaelweingartner @DaanHoogland thanks i dont that too. it sounds good. whats better "maven-rats" or "ignore-list" and where we found them?

[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488347410 Trillian test result (tid-3542) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] [cloudstack] richardlawley opened a new pull request #3310: Fix removing static NAT rules with Juniper SRX

2019-05-01 Thread GitBox
richardlawley opened a new pull request #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310 ## Description Fixed the logic for deleting static NAT rules on a Juniper SRX device. Previously the private (trust) rule was not being

[GitHub] [cloudstack] blueorangutan commented on issue #3294: Set default service offering over api and ui

2019-05-01 Thread GitBox
blueorangutan commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-488314879 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2728 This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488314585 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2727

[GitHub] [cloudstack] rafaelweingartner commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
rafaelweingartner commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488309003 @DaanHoogland thanks for the feedback! I did not know that. I recall some e-mail in the past regarding incompatible licenses, but I was

[GitHub] [cloudstack] DaanHoogland commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
DaanHoogland commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488306497 @webermaximilian92 @svenvogel ^^ This is an automated message from the Apache

[GitHub] [cloudstack] DaanHoogland commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
DaanHoogland commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488306357 @rafaelweingartner MIT is compatible with apache v2. ui/css/src/scss/token-input-facebook.scss needs to be added to the ignore-list, though

[GitHub] [cloudstack] blueorangutan commented on issue #3294: Set default service offering over api and ui

2019-05-01 Thread GitBox
blueorangutan commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-488304453 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on issue #3294: Set default service offering over api and ui

2019-05-01 Thread GitBox
DaanHoogland commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-488304190 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] DaanHoogland merged pull request #3190: Include 'removed' async jobs to check recurring snapshots

2019-05-01 Thread GitBox
DaanHoogland merged pull request #3190: Include 'removed' async jobs to check recurring snapshots URL: https://github.com/apache/cloudstack/pull/3190 This is an automated message from the Apache Git Service. To respond to

[cloudstack] branch master updated: Include 'removed' async jobs to check recurring snapshots (#3190)

2019-05-01 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new de54522 Include 'removed' async jobs to

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488302829 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as

[GitHub] [cloudstack] DaanHoogland commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
DaanHoogland commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488302523 not sure if the 'standard' travis smoke tests cover enough of this functionality.

[GitHub] [cloudstack] PaulAngus commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-05-01 Thread GitBox
PaulAngus commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-488283142 retested UI and API. it is possible (by moving and forwards in the wizard and selecting different

[GitHub] [cloudstack] ustcweizhou commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
ustcweizhou commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488263890 > If the issue is mostly prevalent in UI, I would like to propose an alternate - >

[GitHub] [cloudstack] rafaelweingartner commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
rafaelweingartner commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488261005 We still have a problem here: ``` Unapproved licenses: ui/css/src/scss/token-input-facebook.scss ``` The license is:

[GitHub] [cloudstack] blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-05-01 Thread GitBox
blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-488255665 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2726

[GitHub] [cloudstack] blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-05-01 Thread GitBox
blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-488252441 @PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] [cloudstack] PaulAngus commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-05-01 Thread GitBox
PaulAngus commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-488252339 @blueorangutan package This is an

[GitHub] [cloudstack] svenvogel edited a comment on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
svenvogel edited a comment on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488246930 @rafaelweingartner we add the license. can you run you check script again?

[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488249655 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
rhtyd commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488249586 @blueorangutan test This is an automated message

[GitHub] [cloudstack] svenvogel commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
svenvogel commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488248791 @ustcweizhou we will test it and come back :)

[GitHub] [cloudstack] svenvogel commented on issue #3282: Fix slow vm creation when large sf snapshot count

2019-05-01 Thread GitBox
svenvogel commented on issue #3282: Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-488247299 @skattoju4 lets take the other changes to a new PR. LGTM This

[GitHub] [cloudstack] svenvogel commented on issue #3307: Feature add scss to css compiler

2019-05-01 Thread GitBox
svenvogel commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-488246930 @rafaelweingartner can you run you check script again? This is an automated

[GitHub] [cloudstack] anuragaw commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file

2019-05-01 Thread GitBox
anuragaw commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#issuecomment-488246941 @PaulAngus - addressed all the comments in the latest commit. There

[GitHub] [cloudstack] anuragaw commented on issue #3308: [WIP Do not Merge] Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
anuragaw commented on issue #3308: [WIP Do not Merge] Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488246587 More details - Meta key for Mac (Cmd) has no effect on the Console proxy. This is true for with and without the fix

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file

2019-05-01 Thread GitBox
anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#discussion_r280036038 ## File path: ui/config.js ## @@

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file

2019-05-01 Thread GitBox
anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#discussion_r280036042 ## File path: ui/config.js ## @@

[GitHub] [cloudstack] richardlawley opened a new issue #3309: SRX Plugin Fails to Delete Static NAT Rules

2019-05-01 Thread GitBox
richardlawley opened a new issue #3309: SRX Plugin Fails to Delete Static NAT Rules URL: https://github.com/apache/cloudstack/issues/3309 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Juniper SRX Plugin ~~~ # CLOUDSTACK VERSION

[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488242847 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2725

[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488240071 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance

2019-05-01 Thread GitBox
rhtyd commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-488239997 @blueorangutan package This is an automated

[GitHub] [cloudstack] anuragaw commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-05-01 Thread GitBox
anuragaw commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-488229748 If the issue is mostly prevalent in UI, I would like to propose an alternate - 1) Add a

[GitHub] [cloudstack] blueorangutan commented on issue #3308: Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
blueorangutan commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488222087 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2724 This is an

[GitHub] [cloudstack] rhtyd commented on issue #3308: Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
rhtyd commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488221325 I found this old jQuery bug that expects metakey to be sent when ctrl key is hit: https://bugs.jquery.com/ticket/11328 This is a

[GitHub] [cloudstack] blueorangutan commented on issue #3308: Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
blueorangutan commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488219876 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw opened a new pull request #3308: Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
anuragaw opened a new pull request #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308 On VMware Zone, hitting CTRL over Console Proxy will send a mask of Meta key as well. This makes Ctrl+A, Ctrl+E and many functionalities to not

[GitHub] [cloudstack] anuragaw commented on issue #3308: Ignore META key mask if control was pressed.

2019-05-01 Thread GitBox
anuragaw commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488219854 @blueorangutan package This is an automated message from the Apache

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010550 ## File path: server/src/main/java/com/cloud/event/Resource.java ## @@ -0,0 +1,227 @@ +// Licensed to the Apache Software

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009781 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r28003 ## File path: server/src/main/java/com/cloud/event/Taxonomies.java ## @@ -0,0 +1,451 @@ +// Licensed to the Apache Software

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010037 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009938 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009851 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009750 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010486 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010693 ## File path: server/src/main/java/com/cloud/event/Taxonomies.java ## @@ -0,0 +1,451 @@ +// Licensed to the Apache Software

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009209 ## File path: api/src/main/java/com/cloud/event/EventTypes.java ## @@ -90,7 +90,9 @@ public static final String

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009675 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -17,39 +17,42 @@ package com.cloud.event;

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-05-01 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009790 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long