[GitHub] [cloudstack] DaanHoogland commented on issue #3755: Added zone check for attach iso

2019-12-12 Thread GitBox
DaanHoogland commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-565340806 HOLD ON this one until the branching is fixed This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on issue #3755: Added zone check for attach iso

2019-12-12 Thread GitBox
DaanHoogland commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-565337412 @Spaceman1984 this is a typical bug fix. i think want it in 4.13 as well This

[GitHub] [cloudstack] shwstppr commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch

2019-12-12 Thread GitBox
shwstppr commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-565336917 I'm not sure if adding checksum parameter would add any functionality to the user or solve the problem here. As mentioned above copy

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357514279 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-12 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-565328669 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-462 This

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3765: Promiscuous vm reject

2019-12-12 Thread GitBox
Spaceman1984 opened a new pull request #3765: Promiscuous vm reject URL: https://github.com/apache/cloudstack/pull/3765 ## Description When adding a nic to a vm, the network offiring details were ignored. This change passes the network offering details to vsphere.

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-12 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-565323925 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-12 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-565323763 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] cl-k-takahashi opened a new pull request #3764: [WIP DO NOT MERGE] Refer pod_ip_range_map table instead of host_pod_ref.decription.

2019-12-12 Thread GitBox
cl-k-takahashi opened a new pull request #3764: [WIP DO NOT MERGE] Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764 ## Description Make `host_pod_ref` table satisfy 1NF by creating new table `pod_ip_range_map`

[GitHub] [cloudstack] cl-k-takahashi commented on issue #3762: [DB] cloud.host_pod_ref.description is not 1NF.

2019-12-12 Thread GitBox
cl-k-takahashi commented on issue #3762: [DB] cloud.host_pod_ref.description is not 1NF. URL: https://github.com/apache/cloudstack/issues/3762#issuecomment-565279579 I'm working on this. I added new line to `spring-engine-schema-core-daos-context.xml` like below: `` But

[GitHub] [cloudstack] blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2019-12-12 Thread GitBox
blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-565201402 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-460

[GitHub] [cloudstack] blueorangutan commented on issue #3729: config: add isdynamic flag in configuration response

2019-12-12 Thread GitBox
blueorangutan commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-565201403 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-461

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: Enable PVLAN support on L2 networks

2019-12-12 Thread GitBox
andrijapanicsb commented on issue #3732: Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-565198283 Can we update the desc to note that this PR only provides support for VMware (KVM and XS to come later) @nvazquez ?

[GitHub] [cloudstack] rhtyd commented on issue #3729: config: add isdynamic flag in configuration response

2019-12-12 Thread GitBox
rhtyd commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-565187908 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3729: config: add isdynamic flag in configuration response

2019-12-12 Thread GitBox
blueorangutan commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-565188000 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2019-12-12 Thread GitBox
blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-565185588 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2019-12-12 Thread GitBox
rhtyd commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-565185400 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] kovukono opened a new issue #3763: Issue with hairpinning for port forwarding

2019-12-12 Thread GitBox
kovukono opened a new issue #3763: Issue with hairpinning for port forwarding URL: https://github.com/apache/cloudstack/issues/3763 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VR ~~~ # CLOUDSTACK VERSION ~~~ 4.12 ~~~

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357220615 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357234744 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357239910 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357233903 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357239145 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357229159 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357238510 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357234341 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r357233643 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357194596 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357131815 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41200to41300.java ## @@ -101,49 +101,13

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357195602 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357196766 ## File path: test/integration/smoke/test_templates.py ## @@ -1354,3 +1353,5 @@ def

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357195045 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357147175 ## File path: server/src/main/java/com/cloud/api/UploadServlet.java ## @@ -0,0 +1,90 @@ +// Licensed to the

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357160678 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357196452 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357206187 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357169755 ## File path: server/src/main/java/com/cloud/storage/secondary/NfsMountCapacityChecker.java ## @@ -0,0 +1,69 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357206511 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357175534 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -602,11 +617,13 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357183308 ## File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java ## @@ -316,19 +327,31 @@ private

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357207312 ## File path: ui/config.js ## @@ -17,6 +17,7 @@ // Define custom options configurable by admins for UI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357186195 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ## @@ -419,7 +454,135 @@ public

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357147918 ## File path: server/src/main/java/com/cloud/api/UploadServlet.java ## @@ -0,0 +1,90 @@ +// Licensed to the

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357156305 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/HttpSystemTemplateDownloader.java

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357194810 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357172286 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -211,8 +219,14 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357144008 ## File path: scripts/storage/secondary/cloud-install-sys-tmplt ## @@ -235,12 +250,12 @@ then failed 5 fi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357198690 ## File path: ui/scripts/sharedFunctions.js ## @@ -1208,17 +1208,21 @@ cloudStack.validate = {

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357131288 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41200to41300.java ## @@ -101,49 +101,13

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357202415 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/DirectTemplateDownloaderImpl.java ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357129664 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDetailsDaoImpl.java ## @@ -16,7 +16,6

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357167383 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +//

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357160061 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357167709 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +//

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357143292 ## File path: plugins/ca/root-ca/pom.xml ## @@ -43,5 +43,10 @@ cloud-framework-ca

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357136169 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41300to41400.sql ## @@ -21,6 +21,7 @@ --

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357148284 ## File path: server/src/main/java/com/cloud/api/UploadServlet.java ## @@ -0,0 +1,90 @@ +// Licensed to the

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357189825 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ## @@ -2037,6 +2200,208 @@ public

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357169187 ## File path: server/src/main/java/com/cloud/storage/secondary/CapacityChecker.java ## @@ -0,0 +1,35 @@ +//

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357130560 ## File path: engine/schema/src/main/java/com/cloud/upgrade/OfficialSystemVMTemplate.java ## @@ -0,0 +1,101 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357126581 ## File path: api/src/main/java/org/apache/cloudstack/api/response/ActivateSystemVMTemplateResponse.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357152368 ## File path: server/src/main/java/com/cloud/storage/copy/NfsManagementServerCopier.java ## @@ -0,0 +1,118 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357194708 ## File path: test/integration/smoke/test_activate_template.py ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python +#

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357125525 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357174176 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -330,8 +345,8 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357127029 ## File path: api/src/main/java/org/apache/cloudstack/api/response/SeedSystemVMTemplateResponse.java ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357141792 ## File path: engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357124501 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357125962 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-12 Thread GitBox
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357126648 ## File path: api/src/main/java/org/apache/cloudstack/api/response/GetSystemVMTemplateDefaultURLResponse.java ##

[GitHub] [cloudstack] GabrielBrascher commented on issue #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned

2019-12-12 Thread GitBox
GabrielBrascher commented on issue #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned URL: https://github.com/apache/cloudstack/pull/3659#issuecomment-565011374 Fixed conflict on `schema-41300to41400.sql`; now the branch has no conflicts with the master branch.

[GitHub] [cloudstack] svenvogel commented on issue #3737: Add missing HA config keys

2019-12-12 Thread GitBox
svenvogel commented on issue #3737: Add missing HA config keys URL: https://github.com/apache/cloudstack/pull/3737#issuecomment-564999251 @weizhouapache @GabrielBrascher can you check? This is an automated message from the

[GitHub] [cloudstack] rhtyd edited a comment on issue #3601: JDK11, Debian 10 support

2019-12-12 Thread GitBox
rhtyd edited a comment on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-564981511 The only three consistent failures are: ``` test_04_extract_Iso>Failure>1.06>---test_iso.py

[GitHub] [cloudstack] rhtyd commented on issue #3601: JDK11, Debian 10 support

2019-12-12 Thread GitBox
rhtyd commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-564981511 The only three consistent failures are: ``` test_04_extract_Iso>Failure>1.06>---test_iso.py

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: JDK11, Debian 10 support

2019-12-12 Thread GitBox
blueorangutan removed a comment on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-56498 Trillian test result (tid-595) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34984 seconds

[GitHub] [cloudstack] blueorangutan commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-12-12 Thread GitBox
blueorangutan commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-564972044 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-459

[GitHub] [cloudstack] blueorangutan commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-12-12 Thread GitBox
blueorangutan commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-564965882 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-12-12 Thread GitBox
rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-564965762 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] GabrielBrascher closed pull request #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary

2019-12-12 Thread GitBox
GabrielBrascher closed pull request #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary

2019-12-12 Thread GitBox
GabrielBrascher opened a new pull request #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649 ## Description Tested both cases: - Snapshot backed up on Secondary (stored on primary and secondary)

[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-12 Thread GitBox
pavanaravapalli commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r357050017 ## File path:

[GitHub] [cloudstack] borisstoyanov closed pull request #3755: Added zone check for attach iso

2019-12-12 Thread GitBox
borisstoyanov closed pull request #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3755: Added zone check for attach iso

2019-12-12 Thread GitBox
Spaceman1984 opened a new pull request #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755 ## Description This fix adds a check if the iso belongs to the zone the virtual machine is in Fixes: #3588 ## Types

[GitHub] [cloudstack] borisstoyanov commented on issue #3755: Added zone check for attach iso

2019-12-12 Thread GitBox
borisstoyanov commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-564910358 @blueorangutan test This is an automated message from the Apache Git Service.