[GitHub] [cloudstack] shwstppr commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
shwstppr commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#issuecomment-568686211 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#issuecomment-568686235 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r361094981 ## File path:

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r361094952 ## File path:

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3694: Ldap fixes

2019-12-23 Thread GitBox
rhtyd commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r361093243 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -201,33

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r361088492 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ##

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r361088492 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ##

[GitHub] [cloudstack] kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys

2019-12-23 Thread GitBox
kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692#issuecomment-568669047 Sure thing. Thanks. This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3715: break session only on illegal origin

2019-12-23 Thread GitBox
blueorangutan commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568578422 Trillian test result (tid-661) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39033 seconds

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568576437 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568576212 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] borisstoyanov removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
borisstoyanov removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425576 @blueorangutan test centos7 vmware-65u2 This is an

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425639 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568570598 @blueorangutan test centos7 vmware-65u2 This is an

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568570598 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-23 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568525191 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-23 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568525142 @blueorangutan test This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-23 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568525045 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-502

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-23 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568520466 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-23 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568520424 Did a few more changes @DaanHoogland after the review - 1. There was a blocking API call in UI which was not needed

[cloudstack] branch master updated (482d0fd -> 06e1212)

2019-12-23 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 482d0fd 4.13 (#3782) add 5afff61 create template from snapshot regression (partly reverted) (#3767)

[GitHub] [cloudstack] anuragaw edited a comment on issue #3775: New feature: Acquire specific public IP for network

2019-12-23 Thread GitBox
anuragaw edited a comment on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568513608 LGTM to be merged @rakgenius , just need to wait for some commitor's attention to have it in. (I am NOT yet a committor

[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-23 Thread GitBox
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568513608 LGTM to be merged @rakgenius , just need to wait for someone's attention to have it in. (I am NOT yet a committor in ACS else

[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-23 Thread GitBox
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568510736 @anuragaw @DaanHoogland can this be merged? This is an

[cloudstack] branch 4.13 updated (2712dec -> 1003085)

2019-12-23 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2712dec config: add isdynamic flag in configuration response (#3729) add 1003085 Added zone check for attach

[GitHub] [cloudstack] DaanHoogland merged pull request #3755: Added zone check for attach iso

2019-12-23 Thread GitBox
DaanHoogland merged pull request #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] nvazquez commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
nvazquez commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#issuecomment-568478868 Thanks @shwstppr, left some comments after reviewing

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r360883471 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ##

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r360876258 ## File path:

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r360876258 ## File path:

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-23 Thread GitBox
nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r360874557 ## File path:

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3694: Ldap fixes

2019-12-23 Thread GitBox
nvazquez commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360865125 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -201,33

[GitHub] [cloudstack] DaanHoogland opened a new issue #3784: systemVM stuck in starting state

2019-12-23 Thread GitBox
DaanHoogland opened a new issue #3784: systemVM stuck in starting state URL: https://github.com/apache/cloudstack/issues/3784 When a host running system VM's ( SSVM/ Console Proxy / VR ) undergoes a planned or un-planned reboot, after the reboot, the system VM's get stuck in

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3776: Fix HA config keys

2019-12-23 Thread GitBox
anuragaw commented on a change in pull request #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#discussion_r360832376 ## File path: api/src/main/java/com/cloud/resource/ResourceState.java ## @@ -16,12 +16,12 @@ // under the License. package

[GitHub] [cloudstack] borisstoyanov commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
borisstoyanov commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425576 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425639 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] borisstoyanov commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
borisstoyanov commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425217 @blueorangutan help This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568425335 @borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os]

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568410378 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568421535 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568410258 @blueorangutan test centos7+vmware-65u2 This is an

[GitHub] [cloudstack] mdominka commented on a change in pull request #3776: Fix HA config keys

2019-12-23 Thread GitBox
mdominka commented on a change in pull request #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#discussion_r360823981 ## File path: api/src/main/java/com/cloud/resource/ResourceState.java ## @@ -16,12 +16,12 @@ // under the License. package

[GitHub] [cloudstack] blueorangutan commented on issue #3715: break session only on illegal origin

2019-12-23 Thread GitBox
blueorangutan commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568415835 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] borisstoyanov commented on issue #3715: break session only on illegal origin

2019-12-23 Thread GitBox
borisstoyanov commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568415637 @DaanHoogland I don't see how they can be related, but let's do another round maybe? @blueorangutan test

[GitHub] [cloudstack] DaanHoogland commented on issue #3715: break session only on illegal origin

2019-12-23 Thread GitBox
DaanHoogland commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568414092 @borisstoyanov I'm inclined to merge. Do you think the HA errors above can be in any way related?

[GitHub] [cloudstack] mdominka commented on a change in pull request #3776: Fix HA config keys

2019-12-23 Thread GitBox
mdominka commented on a change in pull request #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#discussion_r360818452 ## File path: server/src/main/java/com/cloud/ha/dao/HighAvailabilityDao.java ## @@ -16,12 +16,12 @@ // under the License.

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568406054 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568410378 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568403721 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568403506 @blueorangutan test centos7 + vmware67u3 This is an

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568405870 @blueorangutan test centos7 + vmware-65u2 This is an

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568410258 @blueorangutan test centos7+vmware-65u2 This is an automated

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-23 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360813276 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568406054 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568404136 blueorangutan test centos7 + vmware-65u2 This is an

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568405870 @blueorangutan test centos7 + vmware-65u2 This is an automated

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r360809379 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1348,11

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568404136 blueorangutan test centos7 + vmware-65u2 This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568403721 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-23 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568403506 @blueorangutan test centos7 + vmware67u3 This is an automated