[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2020-01-18 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575973326 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2020-01-18 Thread GitBox
andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575973295 @blueorangutan test This is an automated message f

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2020-01-18 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575943059 Trillian test result (tid-791) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] anuragaw opened a new pull request #3821: Incorrect param name causes test to fail

2020-01-18 Thread GitBox
anuragaw opened a new pull request #3821: Incorrect param name causes test to fail URL: https://github.com/apache/cloudstack/pull/3821 Causes failure in travis. The incorrect param was returning no value back and causing test to fail. ## Description

[GitHub] [cloudstack] svenvogel edited a comment on issue #3179: Redundant VRouter guest network on wrong interface

2020-01-18 Thread GitBox
svenvogel edited a comment on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-575895884 @weizhouapache Thanks. Wei ...i think so 😁 we will test it again its maybe easier but what i saw was very good! --

[GitHub] [cloudstack] svenvogel commented on issue #3179: Redundant VRouter guest network on wrong interface

2020-01-18 Thread GitBox
svenvogel commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-575895884 @weizhouapache i think so 😁 we will test it again its maybe easier but what i saw was very good!

[GitHub] [cloudstack] svenvogel commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
svenvogel commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-575895704 @GabrielBrascher Hi Gabriel. Nice feature! we need to add this to primate too ... i will take care ... 😀 ---

[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface

2020-01-18 Thread GitBox
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-575882424 @svenvogel I will create a PR next week. I did not fully test it. Hope it will be good :-D

[GitHub] [cloudstack] weizhouapache commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

2020-01-18 Thread GitBox
weizhouapache commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts URL: https://github.com/apache/cloudstack/issues/3820#issuecomment-575882334 @somejfn this seems to be different from our issue. ps: you can get more d

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#discussion_r368039328 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.

[GitHub] [cloudstack] weizhouapache commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
weizhouapache commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-575881966 @GabrielBrascher thanks for your work. There are some global settings related to vm disk throttling, it

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#discussion_r368038519 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#discussion_r368039059 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-01-18 Thread GitBox
weizhouapache commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#discussion_r368038444 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.

[cloudstack] branch master updated: Update message when keys are NOT being injected (#3799)

2020-01-18 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 9b7acfd Update message when keys are

[GitHub] [cloudstack] andrijapanicsb merged pull request #3799: Update message when keys are NOT being injected

2020-01-18 Thread GitBox
andrijapanicsb merged pull request #3799: Update message when keys are NOT being injected URL: https://github.com/apache/cloudstack/pull/3799 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack] andrijapanicsb commented on issue #3799: Update message when keys are NOT being injected

2020-01-18 Thread GitBox
andrijapanicsb commented on issue #3799: Update message when keys are NOT being injected URL: https://github.com/apache/cloudstack/pull/3799#issuecomment-575877507 Merging based on 2 x LGMT/approval and automated tests passing, and manual testing (by me). -