[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653364343 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653363889 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653359997 So quotasummary returns the account and domain id in Long vs uuid which breaks primate. Adding a fix

[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-653355392 Packaging result: ✔centos7 ✔debian. JID-1514 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-653345332 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-653345098 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-653257193 Trillian test result (tid-1939) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47854 seconds Marvin logs:

[GitHub] [cloudstack] shwstppr edited a comment on issue #4195: Count mismatch for list diskofferings api

2020-07-02 Thread GitBox
shwstppr edited a comment on issue #4195: URL: https://github.com/apache/cloudstack/issues/4195#issuecomment-653192127 @ravening as per my understanding it cannot always return `result.first.size()`. Second parameter is total count while count of first will be pageSize at max. I can be

[GitHub] [cloudstack] shwstppr edited a comment on issue #4195: Count mismatch for list diskofferings api

2020-07-02 Thread GitBox
shwstppr edited a comment on issue #4195: URL: https://github.com/apache/cloudstack/issues/4195#issuecomment-653192127 @ravening as per my understanding it cannot always return `result.first.size()`. Second parameter is total count while count of first will be pageSize at max.

[GitHub] [cloudstack] shwstppr commented on issue #4195: Count mismatch for list diskofferings api

2020-07-02 Thread GitBox
shwstppr commented on issue #4195: URL: https://github.com/apache/cloudstack/issues/4195#issuecomment-653192127 @ravening as per my understanding it cannot always return `result.first.size()`. Second parameter is total count while count of first will be pageSize. Though your issue

[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653185477 Trillian test result (tid-1936) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40429 seconds Marvin logs:

[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-07-02 Thread GitBox
GabrielBrascher closed pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] div8cn closed pull request #4197: kvm host memory state is always out of date

2020-07-02 Thread GitBox
div8cn closed pull request #4197: URL: https://github.com/apache/cloudstack/pull/4197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] div8cn opened a new pull request #4197: kvm host memory state is always out of date

2020-07-02 Thread GitBox
div8cn opened a new pull request #4197: URL: https://github.com/apache/cloudstack/pull/4197 ## Description When the kvm agent reported the host status, it did not reread the OS memory status. Therefore, the memory data reported every minute is the same (but the actual OS memory has

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-653017853 Cheers @borisstoyanov I'll merge this tomorrow if tests pass. This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd closed pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
rhtyd closed pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653016727 Packaging result: ✔centos7 ✔debian. JID-1513 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653005161 Trillian test result (tid-1931) Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8 Total time taken: 56280 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-653000758 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653000255 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
nvazquez commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-653000234 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652999732 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-652995941 Packaging result: ✔centos7 ✔debian. JID-1512 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] RodrigoDLopez removed a comment on pull request #4194: enable update tags on disk offerings

2020-07-02 Thread GitBox
RodrigoDLopez removed a comment on pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#issuecomment-652665127 @blueorangutan test This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-652981986 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
nvazquez commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-652981782 @rhtyd it is ready for review/merge @blueorangutan package This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-652939720 Packaging result: ✔centos7 ✔debian. JID-1511 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-652933982 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652933874 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
rhtyd commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652933438 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
rhtyd commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-652933422 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-652930880 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count

2020-07-02 Thread GitBox
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-652930395 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-652926338 Packaging result: ✔centos7 ✔debian. JID-1509 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652926337 Packaging result: ✔centos7 ✔debian. JID-1508 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3979: Limit API from trying to start a VM that is already running

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-652926340 Packaging result: ✔centos7 ✔debian. JID-1510 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-652925631 Packaging result: ✔centos7 ✔debian. JID-1507 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652923319 Packaging result: ✔centos7 ✔debian. JID-1506 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652913875 Packaging result: ✖centos7 ✔debian. JID-1505 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3979: Limit API from trying to start a VM that is already running

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-652898460 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #3979: Limit API from trying to start a VM that is already running

2020-07-02 Thread GitBox
rhtyd closed pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
rhtyd commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-652897612 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-652897938 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652897721 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #3979: Limit API from trying to start a VM that is already running

2020-07-02 Thread GitBox
rhtyd commented on pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-652897840 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] kioie opened a new pull request #3979: Limit API from trying to start a VM that is already running

2020-07-02 Thread GitBox
kioie opened a new pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979 ## Description Enhancement for issue #2736 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change)

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652897586 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #3945: server: update template to another template type

2020-07-02 Thread GitBox
rhtyd commented on pull request #3945: URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-652897356 @ustcweizhou do we want to restrict this to root admin only? This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd closed pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
rhtyd closed pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3945: server: update template to another template type

2020-07-02 Thread GitBox
ustcweizhou opened a new pull request #3945: URL: https://github.com/apache/cloudstack/pull/3945 ## Description this contains other changes (1) add isrouting field for vm templates on UI (2) show register URL of template/iso on UI (3) set 'Bootable' field to

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-02 Thread GitBox
ustcweizhou opened a new pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952 ## Description As discussed in https://github.com/apache/cloudstack/pull/3937#issuecomment-595459008 a rule for port forwarding in VPC router might not be needed.

[GitHub] [cloudstack] rhtyd closed pull request #3945: server: update template to another template type

2020-07-02 Thread GitBox
rhtyd closed pull request #3945: URL: https://github.com/apache/cloudstack/pull/3945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] borisstoyanov commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
borisstoyanov commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652897190 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
rhtyd commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652897077 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd closed pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
rhtyd closed pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3944: vpc/server: Fix network statistics for vpc

2020-07-02 Thread GitBox
ustcweizhou opened a new pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944 # Description This contains 3 main changes (1) add NETWORK_STATS_ethX for all nics with public ips in VPC VRs (current: NETWORK_STATS_eth1) (2) DO NOT create records in

[GitHub] [cloudstack] rhtyd closed pull request #3922: leave a note to tell user this is not secure

2020-07-02 Thread GitBox
rhtyd closed pull request #3922: URL: https://github.com/apache/cloudstack/pull/3922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3922: leave a note to tell user this is not secure

2020-07-02 Thread GitBox
rhtyd commented on pull request #3922: URL: https://github.com/apache/cloudstack/pull/3922#issuecomment-652896568 Closing as we've a github issue This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-07-02 Thread GitBox
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-652896492 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-07-02 Thread GitBox
rhtyd closed pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-07-02 Thread GitBox
rhtyd commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-652896263 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652896068 Packaging result: ✔centos7 ✔debian. JID-1504 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
Pearl1594 commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448864123 ## File path: api/src/main/java/org/apache/cloudstack/api/BaseCmd.java ## @@ -264,6 +269,10 @@ public String getActualCommandName() { */

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-65273 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-07-02 Thread GitBox
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-652888392 Better than before, please advise when this is stable and ready for review/merge @nvazquez thnx This is an

[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-02 Thread GitBox
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652888094 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] ravening commented on issue #4155: Domain Limit Exploit for Unlimited Domain Ressources

2020-07-02 Thread GitBox
ravening commented on issue #4155: URL: https://github.com/apache/cloudstack/issues/4155#issuecomment-652875658 I was not able to reproduce the issue 1. I created a domain admin with an initial resource count of 2 cpu and 1GB ram for the entire domain as shown below

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r448845603 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java ## @@ -67,13 +63,6 @@ public String

[GitHub] [cloudstack] borisstoyanov commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
borisstoyanov commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652874308 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652874637 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] ravening commented on a change in pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
ravening commented on a change in pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#discussion_r448838615 ## File path: engine/schema/src/main/java/com/cloud/user/dao/AccountDaoImpl.java ## @@ -157,9 +157,16 @@ public AccountDaoImpl() { @Override

[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-652844275 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-07-02 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-652844499 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login

2020-07-02 Thread GitBox
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-652840465 @Pearl1594 please review thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448788925 ## File path: engine/schema/src/main/java/org/apache/cloudstack/acl/dao/ProjectRoleDaoImpl.java ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448787605 ## File path: api/src/main/java/org/apache/cloudstack/api/BaseCmd.java ## @@ -264,6 +269,10 @@ public String getActualCommandName() { */

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448787251 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@ -472,11 +473,16 @@ public static final String PROJECT =

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448786652 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@ -472,11 +473,16 @@ public static final String PROJECT =

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4128: Role based users in Projects

2020-07-02 Thread GitBox
rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448786652 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@ -472,11 +473,16 @@ public static final String PROJECT =