Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2048961379 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9224 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-10 Thread via GitHub
abh1sar commented on PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2048957224 @rohityadavcloud Gentle reminder for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]

2024-04-10 Thread via GitHub
harikrishna-patnala commented on PR #8887: URL: https://github.com/apache/cloudstack/pull/8887#issuecomment-2048934111 @rp- I see your point about the actual issue with copycommand, though we need to verify with other storages also. Regarding this PR, I feel this check is still valid, may

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

2024-04-10 Thread via GitHub
codecov-commenter commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2048914489 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8815?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2048914473 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

2024-04-10 Thread via GitHub
sureshanaparti commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2048913418 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2048665704 [SF] Trillian test result (tid-9780) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 53804 seconds Marvin logs:

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2048642812 [SF] Trillian test result (tid-9785) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 47593 seconds Marvin logs:

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2048620907 [SF] Trillian test result (tid-9783) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46353 seconds Marvin logs:

(cloudstack) branch dependabot/npm_and_yarn/ui/tar-6.2.1 created (now 0ffc92bb1fd)

2024-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/ui/tar-6.2.1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 0ffc92bb1fd Bump tar from 6.1.11 to 6.2.1 in /ui No new revisions were added

[PR] Bump tar from 6.1.11 to 6.2.1 in /ui [cloudstack]

2024-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #8900: URL: https://github.com/apache/cloudstack/pull/8900 Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1. Release notes Sourced from https://github.com/isaacs/node-tar/releases;>tar's releases. v6.1.13

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2048595845 [SF] Trillian test result (tid-9787) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 42344 seconds Marvin logs:

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2048534645 [SF] Trillian test result (tid-9784) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40372 seconds Marvin logs:

Re: [PR] Add ability to set cpu.threadspercore similar to existing cpu.corespersocket [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8850: URL: https://github.com/apache/cloudstack/pull/8850#issuecomment-2048338168 [SF] Trillian test result (tid-9775) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45453 seconds Marvin logs:

Re: [PR] Quota tariff order [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8347: URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048329441 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9221 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] SMBIOS UUID needs to be sticky when stopping and starting a VM [cloudstack]

2024-04-10 Thread via GitHub
rodrigues8 commented on issue #8261: URL: https://github.com/apache/cloudstack/issues/8261#issuecomment-2048246429 @arencibiafrancisco i also have this problem, you can fix this using options from Veeam/Windows itself, it is not the solution to the problem actually related to Cloudstack,

Re: [PR] Quota tariff order [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8347: URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048213044 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Quota tariff order [cloudstack]

2024-04-10 Thread via GitHub
JoaoJandre commented on PR #8347: URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048212606 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] sanatise trace logging of async jobs [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8892: URL: https://github.com/apache/cloudstack/pull/8892#issuecomment-2047578060 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9217 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] sanatise log in case multiple passwordsa have been passed [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2047569952 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9216 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
JoaoJandre commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047553931 > @JoaoJandre I will start smoke tests on the other PR, but as @rp- mentions, this is now far better tested and had a lot of eyes on it. I think we should go with this one.

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047532698 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9215 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]

2024-04-10 Thread via GitHub
rp- commented on PR #8887: URL: https://github.com/apache/cloudstack/pull/8887#issuecomment-2047486290 I also think we can close this PR, as it would probably never really trigger anyway. As the real problem is somewhere else, as I see now. -- This is an automated message from the

Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]

2024-04-10 Thread via GitHub
rp- commented on PR #8887: URL: https://github.com/apache/cloudstack/pull/8887#issuecomment-2047478008 I could reproduce this today in our lab and created a real issue #8899 out of it, with DEBUG logs. It still might be that the Linstor driver is the only one, who triggers this

[I] Create template from snapshot parallel allocating same NFS secondary storage on agent [cloudstack]

2024-04-10 Thread via GitHub
rp- opened a new issue, #8899: URL: https://github.com/apache/cloudstack/issues/8899 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Storage ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0 ~~~ But I assume also 4.18 is

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2047439682 [SF] Trillian Build Failed (tid-9788) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2047427787 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2047425488 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(cloudstack) 01/01: Merge branch '4.19'

2024-04-10 Thread vishesh
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit a44f28bb312c6070331d852053ebe20aa7753216 Merge: 3fd5680d9a1 c24c1a5c000 Author: Vishesh AuthorDate: Wed Apr 10

(cloudstack) branch main updated (3fd5680d9a1 -> a44f28bb312)

2024-04-10 Thread vishesh
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3fd5680d9a1 Merge remote-tracking branch 'apache/4.19' add c24c1a5c000 Fix VM import & VM delete with custom

Re: [PR] sanatise trace logging of async jobs [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8892: URL: https://github.com/apache/cloudstack/pull/8892#issuecomment-2047405268 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] sanatise log in case multiple passwordsa have been passed [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2047405206 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] sanatise log in case multiple passwordsa have been passed [cloudstack]

2024-04-10 Thread via GitHub
sureshanaparti commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2047404345 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] sanatise trace logging of async jobs [cloudstack]

2024-04-10 Thread via GitHub
sureshanaparti commented on PR #8892: URL: https://github.com/apache/cloudstack/pull/8892#issuecomment-2047403427 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047394316 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047390296 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on code in PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#discussion_r1559331317 ## usage/src/main/java/com/cloud/usage/UsageManagerImpl.java: ## @@ -316,6 +316,7 @@ public boolean start() { _sanity =

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
sureshanaparti commented on code in PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#discussion_r1559329232 ## usage/src/main/java/com/cloud/usage/UsageManagerImpl.java: ## @@ -2183,4 +2186,17 @@ protected void runInContext() { } } } +

Re: [PR] Change iops on offering change [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2047269417 [SF] Trillian Build Failed (tid-9786) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047236578 [SF] Trillian Build Failed (tid-9781) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(cloudstack-www) branch staged-site updated: Automated CloudStack https://cloudstack.staged.apache.org staging website deployment with cloudstack-www branch @ 6eb7d94edf671ff1b1720a07be3cbfc929dc4971

2024-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch staged-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staged-site by this push: new 8b32cad7 Automated

(cloudstack-www) branch staging-site updated (b0b3d4da -> 6eb7d94e)

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git discard b0b3d4da captial to lower case p add b5a9d000 ff-only add a522d907 Merge remote-tracking branch

(cloudstack-www) 02/02: captial to lower case p

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 6eb7d94edf671ff1b1720a07be3cbfc929dc4971 Author: Daan Hoogland AuthorDate: Wed Apr 10 12:58:05 2024 +0200

(cloudstack-www) branch main updated (ccb16992 -> 6eb7d94e)

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from ccb16992 Merge remote-tracking branch 'origin/staging-site' new 83b9e9eb Merge branch 'main' into

(cloudstack-www) 01/02: Merge branch 'main' into staging-site

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 83b9e9eb4639156a7849ae65bb5532855e749ee3 Merge: a01583c0 ccb16992 Author: Daan Hoogland AuthorDate: Wed Apr 10

Re: [PR] Change iops on offering change [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2047215396 @borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Change iops on offering change [cloudstack]

2024-04-10 Thread via GitHub
borisstoyanov commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2047211337 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2047209333 [SF] Trillian Build Failed (tid-9782) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(cloudstack-www) branch staging-site updated: captial to lower case p

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new b0b3d4da captial to lower

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2047189571 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2047185961 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2047187370 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2047184482 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9214 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2047182527 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8649: URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2047178464 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9213 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047175334 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047174196 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047168886 > If you remove the last record (which, in my head is some kind of protection mechanism, but I might be wrong) - don't we run into risk if the following happens: > > *

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2047134482 [SF] Trillian test result (tid-9771) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 49706 seconds Marvin logs:

Re: [I] Mhz speed not shown in import-export KVM instance [cloudstack]

2024-04-10 Thread via GitHub
pcfriek1987 commented on issue #8727: URL: https://github.com/apache/cloudstack/issues/8727#issuecomment-2047100115 So I'm still at a loss here, updated to 4.19.0.1 on the mgmt and agents, tried it on a brand new VM with ubuntu desktop so there is no chance of it caching anything.

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2047081866 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9212 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2047053547 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9211 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047051021 [LL]Trillian test result (tid-6917) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 37965 seconds Marvin logs:

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047041669 @JoaoJandre I will start smoke tests on the other PR, but as @rp- mentions, this is now far better tested and had a lot of eyes on it. I think we should go with this one.

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2047036302 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8897: URL: https://github.com/apache/cloudstack/pull/8897#issuecomment-2047035824 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Unable to destroy/exunge a vm which errored during import [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on issue #8786: URL: https://github.com/apache/cloudstack/issues/8786#issuecomment-2047030761 as pointed out by @vishesh92 in https://github.com/apache/cloudstack/issues/8786#issuecomment-2009873115 this is fixed/prevented by #8813 @pcfriek1987 , please expand

Re: [I] Unable to destroy/exunge a vm which errored during import [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland closed issue #8786: Unable to destroy/exunge a vm which errored during import URL: https://github.com/apache/cloudstack/issues/8786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix VM import & VM delete with custom offering [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland merged PR #8813: URL: https://github.com/apache/cloudstack/pull/8813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(cloudstack) branch 4.19 updated: Fix VM import & VM delete with custom offering (#8813)

2024-04-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new c24c1a5c000 Fix VM import & VM delete with custom

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2047014711 @hsato03 it is a bit hidden in the output but please check https://github.com/apache/cloudstack/actions/runs/8622615987/job/23634113585?pr=8654#step:7:8601 . -- This is an

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8649: URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2046998917 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2046998815 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix VR inheriting boot settings from user's VM [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2046997452 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8649: URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2046992709 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Improve logs in primary storage removal process [cloudstack]

2024-04-10 Thread via GitHub
hsato03 opened a new pull request, #8649: URL: https://github.com/apache/cloudstack/pull/8649 ### Description While listing volumes from a primary storage, volumes from system VMs are not listed, making the primary storage removal process difficult as an exception is thrown if the

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland closed pull request #8649: Improve logs in primary storage removal process URL: https://github.com/apache/cloudstack/pull/8649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8887: URL: https://github.com/apache/cloudstack/pull/8887#issuecomment-2046988425 @rp- , I am not sure. I think that the same command running twice should be prevented by the `executeInSequence` flag. As the host is handled by a single agent, this should

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046983551 [SF] Trillian Build Failed (tid-9779) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
andrijapanicsb commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2046979813 If you remove the last record (which, in my head is some kind of protection mechanism, but I might be wrong) - don't we run into risk if the following happens: - you start 2

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2046942011 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2046939214 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2046936550 [SF] Trillian test result (tid-9766) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51815 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046921860 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2046921803 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2046920070 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046919948 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046869003 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9210 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on code in PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1559028847 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java: ## @@ -89,10 +90,15 @@ public static TemplateObject

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
slavkap commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046814009 @NuxRo, unfortunately, I don't have the environment to test it right now (according to the conversation it's a bit urgent to do it). From what I saw in the code this will fix a

[PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-10 Thread via GitHub
DaanHoogland opened a new pull request, #8898: URL: https://github.com/apache/cloudstack/pull/8898 ### Description This PR fixes an NPE seen in an evironment after an upgrade from 4.15 to 4.17. It is not clear if configuration mistakes where made, but this PR attempts to handle the

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
rp- commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046694350 But TBH, this PR is now far more tested. As I also included this already in some builds for our customers. And the other functional changes are Linstor only related anyway. -- This

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046693041 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046691042 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
rp- commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046683501 > @rp- to expedite the 4.18.2.0 process, could you create a separate PR to fix the bug with the return value of disconnectPhysicalDiskByPath? And leave this one only for cleaning the

[PR] linstor: Do not pretend handling disconnect paths that are non Linstor [cloudstack]

2024-04-10 Thread via GitHub
rp- opened a new pull request, #8897: URL: https://github.com/apache/cloudstack/pull/8897 ### Description Excerpt PR from #8790, that only fixes Linstor adaptor pretending handling paths that don't belong to Linstor. ### Types of changes - [ ]

Re: [PR] Add ability to set cpu.threadspercore similar to existing cpu.corespersocket [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8850: URL: https://github.com/apache/cloudstack/pull/8850#issuecomment-2046660032 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046658264 [SF] Trillian test result (tid-9767) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 40612 seconds Marvin logs:

Re: [PR] Add ability to set cpu.threadspercore similar to existing cpu.corespersocket [cloudstack]

2024-04-10 Thread via GitHub
sureshanaparti commented on PR #8850: URL: https://github.com/apache/cloudstack/pull/8850#issuecomment-2046658973 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046655539 > LGTM, tested manually, the ips are listed > > ![Screenshot 2024-04-10 at 11 29 16 

  1   2   >