Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3270525446 > lgtm, do we also need to test overlapping ranges? good point tested it just now, got an exception https://github.com/user-attachments/assets/ff97280c-3620-4b06

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r208551 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricTagCmd.java: ## @@ -50,25 +50,25 @@ public c

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333285032 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/DeleteTungstenFabricAddressGroupCmd.java: ## @@ -36,18 +36,18

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-3270386504 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14915 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Fix update resource count failure for domains [cloudstack]

2025-09-09 Thread via GitHub
Pearl1594 commented on PR #11138: URL: https://github.com/apache/cloudstack/pull/11138#issuecomment-3272145393 > hey @Pearl1594 , I believe I found a bug that is related to this one. Are you able to confirm if this fix resolves the issue below: > > On our NON-Prod environment environm

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333270854 ## plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/api/responses/OpenDaylightControllerResponse.java: ## @@ -31,23 +3

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333271589 ## plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/api/responses/OpenDaylightControllerResponse.java: ## @@ -31,23 +3

(cloudstack) branch 4.20 updated (f26f8cce178 -> 7044564bab1)

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from f26f8cce178 server: allow adding non-overlapping ipv6 ranges in same vlan (#11556) add fe120b64e70 server: pr

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333246606 ## plugins/network-elements/bigswitch/src/main/java/com/cloud/api/response/BigSwitchBcfDeviceResponse.java: ## @@ -32,29 +32,29 @@ @EntityReference(value = BigSwit

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r259749 ## server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: ## @@ -2088,11 +2088,11 @@ public Boolean doInTransaction(TransactionStatus status

(cloudstack) 01/01: Merge remote-tracking branch 'apache/4.20'

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8089d32740320171f63d3f66d0abd429f455caf5 Merge: 3d6ec29c9bb 7044564bab1 Author: Wei Zhou AuthorDate: Tue Sep 9 19:50:

(cloudstack) branch main updated (3d6ec29c9bb -> 8089d327403)

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3d6ec29c9bb Don't show backup in list_capacity for dummy plugin or if backup_framework is disabled (#11485) a

Re: [I] UI: Cannot log out / Invalid session cookies causes login page to flood API calls [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache closed issue #11078: UI: Cannot log out / Invalid session cookies causes login page to flood API calls URL: https://github.com/apache/cloudstack/issues/11078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r207633 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricServiceGroupCmd.java: ## @@ -51,10 +51,10 @@

Re: [PR] Fix transition exception when scaling Stopped k8s clusters [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on code in PR #11598: URL: https://github.com/apache/cloudstack/pull/11598#discussion_r2333078802 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesCluster.java: ## @@ -89,8 +90,11 @@ enum State {

Re: [PR] Fix update resource count failure for domains [cloudstack]

2025-09-09 Thread via GitHub
daviftorres commented on PR #11138: URL: https://github.com/apache/cloudstack/pull/11138#issuecomment-3271719253 hey @Pearl1594 , I believe I found a bug that is related to this one. Are you able to confirm if this fix resolves the issue below: On our NON-Prod environment environments

(cloudstack) 01/01: Merge remote-tracking branch 'apache/4.19' into 4.20

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7044564bab11627d06ebdb21b95b62c6b38060e5 Merge: f26f8cce178 fe120b64e70 Author: Wei Zhou AuthorDate: Tue Sep 9 19:42:

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332568648 ## engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java: ## @@ -107,7 +107,7 @@ public void deleteRecordsForAccount(Long accountId) { txn.

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-09-09 Thread via GitHub
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-3269872294 @sureshanaparti , 4.19 is out of support. shall we close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add support EL10 & support java 21 for EL10 [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11546: URL: https://github.com/apache/cloudstack/pull/11546#issuecomment-3271469452 [SF] Trillian Build Failed (tid-14262) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add support EL10 & support java 21 for EL10 [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11546: URL: https://github.com/apache/cloudstack/pull/11546#issuecomment-3271438451 [SF] Trillian Build Failed (tid-14260) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-09-09 Thread via GitHub
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-3269859233 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

(cloudstack) branch healthcheck-4.19 updated (210675baae0 -> edd97e3b42f)

2025-09-09 Thread sureshanaparti
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 210675baae0 DO NOT MERGE add d161dc76699 api: use single quote instead of double quote in

Re: [PR] Reserve memory for host [cloudstack]

2025-09-09 Thread via GitHub
soreana commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-3271348714 @phsm Feel free to reopen it or create another PR with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Support network-scope settings and add setting to override vr service offering [cloudstack]

2025-09-09 Thread via GitHub
soreana commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-3271347423 I am no longer have access to the LeaseWeb fork, I can't work continue this PR. I have tried to contact them, but I have not received a response. @phsm Feel free to reopen it or create

Re: [PR] Support network-scope settings and add setting to override vr service offering [cloudstack]

2025-09-09 Thread via GitHub
soreana commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-3271345523 I am no longer have access to the LeaseWeb fork, I can't work continue this PR. I have tried to contact them, but I have not received a response. @phsm Feel free to reopen it or create

Re: [PR] Reserve memory for host [cloudstack]

2025-09-09 Thread via GitHub
soreana commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-3271337700 @DaanHoogland Thank you for closing this issue. @weizhouapache, I am no longer have access to the LeaseWeb fork. I have tried to contact them, but I have not received a response

(cloudstack) branch support-list-policies updated (0a6ac670d6e -> 2e2c12dae49)

2025-09-09 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-list-policies in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0a6ac670d6e add tests for snapshot policy listing add 2e2c12dae49 update tests for listbac

Re: [PR] Import KVM VM: Autodetect vlan id from bridge name [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #11507: URL: https://github.com/apache/cloudstack/pull/11507#issuecomment-3271042334 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix transition exception when scaling Stopped k8s clusters [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11598: URL: https://github.com/apache/cloudstack/pull/11598#issuecomment-3271052734 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fix transition exception when scaling Stopped k8s clusters [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #11598: URL: https://github.com/apache/cloudstack/pull/11598#issuecomment-3271044547 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] extension/proxmox: add console access for instances [cloudstack]

2025-09-09 Thread via GitHub
codecov[bot] commented on PR #11601: URL: https://github.com/apache/cloudstack/pull/11601#issuecomment-3270849839 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11601?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] Move console proxy related global settings to Zone level [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11415: URL: https://github.com/apache/cloudstack/pull/11415#issuecomment-3270860697 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14920 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] server,engine-schema: unlink userdata during acount cleanup [cloudstack]

2025-09-09 Thread via GitHub
shwstppr commented on PR #11595: URL: https://github.com/apache/cloudstack/pull/11595#issuecomment-3270834770 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] extension/proxmox: add console access for instances [cloudstack]

2025-09-09 Thread via GitHub
shwstppr commented on PR #11601: URL: https://github.com/apache/cloudstack/pull/11601#issuecomment-3270829217 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] extension/proxmox: add console access for instances [cloudstack]

2025-09-09 Thread via GitHub
shwstppr opened a new pull request, #11601: URL: https://github.com/apache/cloudstack/pull/11601 ### Description Add console access support for the instances deployed using inbuilt Proxmox Orchestrator extension. Underlying CloudStack queries Proxmox API for console and then passes

Re: [PR] Fix transition exception when scaling Stopped k8s clusters [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11598: URL: https://github.com/apache/cloudstack/pull/11598#issuecomment-3270802472 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14919 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Update backup framework enabled config to global scope [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11567: URL: https://github.com/apache/cloudstack/pull/11567#issuecomment-3270754373 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [HEALTH] 4.22/main Health Check, please don't merge this [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11523: URL: https://github.com/apache/cloudstack/pull/11523#issuecomment-3270386498 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14914 -- This is an automated message from the Apache Git Service. To respond to the message, please

(cloudstack) branch 4.20 updated: CKS: Validate network offering from network if provided rather than global setting (#11528)

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.20 by this push: new 4f5f7d46d28 CKS: Validate network offering from

Re: [I] CS-4.20.1 Public Ipv6 addition [cloudstack]

2025-09-09 Thread via GitHub
DaanHoogland commented on issue #11527: URL: https://github.com/apache/cloudstack/issues/11527#issuecomment-3270607246 fixed by #11556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Move console proxy related global settings to Zone level [cloudstack]

2025-09-09 Thread via GitHub
sonarqubecloud[bot] commented on PR #11415: URL: https://github.com/apache/cloudstack/pull/11415#issuecomment-3270634115 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https:/

Re: [I] CS-4.20.1 Public Ipv6 addition [cloudstack]

2025-09-09 Thread via GitHub
DaanHoogland closed issue #11527: CS-4.20.1 Public Ipv6 addition URL: https://github.com/apache/cloudstack/issues/11527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r258769 ## server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: ## @@ -1494,12 +1494,12 @@ private boolean removeFromLoadBalancerInternal(long loa

Re: [PR] Add support EL10 & support java 21 for EL10 [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11546: URL: https://github.com/apache/cloudstack/pull/11546#issuecomment-3270566019 [SF] Trillian Build Failed (tid-14256) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333412537 ## server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: ## @@ -872,31 +872,31 @@ private UserVm orchestrateRevertToVMSnapshot(Long vmSnapshotId)

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333404800 ## server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: ## @@ -333,18 +333,18 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayNam

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r299354 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -4316,20 +4316,20 @@ private UserVm getUncheckedUserVmResource(DataCenter zone, String hostName,

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332582489 ## plugins/api/discovery/src/main/java/org/apache/cloudstack/api/response/ApiResponseResponse.java: ## @@ -26,19 +26,19 @@ public class ApiResponseResponse exten

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r296577 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -2321,7 +2321,7 @@ public UserVm recoverVirtualMachine(RecoverVMCmd cmd) throws ResourceAllocati

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r295435 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1845,19 +1845,19 @@ public UserVm updateNicIpForVirtualMachine(UpdateVmNicIpCmd cmd) {

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r293344 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1680,21 +1680,21 @@ public UserVm updateDefaultNicForVirtualMachine(UpdateDefaultNicForVMCmd cm

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r283491 ## server/src/main/java/com/cloud/template/TemplateManagerImpl.java: ## @@ -908,12 +908,12 @@ public VirtualMachineTemplate copyTemplate(CopyTemplateCmd cmd) throw

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r269874 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -1453,33 +1453,33 @@ private void validateVmForHostMigration(VirtualMachine vm) {

Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3270490037 Tested OK Steps - add public IPv6 range fd00:2025:9:9::1/64, vlan=1000 - add public IPv6 range fd00:2025:9:10::1/64, vlan=1000 Without this change https://

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r261366 ## server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: ## @@ -2112,12 +2112,12 @@ protected boolean handleSystemLBIpRelease(LoadBalancerV

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r260470 ## server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: ## @@ -2112,12 +2112,12 @@ protected boolean handleSystemLBIpRelease(LoadBalancerV

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333231919 ## plugins/metrics/src/main/java/org/apache/cloudstack/api/ListDbMetricsCmd.java: ## @@ -28,7 +28,7 @@ import javax.inject.Inject; -@APICommand(name="listDbMet

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r246174 ## server/src/main/java/com/cloud/network/NetworkServiceImpl.java: ## @@ -451,8 +451,8 @@ private void verifyDedicatedGuestVlansWithExistingDatacenterVlans(Physica

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r237736 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/response/LinkDomainToLdapResponse.java: ## @@ -26,20 +26,20 @@ public class LinkDomainT

Re: [PR] various fixes for fiberchannel and autoscale prefix option [cloudstack]

2025-09-09 Thread via GitHub
rg9975 commented on code in PR #11071: URL: https://github.com/apache/cloudstack/pull/11071#discussion_r232568 ## engine/schema/pom.xml: ## @@ -106,7 +108,7 @@ templateList.add("systemvmtemplate-${csVersion}.${patch}-x86_64-xen")

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r229551 ## plugins/storage/volume/cloudbyte/src/main/java/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java: ## @@ -28,27 +28,27 @@ @SuppressW

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #11318: URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3270435661 there is only a warning now ``` Compiling '/usr/lib/python3/dist-packages/cloudutils/networkConfig.py'...\r\n/usr/lib/python3/dist-packages/cloudutils/networkConfig.py:156

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r217890 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/SynchronizeTungstenFabricDataCmd.java: ## @@ -40,7 +40,7 @@ pu

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r216100 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/RemoveTungstenFabricPolicyRuleCmd.java: ## @@ -45,13 +45,13 @@

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r209649 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricTagCmd.java: ## @@ -50,25 +50,25 @@ public c

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r214253 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/RemoveTungstenFabricPolicyCmd.java: ## @@ -45,13 +45,13 @@ pub

Re: [PR] various fixes for fiberchannel and autoscale prefix option [cloudstack]

2025-09-09 Thread via GitHub
rg9975 commented on code in PR #11071: URL: https://github.com/apache/cloudstack/pull/11071#discussion_r210326 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java: ## @@ -164,9 +178,10 @@ private KVMPhysicalDisk getPhysical

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r211599 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricTagTypeCmd.java: ## @@ -51,10 +51,10 @@ publ

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r210618 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricTagCmd.java: ## @@ -50,25 +50,25 @@ public c

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r200922 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricLogicalRouterCmd.java: ## @@ -51,13 +51,13 @

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r201934 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricNetworkCmd.java: ## @@ -51,10 +51,10 @@ publ

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r200053 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricLBHealthMonitorCmd.java: ## @@ -39,15 +39,15

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333292919 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/DeleteTungstenFabricTagCmd.java: ## @@ -36,18 +36,18 @@ imp

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333267074 ## plugins/network-elements/netscaler/src/main/java/com/cloud/api/response/NetscalerControlCenterResponse.java: ## @@ -25,23 +25,23 @@ public class NetscalerContro

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333290192 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/DeleteTungstenFabricLogicalRouterCmd.java: ## @@ -38,18 +38,18

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333287644 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/DeleteTungstenFabricFirewallRuleCmd.java: ## @@ -36,18 +36,18

Re: [PR] Move console proxy related global settings to Zone level [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11415: URL: https://github.com/apache/cloudstack/pull/11415#issuecomment-3270381938 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333278264 ## plugins/network-elements/stratosphere-ssp/src/main/java/org/apache/cloudstack/api/response/SspResponse.java: ## @@ -28,19 +28,19 @@ @EntityReference(value = Hos

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333277543 ## plugins/network-elements/stratosphere-ssp/src/main/java/org/apache/cloudstack/api/commands/AddSspCmd.java: ## @@ -44,22 +44,22 @@ public class AddSspCmd extends

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333274412 ## plugins/network-elements/palo-alto/src/main/java/com/cloud/api/response/PaloAltoFirewallResponse.java: ## @@ -30,67 +30,67 @@ public class PaloAltoFirewallRespo

Re: [PR] Move console proxy related global settings to Zone level [cloudstack]

2025-09-09 Thread via GitHub
Pearl1594 commented on PR #11415: URL: https://github.com/apache/cloudstack/pull/11415#issuecomment-3270373035 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333261276 ## plugins/network-elements/juniper-contrail/src/main/java/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java: ## @@ -28,35 +28,35 @@

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333257857 ## plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java: ## @@ -584,7 +584,7 @@ prot

Re: [PR] Fix transition exception when scaling Stopped k8s clusters [cloudstack]

2025-09-09 Thread via GitHub
bernardodemarco commented on code in PR #11598: URL: https://github.com/apache/cloudstack/pull/11598#discussion_r2333188529 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesCluster.java: ## @@ -89,8 +90,11 @@ enum State {

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333079941 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/response/RemoveVirtualMachinesFromKubernetesClusterResponse.java: ## @@ -22,7 +22

Re: [PR] ssvm: use mgmt network if no storage network [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache commented on PR #10735: URL: https://github.com/apache/cloudstack/pull/10735#issuecomment-3270215267 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Track volume usage data at a vm granularity as well [cloudstack]

2025-09-09 Thread via GitHub
abh1sar commented on PR #11531: URL: https://github.com/apache/cloudstack/pull/11531#issuecomment-3270191065 > code looks good in isolation @abh1sar , but I see some bears on the road: what if someone upgrades from 20.1 to 21 and then on to 22; How do we guarantee they get the DB updates? I

Re: [PR] Track volume usage data at a vm granularity as well [cloudstack]

2025-09-09 Thread via GitHub
abh1sar closed pull request #11531: Track volume usage data at a vm granularity as well URL: https://github.com/apache/cloudstack/pull/11531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

(cloudstack) branch 4.20 updated: ui: donot remove account, domain from query on public ip filter change (#11575)

2025-09-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.20 by this push: new 3ffd4442946 ui: donot remove account, domain from

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332075302 ## api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java: ## @@ -26,107 +26,107 @@ @SuppressWarnings("unused") public class CapabilitiesR

(cloudstack) branch healthcheck-main updated (55fe2fe4d1e -> fab96e9771f)

2025-09-09 Thread sureshanaparti
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch healthcheck-main in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 55fe2fe4d1e 4.21/main Health Check, please don't merge this! add 66a584624f7 Update md5sum

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333078094 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/response/KubernetesSupportedVersionResponse.java: ## @@ -31,7 +31,7 @@ @EntityRe

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333068950 ## plugins/integrations/cloudian/src/main/java/org/apache/cloudstack/cloudian/response/CloudianSsoLoginResponse.java: ## @@ -25,7 +25,7 @@ public class CloudianS

Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

2025-09-09 Thread via GitHub
rajujith commented on code in PR #7857: URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332112335 ## api/src/main/java/org/apache/cloudstack/api/response/LoadBalancerResponse.java: ## @@ -28,91 +28,91 @@ @SuppressWarnings("unused") public class LoadBalancerRes

(cloudstack) branch 4.19 updated: server: prevent vm schedule update failure for time when not changed (#11314)

2025-09-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new fe120b64e70 server: prevent vm schedule update

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-09-09 Thread via GitHub
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-3269901512 > @sureshanaparti , 4.19 is out of support. shall we close this PR? @DaanHoogland just checking with @weizhouapache on the same. I think, still there are some PRs targeted

Re: [I] schedule action - enable/disable fails [cloudstack]

2025-09-09 Thread via GitHub
weizhouapache closed issue #11175: schedule action - enable/disable fails URL: https://github.com/apache/cloudstack/issues/11175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update backup framework enabled config to global scope [cloudstack]

2025-09-09 Thread via GitHub
blueorangutan commented on PR #11567: URL: https://github.com/apache/cloudstack/pull/11567#issuecomment-3270076237 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make prog

Re: [PR] Update backup framework enabled config to global scope [cloudstack]

2025-09-09 Thread via GitHub
Copilot commented on code in PR #11567: URL: https://github.com/apache/cloudstack/pull/11567#discussion_r2333008501 ## server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java: ## @@ -946,13 +946,13 @@ public boolean configure(String name, Map params) throws Con

  1   2   >